<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27445">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Coverity: Fix CID1393979<br><br>Fix resource leak in dt_set_bin_prop_by_path().<br><br>Change-Id: I1c4d7e01b25847a2091ad90d2d70711beae55905<br>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com><br>---<br>M src/lib/device_tree.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/27445/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c</span><br><span>index 3d44f39..00b36fd 100644</span><br><span>--- a/src/lib/device_tree.c</span><br><span>+++ b/src/lib/device_tree.c</span><br><span>@@ -944,6 +944,7 @@</span><br><span> </span><br><span>  prop_name = strrchr(path_copy, '/');</span><br><span>         if (!prop_name) {</span><br><span style="color: hsl(120, 100%, 40%);">+             free(path_copy);</span><br><span>             printk(BIOS_ERR, "Path %s does not include '/'\n", path);</span><br><span>          return 1;</span><br><span>    }</span><br><span>@@ -956,10 +957,12 @@</span><br><span>    if (!dt_node) {</span><br><span>              printk(BIOS_ERR, "Failed to %s %s in the device tree\n",</span><br><span>                  create ? "create" : "find", path_copy);</span><br><span style="color: hsl(120, 100%, 40%);">+            free(path_copy);</span><br><span>             return 1;</span><br><span>    }</span><br><span> </span><br><span>        dt_add_bin_prop(dt_node, prop_name, data, data_size);</span><br><span style="color: hsl(120, 100%, 40%);">+ free(path_copy);</span><br><span> </span><br><span>         return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27445">change 27445</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27445"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1c4d7e01b25847a2091ad90d2d70711beae55905 </div>
<div style="display:none"> Gerrit-Change-Number: 27445 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>