<p><a href="https://review.coreboot.org/27435">View Change</a></p><p>31 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c">File src/soc/sifive/fu540/otp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@31">Patch Set #1, Line 31:</a> <code style="font-family:monospace,monospace"> u32 pa; /* Address input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@31">Patch Set #1, Line 31:</a> <code style="font-family:monospace,monospace"> u32 pa; /* Address input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace"> u32 paio; /* Program address input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace"> u32 paio; /* Program address input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@33">Patch Set #1, Line 33:</a> <code style="font-family:monospace,monospace"> u32 pas; /* Program redundancy cell selection input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@33">Patch Set #1, Line 33:</a> <code style="font-family:monospace,monospace"> u32 pas; /* Program redundancy cell selection input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@34">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace"> u32 pce; /* OTP Macro enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@34">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace"> u32 pce; /* OTP Macro enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@35">Patch Set #1, Line 35:</a> <code style="font-family:monospace,monospace"> u32 pclk; /* Clock input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@35">Patch Set #1, Line 35:</a> <code style="font-family:monospace,monospace"> u32 pclk; /* Clock input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> u32 pdin; /* Write data input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> u32 pdin; /* Write data input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> u32 pdout; /* Read data output */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> u32 pdout; /* Read data output */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@38">Patch Set #1, Line 38:</a> <code style="font-family:monospace,monospace"> u32 pdstb; /* Deep standby mode enable input (active low) */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@38">Patch Set #1, Line 38:</a> <code style="font-family:monospace,monospace"> u32 pdstb; /* Deep standby mode enable input (active low) */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@39">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace"> u32 pprog; /* Program mode enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@39">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace"> u32 pprog; /* Program mode enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace"> u32 ptc; /* Test column enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace"> u32 ptc; /* Test column enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> u32 ptm; /* Test mode enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace"> u32 ptm; /* Test mode enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@42">Patch Set #1, Line 42:</a> <code style="font-family:monospace,monospace"> u32 ptm_rep;/* Repair function test mode enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@42">Patch Set #1, Line 42:</a> <code style="font-family:monospace,monospace"> u32 ptm_rep;/* Repair function test mode enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace"> u32 ptr; /* Test row enable inpu */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace"> u32 ptr; /* Test row enable inpu */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@44">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace"> u32 ptrim; /* Repair function enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@44">Patch Set #1, Line 44:</a> <code style="font-family:monospace,monospace"> u32 ptrim; /* Repair function enable input */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"> u32 pwe; /* Write enable input (defines program cycle) */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace"> u32 pwe; /* Write enable input (defines program cycle) */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27435/1/src/soc/sifive/fu540/otp.c@63">Patch Set #1, Line 63:</a> <code style="font-family:monospace,monospace"> // adress to read</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">'adress' may be misspelled - perhaps 'address'?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27435">change 27435</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27435"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I14b010ad9958931e0a98a76f76090fd7c66f19a0 </div>
<div style="display:none"> Gerrit-Change-Number: 27435 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Philipp Hug <philipp@hug.cx> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 Jul 2018 13:17:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>