<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27404">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/{device,drivers}: Use "foo *bar" instead of "foo* bar"<br><br>Change-Id: Ic1c9b1edd8d3206a68854107ddcbc5c51cb487c3<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/device/device.c<br>M src/device/oprom/include/x86emu/regs.h<br>M src/device/oprom/yabel/compat/of.h<br>M src/device/oprom/yabel/debug.c<br>M src/device/oprom/yabel/debug.h<br>M src/device/oprom/yabel/vbe.c<br>M src/drivers/amd/agesa/oem_s3.c<br>M src/drivers/amd/agesa/romstage.c<br>M src/drivers/amd/agesa/state_machine.c<br>M src/drivers/aspeed/common/aspeed_coreboot.h<br>M src/drivers/i2c/tpm/tpm.c<br>M src/drivers/intel/fsp1_0/fastboot_cache.c<br>M src/drivers/intel/fsp1_0/fsp_util.c<br>M src/drivers/intel/fsp1_0/fsp_util.h<br>M src/drivers/intel/fsp1_0/hob.c<br>M src/drivers/intel/gma/edid.c<br>M src/drivers/intel/i210/i210.c<br>M src/drivers/pc80/tpm/tis.c<br>M src/drivers/usb/ehci_debug.c<br>M src/drivers/usb/gadget.c<br>M src/drivers/xgi/common/xgi_coreboot.c<br>21 files changed, 67 insertions(+), 65 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27404/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/device/device.c b/src/device/device.c</span><br><span>index 79dceaa..7ba9d0a 100644</span><br><span>--- a/src/device/device.c</span><br><span>+++ b/src/device/device.c</span><br><span>@@ -195,7 +195,7 @@</span><br><span> return val;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static const char * resource2str(struct resource *res)</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *resource2str(struct resource *res)</span><br><span> {</span><br><span> if (res->flags & IORESOURCE_IO)</span><br><span> return "io";</span><br><span>diff --git a/src/device/oprom/include/x86emu/regs.h b/src/device/oprom/include/x86emu/regs.h</span><br><span>index 8eec112..51e9719 100644</span><br><span>--- a/src/device/oprom/include/x86emu/regs.h</span><br><span>+++ b/src/device/oprom/include/x86emu/regs.h</span><br><span>@@ -306,7 +306,7 @@</span><br><span> unsigned long mem_base;</span><br><span> unsigned long mem_size;</span><br><span> unsigned long abseg;</span><br><span style="color: hsl(0, 100%, 40%);">- void* private;</span><br><span style="color: hsl(120, 100%, 40%);">+ void *private;</span><br><span> X86EMU_regs x86;</span><br><span> } X86EMU_sysEnv;</span><br><span> </span><br><span>diff --git a/src/device/oprom/yabel/compat/of.h b/src/device/oprom/yabel/compat/of.h</span><br><span>index 31c9b59..ce910f7 100644</span><br><span>--- a/src/device/oprom/yabel/compat/of.h</span><br><span>+++ b/src/device/oprom/yabel/compat/of.h</span><br><span>@@ -35,7 +35,7 @@</span><br><span> #ifndef OF_H</span><br><span> #define OF_H</span><br><span> #define p32 int</span><br><span style="color: hsl(0, 100%, 40%);">-#define p32cast (int) (unsigned long) (void*)</span><br><span style="color: hsl(120, 100%, 40%);">+#define p32cast (int) (unsigned long) (void *)</span><br><span> </span><br><span> #define phandle_t p32</span><br><span> #define ihandle_t p32</span><br><span>@@ -50,27 +50,27 @@</span><br><span> </span><br><span> </span><br><span> phandle_t of_finddevice (const char *);</span><br><span style="color: hsl(0, 100%, 40%);">-phandle_t of_peer (phandle_t);</span><br><span style="color: hsl(0, 100%, 40%);">-phandle_t of_child (phandle_t);</span><br><span style="color: hsl(0, 100%, 40%);">-phandle_t of_parent (phandle_t);</span><br><span style="color: hsl(0, 100%, 40%);">-int of_getprop (phandle_t, const char *, void *, int);</span><br><span style="color: hsl(0, 100%, 40%);">-void * of_call_method_3 (const char *, ihandle_t, int);</span><br><span style="color: hsl(120, 100%, 40%);">+phandle_t of_peer(phandle_t);</span><br><span style="color: hsl(120, 100%, 40%);">+phandle_t of_child(phandle_t);</span><br><span style="color: hsl(120, 100%, 40%);">+phandle_t of_parent(phandle_t);</span><br><span style="color: hsl(120, 100%, 40%);">+int of_getprop(phandle_t, const char *, void *, int);</span><br><span style="color: hsl(120, 100%, 40%);">+void *of_call_method_3(const char *, ihandle_t, int);</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-ihandle_t of_open (const char *);</span><br><span style="color: hsl(120, 100%, 40%);">+ihandle_t of_open(const char *);</span><br><span> void of_close(ihandle_t);</span><br><span style="color: hsl(0, 100%, 40%);">-int of_read (ihandle_t , void*, int);</span><br><span style="color: hsl(0, 100%, 40%);">-int of_write (ihandle_t, void*, int);</span><br><span style="color: hsl(0, 100%, 40%);">-int of_seek (ihandle_t, int, int);</span><br><span style="color: hsl(120, 100%, 40%);">+int of_read(ihandle_t, void *, int);</span><br><span style="color: hsl(120, 100%, 40%);">+int of_write(ihandle_t, void *, int);</span><br><span style="color: hsl(120, 100%, 40%);">+int of_seek(ihandle_t, int, int);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void * of_claim(void *, unsigned int , unsigned int );</span><br><span style="color: hsl(0, 100%, 40%);">-void of_release(void *, unsigned int );</span><br><span style="color: hsl(120, 100%, 40%);">+void *of_claim(void *, unsigned int, unsigned int);</span><br><span style="color: hsl(120, 100%, 40%);">+void of_release(void *, unsigned int);</span><br><span> </span><br><span> int of_yield(void);</span><br><span style="color: hsl(0, 100%, 40%);">-void * of_set_callback(void *);</span><br><span style="color: hsl(120, 100%, 40%);">+void *of_set_callback(void *);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int vpd_read(unsigned int , unsigned int , char *);</span><br><span style="color: hsl(0, 100%, 40%);">-int vpd_write(unsigned int , unsigned int , char *);</span><br><span style="color: hsl(0, 100%, 40%);">-int write_mm_log(char *, unsigned int , unsigned short );</span><br><span style="color: hsl(120, 100%, 40%);">+int vpd_read(unsigned int, unsigned int, char *);</span><br><span style="color: hsl(120, 100%, 40%);">+int vpd_write(unsigned int, unsigned int, char *);</span><br><span style="color: hsl(120, 100%, 40%);">+int write_mm_log(char *, unsigned int, unsigned short);</span><br><span> </span><br><span> #endif</span><br><span>diff --git a/src/device/oprom/yabel/debug.c b/src/device/oprom/yabel/debug.c</span><br><span>index daa263e..fc226fe 100644</span><br><span>--- a/src/device/oprom/yabel/debug.c</span><br><span>+++ b/src/device/oprom/yabel/debug.c</span><br><span>@@ -37,7 +37,7 @@</span><br><span> u32 debug_flags = 0;</span><br><span> </span><br><span> void</span><br><span style="color: hsl(0, 100%, 40%);">-dump(u8 * addr, u32 len)</span><br><span style="color: hsl(120, 100%, 40%);">+dump(u8 *addr, u32 len)</span><br><span> {</span><br><span> printf("\n%s(%p, %x):\n", __func__, addr, len);</span><br><span> while (len) {</span><br><span>diff --git a/src/device/oprom/yabel/debug.h b/src/device/oprom/yabel/debug.h</span><br><span>index b1a8600..20db261 100644</span><br><span>--- a/src/device/oprom/yabel/debug.h</span><br><span>+++ b/src/device/oprom/yabel/debug.h</span><br><span>@@ -130,6 +130,6 @@</span><br><span> </span><br><span> #endif //DEBUG</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void dump(u8 * addr, u32 len);</span><br><span style="color: hsl(120, 100%, 40%);">+void dump(u8 *addr, u32 len);</span><br><span> </span><br><span> #endif</span><br><span>diff --git a/src/device/oprom/yabel/vbe.c b/src/device/oprom/yabel/vbe.c</span><br><span>index 5402ddf..c8b99d5 100644</span><br><span>--- a/src/device/oprom/yabel/vbe.c</span><br><span>+++ b/src/device/oprom/yabel/vbe.c</span><br><span>@@ -321,7 +321,7 @@</span><br><span> }</span><br><span> </span><br><span> static u8</span><br><span style="color: hsl(0, 100%, 40%);">-vbe_get_color(u16 color_number, u32 * color_value)</span><br><span style="color: hsl(120, 100%, 40%);">+vbe_get_color(u16 color_number, u32 *color_value)</span><br><span> {</span><br><span> vbe_prepare();</span><br><span> // call VBE function 09h (Set/Get Palette Data Function)</span><br><span>diff --git a/src/drivers/amd/agesa/oem_s3.c b/src/drivers/amd/agesa/oem_s3.c</span><br><span>index 1ca6e5b..ad193e1 100644</span><br><span>--- a/src/drivers/amd/agesa/oem_s3.c</span><br><span>+++ b/src/drivers/amd/agesa/oem_s3.c</span><br><span>@@ -161,5 +161,5 @@</span><br><span> if (!size)</span><br><span> return NULL;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return (void*)(pos + sizeof(UINT32));</span><br><span style="color: hsl(120, 100%, 40%);">+ return (void *)(pos + sizeof(UINT32));</span><br><span> }</span><br><span>diff --git a/src/drivers/amd/agesa/romstage.c b/src/drivers/amd/agesa/romstage.c</span><br><span>index c427927..90fa059 100644</span><br><span>--- a/src/drivers/amd/agesa/romstage.c</span><br><span>+++ b/src/drivers/amd/agesa/romstage.c</span><br><span>@@ -54,7 +54,7 @@</span><br><span> agesa_set_interface(cb);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void * asmlinkage romstage_main(unsigned long bist)</span><br><span style="color: hsl(120, 100%, 40%);">+void *asmlinkage romstage_main(unsigned long bist)</span><br><span> {</span><br><span> struct postcar_frame pcf;</span><br><span> struct sysinfo romstage_state;</span><br><span>diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c</span><br><span>index b73c124..673bf9b 100644</span><br><span>--- a/src/drivers/amd/agesa/state_machine.c</span><br><span>+++ b/src/drivers/amd/agesa/state_machine.c</span><br><span>@@ -53,7 +53,7 @@</span><br><span> </span><br><span> image = LibAmdLocateImage(agesa, agesa + file_size, 4096,</span><br><span> ModuleIdentifier);</span><br><span style="color: hsl(0, 100%, 40%);">- StdHeader->ImageBasePtr = (void*) image;</span><br><span style="color: hsl(120, 100%, 40%);">+ StdHeader->ImageBasePtr = (void *) image;</span><br><span> #endif</span><br><span> }</span><br><span> </span><br><span>@@ -66,10 +66,10 @@</span><br><span> if (IS_ENABLED(CONFIG_CPU_AMD_AGESA_BINARY_PI)) {</span><br><span> agesa_locate_image(&cb->StdHeader);</span><br><span> AMD_IMAGE_HEADER *image =</span><br><span style="color: hsl(0, 100%, 40%);">- (void*)(uintptr_t)cb->StdHeader.ImageBasePtr;</span><br><span style="color: hsl(120, 100%, 40%);">+ (void *)(uintptr_t)cb->StdHeader.ImageBasePtr;</span><br><span> ASSERT(image);</span><br><span> AMD_MODULE_HEADER *module =</span><br><span style="color: hsl(0, 100%, 40%);">- (void*)(uintptr_t)image->ModuleInfoOffset;</span><br><span style="color: hsl(120, 100%, 40%);">+ (void *)(uintptr_t)image->ModuleInfoOffset;</span><br><span> ASSERT(module && module->ModuleDispatcher);</span><br><span> }</span><br><span> }</span><br><span>@@ -83,8 +83,8 @@</span><br><span> dispatcher = AmdAgesaDispatcher;</span><br><span> #endif</span><br><span> #if IS_ENABLED(CONFIG_CPU_AMD_AGESA_BINARY_PI)</span><br><span style="color: hsl(0, 100%, 40%);">- AMD_IMAGE_HEADER *image = (void*)(uintptr_t)StdHeader->ImageBasePtr;</span><br><span style="color: hsl(0, 100%, 40%);">- AMD_MODULE_HEADER *module = (void*)(uintptr_t)image->ModuleInfoOffset;</span><br><span style="color: hsl(120, 100%, 40%);">+ AMD_IMAGE_HEADER *image = (void *)(uintptr_t)StdHeader->ImageBasePtr;</span><br><span style="color: hsl(120, 100%, 40%);">+ AMD_MODULE_HEADER *module = (void *)(uintptr_t)image->ModuleInfoOffset;</span><br><span> dispatcher = module->ModuleDispatcher;</span><br><span> #endif</span><br><span> </span><br><span>diff --git a/src/drivers/aspeed/common/aspeed_coreboot.h b/src/drivers/aspeed/common/aspeed_coreboot.h</span><br><span>index 5a208e6..b974840 100644</span><br><span>--- a/src/drivers/aspeed/common/aspeed_coreboot.h</span><br><span>+++ b/src/drivers/aspeed/common/aspeed_coreboot.h</span><br><span>@@ -73,7 +73,7 @@</span><br><span> };</span><br><span> </span><br><span> static inline void *kzalloc(size_t size, int flags) {</span><br><span style="color: hsl(0, 100%, 40%);">- void* ptr = malloc(size);</span><br><span style="color: hsl(120, 100%, 40%);">+ void *ptr = malloc(size);</span><br><span> memset(ptr, 0, size);</span><br><span> return ptr;</span><br><span> }</span><br><span>diff --git a/src/drivers/i2c/tpm/tpm.c b/src/drivers/i2c/tpm/tpm.c</span><br><span>index 7d69861..447fc24 100644</span><br><span>--- a/src/drivers/i2c/tpm/tpm.c</span><br><span>+++ b/src/drivers/i2c/tpm/tpm.c</span><br><span>@@ -65,7 +65,7 @@</span><br><span> UNKNOWN,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static const char * const chip_name[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *const chip_name[] = {</span><br><span> [SLB9635] = "slb9635tt",</span><br><span> [SLB9645] = "slb9645tt",</span><br><span> [UNKNOWN] = "unknown/fallback to slb9635",</span><br><span>diff --git a/src/drivers/intel/fsp1_0/fastboot_cache.c b/src/drivers/intel/fsp1_0/fastboot_cache.c</span><br><span>index 906b356..76241c8 100644</span><br><span>--- a/src/drivers/intel/fsp1_0/fastboot_cache.c</span><br><span>+++ b/src/drivers/intel/fsp1_0/fastboot_cache.c</span><br><span>@@ -224,7 +224,7 @@</span><br><span> </span><br><span> #endif /* !defined(__PRE_RAM__) */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void * find_and_set_fastboot_cache(void)</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_and_set_fastboot_cache(void)</span><br><span> {</span><br><span> struct mrc_data_container *mrc_cache = NULL;</span><br><span> if (((mrc_cache = find_current_mrc_cache()) == NULL) ||</span><br><span>diff --git a/src/drivers/intel/fsp1_0/fsp_util.c b/src/drivers/intel/fsp1_0/fsp_util.c</span><br><span>index 5a6321d..c19c1a1 100644</span><br><span>--- a/src/drivers/intel/fsp1_0/fsp_util.c</span><br><span>+++ b/src/drivers/intel/fsp1_0/fsp_util.c</span><br><span>@@ -75,7 +75,7 @@</span><br><span> UPD_DATA_REGION fsp_upd_data;</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- memset((void*)&FspRtBuffer, 0, sizeof(FSP_INIT_RT_BUFFER));</span><br><span style="color: hsl(120, 100%, 40%);">+ memset((void *)&FspRtBuffer, 0, sizeof(FSP_INIT_RT_BUFFER));</span><br><span> FspRtBuffer.Common.StackTop = (u32 *)CONFIG_RAMTOP;</span><br><span> FspInitParams.NvsBufferPtr = NULL;</span><br><span> </span><br><span>@@ -100,7 +100,7 @@</span><br><span> }</span><br><span> #endif /* __PRE_RAM__ */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-volatile u8 * find_fsp ()</span><br><span style="color: hsl(120, 100%, 40%);">+volatile u8 *find_fsp()</span><br><span> {</span><br><span> </span><br><span> #ifdef __PRE_RAM__</span><br><span>@@ -175,7 +175,7 @@</span><br><span> * @param hob_list_ptr pointer to the start of the hob list</span><br><span> * @return pointer to saved CAR MEM or NULL if not found.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-void * find_saved_temp_mem(void *hob_list_ptr)</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_saved_temp_mem(void *hob_list_ptr)</span><br><span> {</span><br><span> EFI_GUID temp_hob_guid = FSP_BOOTLOADER_TEMPORARY_MEMORY_HOB_GUID;</span><br><span> EFI_HOB_GUID_TYPE *saved_mem_hob =</span><br><span>@@ -194,7 +194,7 @@</span><br><span> * @param hob_list_ptr pointer to the start of the hob list</span><br><span> * @return pointer to the start of the FSP reserved memory or NULL if not found.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-void * find_fsp_reserved_mem(void *hob_list_ptr)</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_fsp_reserved_mem(void *hob_list_ptr)</span><br><span> {</span><br><span> EFI_GUID fsp_reserved_guid = FSP_HOB_RESOURCE_OWNER_FSP_GUID;</span><br><span> EFI_HOB_RESOURCE_DESCRIPTOR *fsp_reserved_mem =</span><br><span>@@ -221,7 +221,8 @@</span><br><span> }</span><br><span> </span><br><span> if (FspHobListPtr == NULL) {</span><br><span style="color: hsl(0, 100%, 40%);">- FspHobListPtr = (void*)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER));</span><br><span style="color: hsl(120, 100%, 40%);">+ FspHobListPtr = (void *)*((u32 *)</span><br><span style="color: hsl(120, 100%, 40%);">+ cbmem_find(CBMEM_ID_HOB_POINTER));</span><br><span> }</span><br><span> </span><br><span> printk(BIOS_SPEW,"fsp_header_ptr: %p\n", fsp_header_ptr);</span><br><span>@@ -294,7 +295,7 @@</span><br><span> static void find_fsp_hob_update_mrc(void *unused)</span><br><span> {</span><br><span> /* Set the global HOB list pointer */</span><br><span style="color: hsl(0, 100%, 40%);">- FspHobListPtr = (void*)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER));</span><br><span style="color: hsl(120, 100%, 40%);">+ FspHobListPtr = (void *)*((u32 *) cbmem_find(CBMEM_ID_HOB_POINTER));</span><br><span> </span><br><span> if (!FspHobListPtr){</span><br><span> printk(BIOS_ERR, "ERROR: Could not find FSP HOB pointer in CBFS!\n");</span><br><span>diff --git a/src/drivers/intel/fsp1_0/fsp_util.h b/src/drivers/intel/fsp1_0/fsp_util.h</span><br><span>index a3a7dd3..594a259 100644</span><br><span>--- a/src/drivers/intel/fsp1_0/fsp_util.h</span><br><span>+++ b/src/drivers/intel/fsp1_0/fsp_util.h</span><br><span>@@ -22,10 +22,10 @@</span><br><span> </span><br><span> #if IS_ENABLED(CONFIG_ENABLE_MRC_CACHE)</span><br><span> int save_mrc_data(void *hob_start);</span><br><span style="color: hsl(0, 100%, 40%);">-void * find_and_set_fastboot_cache(void);</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_and_set_fastboot_cache(void);</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-volatile u8 * find_fsp(void);</span><br><span style="color: hsl(120, 100%, 40%);">+volatile u8 *find_fsp(void);</span><br><span> void fsp_early_init(FSP_INFO_HEADER *fsp_info);</span><br><span> void FspNotify(u32 Phase);</span><br><span> void FspNotifyReturnPoint(EFI_STATUS Status, VOID *HobListPtr);</span><br><span>@@ -34,16 +34,16 @@</span><br><span> void chipset_fsp_early_init(FSP_INIT_PARAMS *FspInitParams,</span><br><span> FSP_INFO_HEADER *fsp_ptr);</span><br><span> void ChipsetFspReturnPoint(EFI_STATUS Status, VOID *HobListPtr);</span><br><span style="color: hsl(0, 100%, 40%);">-void * find_saved_temp_mem(void *hob_list_ptr);</span><br><span style="color: hsl(0, 100%, 40%);">-void * find_fsp_reserved_mem(void *hob_list_ptr);</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_saved_temp_mem(void *hob_list_ptr);</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_fsp_reserved_mem(void *hob_list_ptr);</span><br><span> </span><br><span> /* functions in hob.c */</span><br><span> void print_hob_mem_attributes(void *Hobptr);</span><br><span> void print_hob_type_structure(u16 Hobtype, void *Hoblistptr);</span><br><span> void print_hob_resource_attributes(void *Hobptr);</span><br><span> void print_guid_type_attributes(void *Hobptr);</span><br><span style="color: hsl(0, 100%, 40%);">-const char * get_hob_type_string(void *Hobptr);</span><br><span style="color: hsl(0, 100%, 40%);">-void * find_hob_by_guid(void *Hoblistptr, EFI_GUID *guid1);</span><br><span style="color: hsl(120, 100%, 40%);">+const char *get_hob_type_string(void *Hobptr);</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_hob_by_guid(void *Hoblistptr, EFI_GUID *guid1);</span><br><span> uint8_t guids_are_equal(EFI_GUID *guid1, EFI_GUID *guid2);</span><br><span> void printguid(EFI_GUID *guid);</span><br><span> </span><br><span>@@ -90,10 +90,10 @@</span><br><span> #define FSP_SIG 0x48505346 /* 'FSPH' */</span><br><span> </span><br><span> #define ERROR_NO_FV_SIG 1</span><br><span style="color: hsl(0, 100%, 40%);">-#define ERROR_NO_FFS_GUID 2</span><br><span style="color: hsl(120, 100%, 40%);">+#define ERROR_NO_FFS_GUID 2</span><br><span> #define ERROR_NO_INFO_HEADER 3</span><br><span> #define ERROR_IMAGEBASE_MISMATCH 4</span><br><span style="color: hsl(0, 100%, 40%);">-#define ERROR_INFO_HEAD_SIG_MISMATCH 5</span><br><span style="color: hsl(120, 100%, 40%);">+#define ERROR_INFO_HEAD_SIG_MISMATCH 5</span><br><span> #define ERROR_FSP_SIG_MISMATCH 6</span><br><span> </span><br><span> #ifndef __PRE_RAM__</span><br><span>diff --git a/src/drivers/intel/fsp1_0/hob.c b/src/drivers/intel/fsp1_0/hob.c</span><br><span>index 1c6d0bb..9334893 100644</span><br><span>--- a/src/drivers/intel/fsp1_0/hob.c</span><br><span>+++ b/src/drivers/intel/fsp1_0/hob.c</span><br><span>@@ -42,7 +42,7 @@</span><br><span> EFI_MEMORY_TYPE Hobmemtype = HobMemoryPtr->AllocDescriptor.MemoryType;</span><br><span> u64 Hobmemaddr = HobMemoryPtr->AllocDescriptor.MemoryBaseAddress;</span><br><span> u64 Hobmemlength = HobMemoryPtr->AllocDescriptor.MemoryLength;</span><br><span style="color: hsl(0, 100%, 40%);">- const char * Hobmemtypenames[15];</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *Hobmemtypenames[15];</span><br><span> </span><br><span> Hobmemtypenames[0] = "EfiReservedMemoryType";</span><br><span> Hobmemtypenames[1] = "EfiLoaderCode";</span><br><span>@@ -104,7 +104,7 @@</span><br><span> (unsigned long)Hobresaddr, (unsigned long)Hobreslength);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-const char * get_hob_type_string(void *Hobptr)</span><br><span style="color: hsl(120, 100%, 40%);">+const char *get_hob_type_string(void *Hobptr)</span><br><span> {</span><br><span> EFI_HOB_GENERIC_HEADER *HobHeaderPtr = (EFI_HOB_GENERIC_HEADER *)Hobptr;</span><br><span> u16 Hobtype = HobHeaderPtr->HobType;</span><br><span>@@ -215,7 +215,7 @@</span><br><span> * @param guid the GUID of the HOB entry to find</span><br><span> * @return pointer to the start of the requested HOB or NULL if not found.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-void * find_hob_by_guid(void *current_hob, EFI_GUID *guid)</span><br><span style="color: hsl(120, 100%, 40%);">+void *find_hob_by_guid(void *current_hob, EFI_GUID *guid)</span><br><span> {</span><br><span> do {</span><br><span> switch (((EFI_HOB_GENERIC_HEADER *)current_hob)->HobType) {</span><br><span>@@ -255,8 +255,8 @@</span><br><span> */</span><br><span> uint8_t guids_are_equal(EFI_GUID *guid1, EFI_GUID *guid2)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- uint64_t* guid_1 = (void *) guid1;</span><br><span style="color: hsl(0, 100%, 40%);">- uint64_t* guid_2 = (void *) guid2;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint64_t *guid_1 = (void *) guid1;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint64_t *guid_2 = (void *) guid2;</span><br><span> </span><br><span> if ((*(guid_1) != *(guid_2)) || (*(guid_1 + 1) != *(guid_2 + 1)))</span><br><span> return 0;</span><br><span>diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c</span><br><span>index 316e869..13b301f 100644</span><br><span>--- a/src/drivers/intel/gma/edid.c</span><br><span>+++ b/src/drivers/intel/gma/edid.c</span><br><span>@@ -39,7 +39,7 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void intel_gmbus_stop_bus(u8 * mmio, u8 bus)</span><br><span style="color: hsl(120, 100%, 40%);">+static void intel_gmbus_stop_bus(u8 *mmio, u8 bus)</span><br><span> {</span><br><span> wait_rdy(mmio);</span><br><span> write32(GMBUS0_ADDR, bus);</span><br><span>diff --git a/src/drivers/intel/i210/i210.c b/src/drivers/intel/i210/i210.c</span><br><span>index 2eae6a9..32d27f7 100644</span><br><span>--- a/src/drivers/intel/i210/i210.c</span><br><span>+++ b/src/drivers/intel/i210/i210.c</span><br><span>@@ -26,7 +26,7 @@</span><br><span> </span><br><span> /* This is a private function to wait for a bit mask in a given register */</span><br><span> /* To avoid endless loops, a time-out is implemented here. */</span><br><span style="color: hsl(0, 100%, 40%);">-static int wait_done(uint32_t* reg, uint32_t mask)</span><br><span style="color: hsl(120, 100%, 40%);">+static int wait_done(uint32_t *reg, uint32_t mask)</span><br><span> {</span><br><span> uint32_t timeout = I210_POLL_TIMEOUT_US;</span><br><span> </span><br><span>@@ -58,7 +58,7 @@</span><br><span> bar = pci_read_config32(dev, PCI_BASE_ADDRESS_0);</span><br><span> if ((!bar) || ((address + count) > 0x40))</span><br><span> return I210_INVALID_PARAM;</span><br><span style="color: hsl(0, 100%, 40%);">- eeprd = (uint32_t*)(bar + I210_REG_EEREAD);</span><br><span style="color: hsl(120, 100%, 40%);">+ eeprd = (uint32_t *)(bar + I210_REG_EEREAD);</span><br><span> /* Prior to start ensure flash interface is ready by checking DONE-bit */</span><br><span> if (wait_done(eeprd, I210_DONE))</span><br><span> return I210_NOT_READY;</span><br><span>@@ -122,8 +122,8 @@</span><br><span> bar = pci_read_config32(dev, 0x10);</span><br><span> if ((!bar) || ((address + count) > 0x40))</span><br><span> return I210_INVALID_PARAM;</span><br><span style="color: hsl(0, 100%, 40%);">- eepwr = (uint32_t*)(bar + I210_REG_EEWRITE);</span><br><span style="color: hsl(0, 100%, 40%);">- eectrl = (uint32_t*)(bar + I210_REG_EECTRL);</span><br><span style="color: hsl(120, 100%, 40%);">+ eepwr = (uint32_t *)(bar + I210_REG_EEWRITE);</span><br><span style="color: hsl(120, 100%, 40%);">+ eectrl = (uint32_t *)(bar + I210_REG_EECTRL);</span><br><span> /* Prior to start ensure flash interface is ready by checking DONE-bit */</span><br><span> if (wait_done(eepwr, I210_DONE))</span><br><span> return I210_NOT_READY;</span><br><span>@@ -166,7 +166,7 @@</span><br><span> return I210_READ_ERROR;</span><br><span> /* Copy the address into destination. This is done because of possible */</span><br><span> /* not matching alignment for destination to uint16_t boundary. */</span><br><span style="color: hsl(0, 100%, 40%);">- memcpy(mac_adr, (uint8_t*)adr, 6);</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(mac_adr, (uint8_t *)adr, 6);</span><br><span> return I210_SUCCESS;</span><br><span> }</span><br><span> </span><br><span>@@ -181,7 +181,7 @@</span><br><span> if (!dev || !mac_adr)</span><br><span> return I210_INVALID_PARAM;</span><br><span> /* Copy desired address into a local buffer to avoid alignment issues */</span><br><span style="color: hsl(0, 100%, 40%);">- memcpy((uint8_t*)adr, mac_adr, 6);</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy((uint8_t *)adr, mac_adr, 6);</span><br><span> return write_flash(dev, 0, 3, adr);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c</span><br><span>index 3549173..495bb4a 100644</span><br><span>--- a/src/drivers/pc80/tpm/tis.c</span><br><span>+++ b/src/drivers/pc80/tpm/tis.c</span><br><span>@@ -109,13 +109,13 @@</span><br><span> */</span><br><span> struct device_name {</span><br><span> u16 dev_id;</span><br><span style="color: hsl(0, 100%, 40%);">- const char * const dev_name;</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *const dev_name;</span><br><span> };</span><br><span> </span><br><span> struct vendor_name {</span><br><span> u16 vendor_id;</span><br><span style="color: hsl(0, 100%, 40%);">- const char * vendor_name;</span><br><span style="color: hsl(0, 100%, 40%);">- const struct device_name* dev_names;</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *vendor_name;</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct device_name *dev_names;</span><br><span> };</span><br><span> </span><br><span> static const struct device_name atmel_devices[] = {</span><br><span>@@ -443,7 +443,7 @@</span><br><span> * Returns 0 on success, TPM_DRIVER_ERR on error (in case the device does</span><br><span> * not accept the entire command).</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-static u32 tis_senddata(const u8 * const data, u32 len)</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 tis_senddata(const u8 *const data, u32 len)</span><br><span> {</span><br><span> u32 offset = 0;</span><br><span> u16 burst = 0;</span><br><span>diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c</span><br><span>index fcc5223..52b4bdd 100644</span><br><span>--- a/src/drivers/usb/ehci_debug.c</span><br><span>+++ b/src/drivers/usb/ehci_debug.c</span><br><span>@@ -631,7 +631,7 @@</span><br><span> </span><br><span> diff = (unsigned)dbg_info->ehci_base - ehci_base;</span><br><span> dbg_info->ehci_debug -= diff;</span><br><span style="color: hsl(0, 100%, 40%);">- dbg_info->ehci_base = (void*)ehci_base;</span><br><span style="color: hsl(120, 100%, 40%);">+ dbg_info->ehci_base = (void *)ehci_base;</span><br><span> </span><br><span> for (i=0; i<DBGP_MAX_ENDPOINTS; i++)</span><br><span> if (dbg_info->ep_pipe[i].status & DBGP_EP_VALID)</span><br><span>diff --git a/src/drivers/usb/gadget.c b/src/drivers/usb/gadget.c</span><br><span>index 37e97a3..3254a8a 100644</span><br><span>--- a/src/drivers/usb/gadget.c</span><br><span>+++ b/src/drivers/usb/gadget.c</span><br><span>@@ -29,7 +29,7 @@</span><br><span> #define USB_HUB_C_PORT_RESET 20</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int hub_port_status(const char * buf, int feature)</span><br><span style="color: hsl(120, 100%, 40%);">+static int hub_port_status(const char *buf, int feature)</span><br><span> {</span><br><span> return !!(buf[feature>>3] & (1<<(feature&0x7)));</span><br><span> }</span><br><span>diff --git a/src/drivers/xgi/common/xgi_coreboot.c b/src/drivers/xgi/common/xgi_coreboot.c</span><br><span>index 9cd634c..47320fd 100644</span><br><span>--- a/src/drivers/xgi/common/xgi_coreboot.c</span><br><span>+++ b/src/drivers/xgi/common/xgi_coreboot.c</span><br><span>@@ -130,8 +130,9 @@</span><br><span> </span><br><span> hw_info->ulVideoMemorySize = xgifb_info->video_size;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- xgifb_info->video_vbase = hw_info->pjVideoMemoryAddress = (void*)(intptr_t)xgifb_info->video_base;</span><br><span style="color: hsl(0, 100%, 40%);">- xgifb_info->mmio_vbase = (void*)(intptr_t)xgifb_info->mmio_base;</span><br><span style="color: hsl(120, 100%, 40%);">+ xgifb_info->video_vbase = hw_info->pjVideoMemoryAddress =</span><br><span style="color: hsl(120, 100%, 40%);">+ (void *)(intptr_t)xgifb_info->video_base;</span><br><span style="color: hsl(120, 100%, 40%);">+ xgifb_info->mmio_vbase = (void *)(intptr_t)xgifb_info->mmio_base;</span><br><span> </span><br><span> dev_info(&pdev->dev,</span><br><span> "Framebuffer at 0x%Lx, mapped to 0x%p, size %dk\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27404">change 27404</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27404"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic1c9b1edd8d3206a68854107ddcbc5c51cb487c3 </div>
<div style="display:none"> Gerrit-Change-Number: 27404 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>