<p><a href="https://review.coreboot.org/26942">View Change</a></p><p>73 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/cpu/amd/family_10h-family_15h/init_cpus.c">File src/cpu/amd/family_10h-family_15h/init_cpus.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/cpu/amd/family_10h-family_15h/init_cpus.c@380">Patch Set #14, Line 380:</a> <code style="font-family:monospace,monospace"> void *lower_stack_region_boundary = (void *)(bsp_stack_region_lower_boundary - max_ap_stack_region_size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h">File src/device/oprom/yabel/compat/of.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@38">Patch Set #14, Line 38:</a> <code style="font-family:monospace,monospace">#define p32cast (int) (unsigned long) (void *)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@53">Patch Set #14, Line 53:</a> <code style="font-family:monospace,monospace">phandle_t of_peer(phandle_t);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'phandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@54">Patch Set #14, Line 54:</a> <code style="font-family:monospace,monospace">phandle_t of_child(phandle_t);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'phandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@55">Patch Set #14, Line 55:</a> <code style="font-family:monospace,monospace">phandle_t of_parent(phandle_t);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'phandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@56">Patch Set #14, Line 56:</a> <code style="font-family:monospace,monospace">int of_getprop(phandle_t, const char *, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'phandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@56">Patch Set #14, Line 56:</a> <code style="font-family:monospace,monospace">int of_getprop(phandle_t, const char *, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'const char *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@56">Patch Set #14, Line 56:</a> <code style="font-family:monospace,monospace">int of_getprop(phandle_t, const char *, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'void *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@56">Patch Set #14, Line 56:</a> <code style="font-family:monospace,monospace">int of_getprop(phandle_t, const char *, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@57">Patch Set #14, Line 57:</a> <code style="font-family:monospace,monospace">void *of_call_method_3(const char *, ihandle_t, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'const char *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@57">Patch Set #14, Line 57:</a> <code style="font-family:monospace,monospace">void *of_call_method_3(const char *, ihandle_t, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'ihandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@57">Patch Set #14, Line 57:</a> <code style="font-family:monospace,monospace">void *of_call_method_3(const char *, ihandle_t, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@60">Patch Set #14, Line 60:</a> <code style="font-family:monospace,monospace">ihandle_t of_open(const char *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'const char *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@62">Patch Set #14, Line 62:</a> <code style="font-family:monospace,monospace">int of_read(ihandle_t, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'ihandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@62">Patch Set #14, Line 62:</a> <code style="font-family:monospace,monospace">int of_read(ihandle_t, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'void *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@62">Patch Set #14, Line 62:</a> <code style="font-family:monospace,monospace">int of_read(ihandle_t, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@63">Patch Set #14, Line 63:</a> <code style="font-family:monospace,monospace">int of_write(ihandle_t, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'ihandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@63">Patch Set #14, Line 63:</a> <code style="font-family:monospace,monospace">int of_write(ihandle_t, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'void *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@63">Patch Set #14, Line 63:</a> <code style="font-family:monospace,monospace">int of_write(ihandle_t, void *, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@64">Patch Set #14, Line 64:</a> <code style="font-family:monospace,monospace">int of_seek(ihandle_t, int, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'ihandle_t' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@64">Patch Set #14, Line 64:</a> <code style="font-family:monospace,monospace">int of_seek(ihandle_t, int, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@64">Patch Set #14, Line 64:</a> <code style="font-family:monospace,monospace">int of_seek(ihandle_t, int, int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@66">Patch Set #14, Line 66:</a> <code style="font-family:monospace,monospace">void *of_claim(void *, unsigned int, unsigned int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'void *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@66">Patch Set #14, Line 66:</a> <code style="font-family:monospace,monospace">void *of_claim(void *, unsigned int, unsigned int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@66">Patch Set #14, Line 66:</a> <code style="font-family:monospace,monospace">void *of_claim(void *, unsigned int, unsigned int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@67">Patch Set #14, Line 67:</a> <code style="font-family:monospace,monospace">void of_release(void *, unsigned int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'void *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@67">Patch Set #14, Line 67:</a> <code style="font-family:monospace,monospace">void of_release(void *, unsigned int);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@70">Patch Set #14, Line 70:</a> <code style="font-family:monospace,monospace">void *of_set_callback(void *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'void *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@72">Patch Set #14, Line 72:</a> <code style="font-family:monospace,monospace">int vpd_read(unsigned int, unsigned int, char *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@72">Patch Set #14, Line 72:</a> <code style="font-family:monospace,monospace">int vpd_read(unsigned int, unsigned int, char *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@72">Patch Set #14, Line 72:</a> <code style="font-family:monospace,monospace">int vpd_read(unsigned int, unsigned int, char *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'char *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@73">Patch Set #14, Line 73:</a> <code style="font-family:monospace,monospace">int vpd_write(unsigned int, unsigned int, char *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@73">Patch Set #14, Line 73:</a> <code style="font-family:monospace,monospace">int vpd_write(unsigned int, unsigned int, char *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@73">Patch Set #14, Line 73:</a> <code style="font-family:monospace,monospace">int vpd_write(unsigned int, unsigned int, char *);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'char *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@74">Patch Set #14, Line 74:</a> <code style="font-family:monospace,monospace">int write_mm_log(char *, unsigned int, unsigned short);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'char *' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@74">Patch Set #14, Line 74:</a> <code style="font-family:monospace,monospace">int write_mm_log(char *, unsigned int, unsigned short);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned int' should also have an identifier name</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/device/oprom/yabel/compat/of.h@74">Patch Set #14, Line 74:</a> <code style="font-family:monospace,monospace">int write_mm_log(char *, unsigned int, unsigned short);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">function definition argument 'unsigned short' should also have an identifier name</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h">File src/northbridge/amd/amdmct/mct_ddr3/mct_d.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h@1058">Patch Set #14, Line 1058:</a> <code style="font-family:monospace,monospace">void read_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h@1059">Patch Set #14, Line 1059:</a> <code style="font-family:monospace,monospace">void read_dqs_write_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h@1136">Patch Set #14, Line 1136:</a> <code style="font-family:monospace,monospace">void write_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c">File src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c@320">Patch Set #14, Line 320:</a> <code style="font-family:monospace,monospace">static void read_dqs_write_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c@349">Patch Set #14, Line 349:</a> <code style="font-family:monospace,monospace">static void write_dqs_write_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c">File src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@258">Patch Set #14, Line 258:</a> <code style="font-family:monospace,monospace">void read_dqs_write_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@285">Patch Set #14, Line 285:</a> <code style="font-family:monospace,monospace">static void write_dqs_write_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@317">Patch Set #14, Line 317:</a> <code style="font-family:monospace,monospace">static void write_write_data_timing_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@356">Patch Set #14, Line 356:</a> <code style="font-family:monospace,monospace">void read_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@390">Patch Set #14, Line 390:</a> <code style="font-family:monospace,monospace">void write_dqs_receiver_enable_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@427">Patch Set #14, Line 427:</a> <code style="font-family:monospace,monospace">static void read_dram_phase_recovery_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@459">Patch Set #14, Line 459:</a> <code style="font-family:monospace,monospace">static void write_dram_phase_recovery_control_registers(uint16_t *current_total_delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@497">Patch Set #14, Line 497:</a> <code style="font-family:monospace,monospace">void read_dqs_read_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c@531">Patch Set #14, Line 531:</a> <code style="font-family:monospace,monospace">void write_dqs_read_data_timing_registers(uint16_t *delay, uint32_t dev, uint8_t dct, uint8_t dimm, uint32_t index_reg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c">File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@272">Patch Set #14, Line 272:</a> <code style="font-family:monospace,monospace">static void copy_cbmem_spd_data_to_save_variable(struct amd_s3_persistent_data *persistent_data, uint8_t *restored)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@306">Patch Set #14, Line 306:</a> <code style="font-family:monospace,monospace">void copy_mct_data_to_save_variable(struct amd_s3_persistent_data *persistent_data)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@329">Patch Set #14, Line 329:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@597">Patch Set #14, Line 597:</a> <code style="font-family:monospace,monospace">void restore_mct_data_from_save_variable(struct amd_s3_persistent_data *persistent_data, uint8_t training_only)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@611">Patch Set #14, Line 611:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@655">Patch Set #14, Line 655:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@666">Patch Set #14, Line 666:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@722">Patch Set #14, Line 722:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@761">Patch Set #14, Line 761:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@826">Patch Set #14, Line 826:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@871">Patch Set #14, Line 871:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@912">Patch Set #14, Line 912:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@929">Patch Set #14, Line 929:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@967">Patch Set #14, Line 967:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@986">Patch Set #14, Line 986:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1013">Patch Set #14, Line 1013:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1037">Patch Set #14, Line 1037:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1069">Patch Set #14, Line 1069:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@1084">Patch Set #14, Line 1084:</a> <code style="font-family:monospace,monospace"> struct amd_s3_persistent_mct_channel_data *data = &persistent_data->node[node].channel[channel];</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/southbridge/amd/sr5650/sr5650.c">File src/southbridge/amd/sr5650/sr5650.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/southbridge/amd/sr5650/sr5650.c@35">Patch Set #14, Line 35:</a> <code style="font-family:monospace,monospace">struct resource *sr5650_retrieve_cpu_mmio_resource() {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">open brace '{' following function declarations go on the next line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26942/14/src/southbridge/intel/i82870/ioapic.c">File src/southbridge/intel/i82870/ioapic.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/southbridge/intel/i82870/ioapic.c@47">Patch Set #14, Line 47:</a> <code style="font-family:monospace,monospace"> volatile uint32_t *pIndexRegister; /* io apic io memory space command address */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26942/14/src/southbridge/intel/i82870/ioapic.c@48">Patch Set #14, Line 48:</a> <code style="font-family:monospace,monospace"> volatile uint32_t *pWindowRegister; /* io apic io memory space data address */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26942">change 26942</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26942"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8e4118c5c5d70719ad7dc5f9ff9f86d93fa498ac </div>
<div style="display:none"> Gerrit-Change-Number: 26942 </div>
<div style="display:none"> Gerrit-PatchSet: 14 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 07 Jul 2018 06:55:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>