<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27344">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/ibase/mb899: Remove unneeded includes<br><br>Change-Id: Iee237206f309409be64307d2daee044da52a05e1<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>Reviewed-on: https://review.coreboot.org/27344<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/ibase/mb899/mainboard.c<br>M src/mainboard/ibase/mb899/romstage.c<br>2 files changed, 8 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/ibase/mb899/mainboard.c b/src/mainboard/ibase/mb899/mainboard.c</span><br><span>index 0629d33..d4d05c3 100644</span><br><span>--- a/src/mainboard/ibase/mb899/mainboard.c</span><br><span>+++ b/src/mainboard/ibase/mb899/mainboard.c</span><br><span>@@ -13,17 +13,10 @@</span><br><span>  * GNU General Public License for more details.</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <types.h></span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/interrupt.h></span><br><span> #include "superio_hwm.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> // mainboard_enable is executed as first thing after</span><br><span> // enumerate_buses().</span><br><span> </span><br><span>diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c</span><br><span>index dd384ac..78ec5ed 100644</span><br><span>--- a/src/mainboard/ibase/mb899/romstage.c</span><br><span>+++ b/src/mainboard/ibase/mb899/romstage.c</span><br><span>@@ -16,25 +16,20 @@</span><br><span> // __PRE_RAM__ means: use "unsigned" for device, not a struct.</span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <halt.h></span><br><span> #include <arch/io.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <timestamp.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <console/console.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cpu/intel/romstage.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cpu/x86/bist.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <cpu/x86/lapic.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pnp_def.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/lapic.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <timestamp.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <superio/winbond/common/winbond.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <superio/winbond/w83627ehg/w83627ehg.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/bist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/intel/romstage.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <halt.h></span><br><span> #include <northbridge/intel/i945/i945.h></span><br><span> #include <northbridge/intel/i945/raminit.h></span><br><span> #include <southbridge/intel/i82801gx/i82801gx.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <superio/winbond/common/winbond.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <superio/winbond/w83627ehg/w83627ehg.h></span><br><span> </span><br><span> #define SERIAL_DEV PNP_DEV(0x4e, W83627EHG_SP1)</span><br><span> #define SUPERIO_DEV PNP_DEV(0x4e, 0)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27344">change 27344</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27344"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iee237206f309409be64307d2daee044da52a05e1 </div>
<div style="display:none"> Gerrit-Change-Number: 27344 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>