<p>Felix Held has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27391">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/via: remove LDN-specific ops overrides<br><br>The pnp ops struct is already passed to the pnp_enable_devices function and it<br>is used if no override is supplied in the elements of the pnp_info struct array<br><br>Change-Id: I14dbeda9832a25116cf53c36197615e9d02d5134<br>Signed-off-by: Felix Held <felix-coreboot@felixheld.de><br>---<br>M src/superio/via/vt1211/superio.c<br>1 file changed, 12 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/27391/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/superio/via/vt1211/superio.c b/src/superio/via/vt1211/superio.c</span><br><span>index 28586ba..3468b63 100644</span><br><span>--- a/src/superio/via/vt1211/superio.c</span><br><span>+++ b/src/superio/via/vt1211/superio.c</span><br><span>@@ -167,18 +167,18 @@</span><br><span> </span><br><span> /* TODO: Check if 0x07f8 is correct for FDC/PP/SP1/SP2, the rest is correct. */</span><br><span> static struct pnp_info pnp_dev_info[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-        { &ops, VT1211_FDC,  PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, },</span><br><span style="color: hsl(0, 100%, 40%);">-      { &ops, VT1211_PP,   PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, },</span><br><span style="color: hsl(0, 100%, 40%);">-      { &ops, VT1211_SP1,  PNP_IO0 | PNP_IRQ0, 0x07f8, },</span><br><span style="color: hsl(0, 100%, 40%);">- { &ops, VT1211_SP2,  PNP_IO0 | PNP_IRQ0, 0x07f8, },</span><br><span style="color: hsl(0, 100%, 40%);">- { &ops, VT1211_MIDI, PNP_IO0 | PNP_IRQ0, 0xfffc, },</span><br><span style="color: hsl(0, 100%, 40%);">- { &ops, VT1211_GAME, PNP_IO0, 0xfff8, },</span><br><span style="color: hsl(0, 100%, 40%);">-    { &ops, VT1211_GPIO, PNP_IO0 | PNP_IRQ0, 0xfff0, },</span><br><span style="color: hsl(0, 100%, 40%);">- { &ops, VT1211_WDG,  PNP_IO0 | PNP_IRQ0, 0xfff0, },</span><br><span style="color: hsl(0, 100%, 40%);">- { &ops, VT1211_WUC,  PNP_IO0 | PNP_IRQ0, 0xfff0, },</span><br><span style="color: hsl(0, 100%, 40%);">- { &ops, VT1211_HWM,  PNP_IO0 | PNP_IRQ0, 0xff00, },</span><br><span style="color: hsl(0, 100%, 40%);">- { &ops, VT1211_FIR,  PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0xff00, },</span><br><span style="color: hsl(0, 100%, 40%);">-      { &ops, VT1211_ROM, },</span><br><span style="color: hsl(120, 100%, 40%);">+    { NULL, VT1211_FDC,  PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, },</span><br><span style="color: hsl(120, 100%, 40%);">+        { NULL, VT1211_PP,   PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, },</span><br><span style="color: hsl(120, 100%, 40%);">+        { NULL, VT1211_SP1,  PNP_IO0 | PNP_IRQ0, 0x07f8, },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NULL, VT1211_SP2,  PNP_IO0 | PNP_IRQ0, 0x07f8, },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NULL, VT1211_MIDI, PNP_IO0 | PNP_IRQ0, 0xfffc, },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NULL, VT1211_GAME, PNP_IO0, 0xfff8, },</span><br><span style="color: hsl(120, 100%, 40%);">+      { NULL, VT1211_GPIO, PNP_IO0 | PNP_IRQ0, 0xfff0, },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NULL, VT1211_WDG,  PNP_IO0 | PNP_IRQ0, 0xfff0, },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NULL, VT1211_WUC,  PNP_IO0 | PNP_IRQ0, 0xfff0, },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NULL, VT1211_HWM,  PNP_IO0 | PNP_IRQ0, 0xff00, },</span><br><span style="color: hsl(120, 100%, 40%);">+   { NULL, VT1211_FIR,  PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0xff00, },</span><br><span style="color: hsl(120, 100%, 40%);">+        { NULL, VT1211_ROM, },</span><br><span> };</span><br><span> </span><br><span> static void enable_dev(struct device *dev)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27391">change 27391</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27391"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I14dbeda9832a25116cf53c36197615e9d02d5134 </div>
<div style="display:none"> Gerrit-Change-Number: 27391 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> </div>