<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27364">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/{asus,getac,gigabyte,kontron}: Remoce unneeded includes<br><br>Change-Id: I301affabb4199a7177fc0cb7698d7540a756037f<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/asus/p5gc-mx/romstage.c<br>M src/mainboard/getac/p470/romstage.c<br>M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c<br>M src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c<br>M src/mainboard/kontron/986lcd-m/mainboard.c<br>M src/mainboard/kontron/986lcd-m/romstage.c<br>M src/mainboard/kontron/ktqm77/mainboard.c<br>M src/mainboard/kontron/ktqm77/romstage.c<br>8 files changed, 0 insertions(+), 44 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/27364/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/asus/p5gc-mx/romstage.c b/src/mainboard/asus/p5gc-mx/romstage.c</span><br><span>index e1725d0..7d84f29 100644</span><br><span>--- a/src/mainboard/asus/p5gc-mx/romstage.c</span><br><span>+++ b/src/mainboard/asus/p5gc-mx/romstage.c</span><br><span>@@ -18,18 +18,13 @@</span><br><span> // __PRE_RAM__ means: use "unsigned" for device, not a struct.</span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span> #include <arch/io.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pnp_def.h></span><br><span> #include <cpu/x86/lapic.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <timestamp.h></span><br><span> #include <superio/winbond/common/winbond.h></span><br><span> #include <superio/winbond/w83627dhg/w83627dhg.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span> #include <console/console.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <cpu/intel/romstage.h></span><br><span>diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c</span><br><span>index e58ef1b..289768b 100644</span><br><span>--- a/src/mainboard/getac/p470/romstage.c</span><br><span>+++ b/src/mainboard/getac/p470/romstage.c</span><br><span>@@ -15,15 +15,10 @@</span><br><span>  */</span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span> #include <arch/io.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pnp_def.h></span><br><span> #include <cpu/x86/lapic.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span> #include <console/console.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <cpu/intel/romstage.h></span><br><span>diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c</span><br><span>index 926a5a7..5a6b5fb 100644</span><br><span>--- a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c</span><br><span>+++ b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c</span><br><span>@@ -17,18 +17,13 @@</span><br><span> // __PRE_RAM__ means: use "unsigned" for device, not a struct.</span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span> #include <arch/io.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pnp_def.h></span><br><span> #include <cpu/x86/lapic.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <timestamp.h></span><br><span> #include <superio/ite/it8718f/it8718f.h></span><br><span> #include <superio/ite/common/ite.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span> #include <console/console.h></span><br><span> #include <cpu/x86/bist.h></span><br><span> #include <cpu/intel/romstage.h></span><br><span>diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c b/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c</span><br><span>index 90131ff..3156a23 100644</span><br><span>--- a/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c</span><br><span>+++ b/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c</span><br><span>@@ -16,21 +16,9 @@</span><br><span>  */</span><br><span> </span><br><span> #include <types.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span> #include <device/device.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_def.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci_ops.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/io.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/interrupt.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <boot/coreboot_tables.h></span><br><span> #include <southbridge/intel/bd82x6x/pch.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <smbios.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <device/pci.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbfs.h></span><br><span> </span><br><span> static void mainboard_init(struct device *dev)</span><br><span> {</span><br><span>diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c</span><br><span>index cc32b99..f341b4e 100644</span><br><span>--- a/src/mainboard/kontron/986lcd-m/mainboard.c</span><br><span>+++ b/src/mainboard/kontron/986lcd-m/mainboard.c</span><br><span>@@ -17,7 +17,6 @@</span><br><span> #include <device/device.h></span><br><span> #include <console/console.h></span><br><span> #include <drivers/intel/gma/int15.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span> #include <arch/io.h></span><br><span> #include <arch/interrupt.h></span><br><span> </span><br><span>diff --git a/src/mainboard/kontron/986lcd-m/romstage.c b/src/mainboard/kontron/986lcd-m/romstage.c</span><br><span>index f7e8131..f5af574 100644</span><br><span>--- a/src/mainboard/kontron/986lcd-m/romstage.c</span><br><span>+++ b/src/mainboard/kontron/986lcd-m/romstage.c</span><br><span>@@ -16,16 +16,11 @@</span><br><span> /* __PRE_RAM__ means: use "unsigned" for device, not a struct. */</span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <lib.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span> #include <timestamp.h></span><br><span> #include <arch/io.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pnp_def.h></span><br><span> #include <cpu/x86/lapic.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span> #include "option_table.h"</span><br><span> #include <console/console.h></span><br><span> #include <cpu/x86/bist.h></span><br><span>diff --git a/src/mainboard/kontron/ktqm77/mainboard.c b/src/mainboard/kontron/ktqm77/mainboard.c</span><br><span>index 3a37290..f25fb89 100644</span><br><span>--- a/src/mainboard/kontron/ktqm77/mainboard.c</span><br><span>+++ b/src/mainboard/kontron/ktqm77/mainboard.c</span><br><span>@@ -16,7 +16,6 @@</span><br><span>  */</span><br><span> </span><br><span> #include <types.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pci_ops.h></span><br><span>@@ -24,8 +23,6 @@</span><br><span> #if IS_ENABLED(CONFIG_VGA_ROM_RUN)</span><br><span> #include <x86emu/x86emu.h></span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span> #include <arch/io.h></span><br><span> #include <arch/interrupt.h></span><br><span> #include <boot/coreboot_tables.h></span><br><span>diff --git a/src/mainboard/kontron/ktqm77/romstage.c b/src/mainboard/kontron/ktqm77/romstage.c</span><br><span>index 2a674a5..894f161 100644</span><br><span>--- a/src/mainboard/kontron/ktqm77/romstage.c</span><br><span>+++ b/src/mainboard/kontron/ktqm77/romstage.c</span><br><span>@@ -15,24 +15,16 @@</span><br><span>  */</span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <string.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <lib.h></span><br><span> #include <timestamp.h></span><br><span> #include <arch/io.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/pnp_def.h></span><br><span> #include <cpu/x86/lapic.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/mc146818rtc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/acpi.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cbmem.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <console/console.h></span><br><span> #include <northbridge/intel/sandybridge/sandybridge.h></span><br><span> #include <northbridge/intel/sandybridge/raminit.h></span><br><span> #include <northbridge/intel/sandybridge/raminit_native.h></span><br><span> #include <southbridge/intel/bd82x6x/pch.h></span><br><span> #include <southbridge/intel/common/gpio.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <arch/cpu.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span> #include <halt.h></span><br><span> </span><br><span> void pch_enable_lpc(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27364">change 27364</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27364"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I301affabb4199a7177fc0cb7698d7540a756037f </div>
<div style="display:none"> Gerrit-Change-Number: 27364 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>