<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27368">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: [WIP] Library for working with RW_UCODE_UPDATE NV region<br><br>Change-Id: I40e8d315618962b50d6fed97fa094b941246c934<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com><br>---<br>M src/soc/intel/skylake/Makefile.inc<br>A src/soc/intel/skylake/fw_update_nv.c<br>A src/soc/intel/skylake/include/soc/fw_update_nv.h<br>3 files changed, 92 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27368/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc</span><br><span>index 89e48f1..fe687ce 100644</span><br><span>--- a/src/soc/intel/skylake/Makefile.inc</span><br><span>+++ b/src/soc/intel/skylake/Makefile.inc</span><br><span>@@ -28,6 +28,7 @@</span><br><span> verstage-y += spi.c</span><br><span> verstage-$(CONFIG_UART_DEBUG) += uart.c</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+romstage-y += fw_update_nv.c</span><br><span> romstage-y += gpio.c</span><br><span> romstage-y += gspi.c</span><br><span> romstage-y += i2c.c</span><br><span>diff --git a/src/soc/intel/skylake/fw_update_nv.c b/src/soc/intel/skylake/fw_update_nv.c</span><br><span>new file mode 100644</span><br><span>index 0000000..fced985</span><br><span>--- /dev/null</span><br><span>+++ b/src/soc/intel/skylake/fw_update_nv.c</span><br><span>@@ -0,0 +1,63 @@</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2014 The ChromiumOS Authors. All rights reserved.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <assert.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <commonlib/region.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <console/console.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <fmap.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <ip_checksum.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <soc/fw_update_nv.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int get_update_nv_storage(struct region_device *rdev)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fmap_locate_area_as_rdev_rw("RW_UPDATE_STATE", rdev)){</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_ERR, "%s: failed to locate UPDATE NVRAM\n", __func__);</span><br><span style="color: hsl(120, 100%, 40%);">+ return 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int get_update_state(struct region_device *rdev,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct fw_update_nv *update_state) {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* read the nvdata and write it to the cache */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rdev_readat(rdev, (void *) update_state, INIT_OFFSET,</span><br><span style="color: hsl(120, 100%, 40%);">+ FW_UPDATE_NV_DATA_SIZE) < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_ERR, "failed to read nvdata\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ printk (BIOS_ERR, "ucode: 0x%x\ncse: 0x%x\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ update_state->ucode_state,</span><br><span style="color: hsl(120, 100%, 40%);">+ update_state->cse_state);</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int set_update_state(struct region_device *rdev,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct fw_update_nv *update_state) {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ update_state->checksum = compute_ip_checksum(</span><br><span style="color: hsl(120, 100%, 40%);">+ (void *)update_state,</span><br><span style="color: hsl(120, 100%, 40%);">+ FW_UPDATE_NV_DATA_SIZE);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rdev_writeat(rdev, update_state, 0, FW_UPDATE_NV_DATA_SIZE) !=</span><br><span style="color: hsl(120, 100%, 40%);">+ FW_UPDATE_NV_DATA_SIZE) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printk(BIOS_ERR, "failed to Write nvdata\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>diff --git a/src/soc/intel/skylake/include/soc/fw_update_nv.h b/src/soc/intel/skylake/include/soc/fw_update_nv.h</span><br><span>new file mode 100644</span><br><span>index 0000000..b120aa5</span><br><span>--- /dev/null</span><br><span>+++ b/src/soc/intel/skylake/include/soc/fw_update_nv.h</span><br><span>@@ -0,0 +1,28 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#define FW_UPDATE_NV_DATA_SIZE 16</span><br><span style="color: hsl(120, 100%, 40%);">+#define ERASE_VALUE 0xff</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum update_state {</span><br><span style="color: hsl(120, 100%, 40%);">+ UPDATE_VERIFIED,</span><br><span style="color: hsl(120, 100%, 40%);">+ UPDATE_START,</span><br><span style="color: hsl(120, 100%, 40%);">+ UPDATE_WRITE_COMPLETE</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum update_nv_offsets {</span><br><span style="color: hsl(120, 100%, 40%);">+ INIT_OFFSET,</span><br><span style="color: hsl(120, 100%, 40%);">+ UCODE_UPDATE_NV_OFFSET=1,</span><br><span style="color: hsl(120, 100%, 40%);">+ CSE_UPDATE_NV_OFFSET=2,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct fw_update_nv {</span><br><span style="color: hsl(120, 100%, 40%);">+ char initialized;</span><br><span style="color: hsl(120, 100%, 40%);">+ enum update_state ucode_state;</span><br><span style="color: hsl(120, 100%, 40%);">+ enum update_state cse_state;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t checksum;</span><br><span style="color: hsl(120, 100%, 40%);">+ char unused[5];</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int get_update_nv_storage(struct region_device *rdev);</span><br><span style="color: hsl(120, 100%, 40%);">+int get_update_state(struct region_device *rdev,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct fw_update_nv *update_state);</span><br><span style="color: hsl(120, 100%, 40%);">+int set_update_state(struct region_device *rdev,</span><br><span style="color: hsl(120, 100%, 40%);">+ struct fw_update_nv *update_state);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27368">change 27368</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27368"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I40e8d315618962b50d6fed97fa094b941246c934 </div>
<div style="display:none"> Gerrit-Change-Number: 27368 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>