<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27290">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">payloads/libpayload/drivers/i8042: Disable scanning on disconnect<br><br>This change ensures that keyboard scanning is disabled and keyboard is<br>set to default state while disconnecting the keyboard. This is<br>required to ensure that the controller doesn't keep scanning and<br>buffering keystrokes which could lead to OS drivers reading stale<br>data.<br><br>BUG=b:110024487<br>TEST=Verified that kernel driver is able to probe correctly even if<br>multiple keys are pressed during handoff from payload to OS.<br><br>Change-Id: I1ffb8904d545284454c1825ee2e7c0087fc13762<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M payloads/libpayload/drivers/i8042/keyboard.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/27290/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c</span><br><span>index d5606a3..062aec2 100644</span><br><span>--- a/payloads/libpayload/drivers/i8042/keyboard.c</span><br><span>+++ b/payloads/libpayload/drivers/i8042/keyboard.c</span><br><span>@@ -338,6 +338,9 @@</span><br><span>  while (keyboard_havechar())</span><br><span>          keyboard_getchar();</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+       /* Disable scanning */</span><br><span style="color: hsl(120, 100%, 40%);">+        keyboard_cmd(I8042_KBCMD_DEFAULT_DIS);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     /* Send keyboard disconnect command */</span><br><span>       i8042_cmd(I8042_CMD_DIS_KB);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27290">change 27290</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27290"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1ffb8904d545284454c1825ee2e7c0087fc13762 </div>
<div style="display:none"> Gerrit-Change-Number: 27290 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>