<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27291">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/*: Remove selection of DRIVERS_PS2_KEYBOARD<br><br>Until now, chromeec was doing keyboard initialization for the boards<br>that have DRIVERS_PS2_KEYBOARD selected. However, coreboot does not<br>leave the keyboard controller is a default reset state. This could<br>result in payloads or OS failing to probe the controller as there<br>could be stale data buffered in the controller during the handoff.<br><br>Since the boards using chromeec already perform keyboard<br>initialization in payload, there is no need to initialize the keyboard<br>in coreboot too. This change gets rid of DRIVERS_PS2_KEYBOARD<br>selection from all google mainboards using chromeec.<br><br>BUG=b:110024487<br>TEST=Keyboard works fine after booting to OS even if user hits keys<br>during BIOS to OS handoff.<br><br>Change-Id: I1f49b060eb005c0f2b86f9d68d6758954eeb3cf0<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/eve/Kconfig<br>M src/mainboard/google/kahlee/Kconfig<br>M src/mainboard/google/octopus/Kconfig<br>M src/mainboard/google/poppy/Kconfig<br>M src/mainboard/google/reef/Kconfig<br>5 files changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/27291/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig</span><br><span>index a841f22..7c98339 100644</span><br><span>--- a/src/mainboard/google/eve/Kconfig</span><br><span>+++ b/src/mainboard/google/eve/Kconfig</span><br><span>@@ -5,7 +5,6 @@</span><br><span> select BOARD_ROMSIZE_KB_16384</span><br><span> select DRIVERS_I2C_GENERIC</span><br><span> select DRIVERS_I2C_HID</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_PS2_KEYBOARD</span><br><span> select DRIVERS_I2C_MAX98927</span><br><span> select DRIVERS_I2C_RT5663</span><br><span> select DRIVERS_SPI_ACPI</span><br><span>diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig</span><br><span>index fd43ed6..ef7db04 100644</span><br><span>--- a/src/mainboard/google/kahlee/Kconfig</span><br><span>+++ b/src/mainboard/google/kahlee/Kconfig</span><br><span>@@ -20,7 +20,6 @@</span><br><span> select ALWAYS_RUN_OPROM</span><br><span> select BOARD_ROMSIZE_KB_16384</span><br><span> select DRIVERS_I2C_GENERIC</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_PS2_KEYBOARD</span><br><span> select EC_GOOGLE_CHROMEEC</span><br><span> select EC_GOOGLE_CHROMEEC_BOARDID</span><br><span> select EC_GOOGLE_CHROMEEC_LPC</span><br><span>diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig</span><br><span>index 4b2a8f8..34ca725 100644</span><br><span>--- a/src/mainboard/google/octopus/Kconfig</span><br><span>+++ b/src/mainboard/google/octopus/Kconfig</span><br><span>@@ -7,7 +7,6 @@</span><br><span> select DRIVERS_I2C_DA7219</span><br><span> select DRIVERS_I2C_GENERIC</span><br><span> select DRIVERS_I2C_HID</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_PS2_KEYBOARD</span><br><span> select DRIVERS_SPI_ACPI</span><br><span> select EC_GOOGLE_CHROMEEC</span><br><span> select EC_GOOGLE_CHROMEEC_BOARDID</span><br><span>diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig</span><br><span>index c9a1812..d5f560d 100644</span><br><span>--- a/src/mainboard/google/poppy/Kconfig</span><br><span>+++ b/src/mainboard/google/poppy/Kconfig</span><br><span>@@ -138,7 +138,6 @@</span><br><span> select CHROMEOS_WIFI_SAR if CHROMEOS</span><br><span> select DRIVERS_I2C_MAX98373</span><br><span> select DRIVERS_I2C_DA7219</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_PS2_KEYBOARD</span><br><span> select DRIVERS_SPI_ACPI</span><br><span> select EXCLUDE_NATIVE_SD_INTERFACE</span><br><span> select MAINBOARD_HAS_SPI_TPM_CR50</span><br><span>@@ -155,7 +154,6 @@</span><br><span> select CHROMEOS_WIFI_SAR if CHROMEOS</span><br><span> select DRIVERS_GENERIC_MAX98357A</span><br><span> select DRIVERS_I2C_DA7219</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_PS2_KEYBOARD</span><br><span> select DRIVERS_SPI_ACPI</span><br><span> select EXCLUDE_NATIVE_SD_INTERFACE</span><br><span> select MAINBOARD_HAS_SPI_TPM_CR50</span><br><span>@@ -165,7 +163,6 @@</span><br><span> select CHROMEOS_WIFI_SAR if CHROMEOS</span><br><span> select DRIVERS_GENERIC_MAX98357A</span><br><span> select DRIVERS_I2C_DA7219</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_PS2_KEYBOARD</span><br><span> select VARIANT_HAS_CAMERA_ACPI</span><br><span> select MAINBOARD_HAS_I2C_TPM_CR50</span><br><span> </span><br><span>diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig</span><br><span>index 9214421..09b2e61 100644</span><br><span>--- a/src/mainboard/google/reef/Kconfig</span><br><span>+++ b/src/mainboard/google/reef/Kconfig</span><br><span>@@ -7,7 +7,6 @@</span><br><span> select DRIVERS_I2C_DA7219</span><br><span> select DRIVERS_I2C_GENERIC</span><br><span> select DRIVERS_I2C_HID</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_PS2_KEYBOARD</span><br><span> select EC_GOOGLE_CHROMEEC</span><br><span> select EC_GOOGLE_CHROMEEC_BOARDID</span><br><span> select EC_GOOGLE_CHROMEEC_LPC</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27291">change 27291</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27291"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1f49b060eb005c0f2b86f9d68d6758954eeb3cf0 </div>
<div style="display:none"> Gerrit-Change-Number: 27291 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>