<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27293">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/chromeec: Remove keyboard initialization<br><br>Since none of the boards using chromeec select DRIVERS_PS2_KEYBOARD<br>now, there is no need to call pc_keyboard_init anymore. This change<br>gets rid of the call and adds an error message in case any mainboard<br>using chromeec tries to select this config.<br><br>BUG=b:110024487<br><br>Change-Id: Ia0b56abe0a5990e527277eaf3397e00dccda3e50<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/ec/google/chromeec/ec_lpc.c<br>1 file changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/27293/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c</span><br><span>index 3078c22..b964e3a 100644</span><br><span>--- a/src/ec/google/chromeec/ec_lpc.c</span><br><span>+++ b/src/ec/google/chromeec/ec_lpc.c</span><br><span>@@ -18,7 +18,6 @@</span><br><span> #include <console/console.h></span><br><span> #include <delay.h></span><br><span> #include <device/pnp.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <pc80/keyboard.h></span><br><span> #include <stdint.h></span><br><span> #include <stdlib.h></span><br><span> </span><br><span>@@ -27,6 +26,16 @@</span><br><span> #include "ec_commands.h"</span><br><span> </span><br><span> /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Chrome EC driver does not perform keyboard initialization. It relies on the</span><br><span style="color: hsl(120, 100%, 40%);">+ * payload to do this work. If a mainboard using Chrome EC requires</span><br><span style="color: hsl(120, 100%, 40%);">+ * CONFIG_DRIVERS_PS2_KEYBOARD then call to pc_keyboard_init needs to be added</span><br><span style="color: hsl(120, 100%, 40%);">+ * as well.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_DRIVERS_PS2_KEYBOARD)</span><br><span style="color: hsl(120, 100%, 40%);">+#error "CONFIG_DRIVERS_PS2_KEYBOARD is not supported by Chrome EC"</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span>  * Read bytes from a given LPC-mapped address.</span><br><span>  *</span><br><span>  * @port: Base read address</span><br><span>@@ -430,7 +439,6 @@</span><br><span>      if (!dev->enabled)</span><br><span>                return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     pc_keyboard_init(NO_AUX_DEVICE);</span><br><span>     google_chromeec_init();</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27293">change 27293</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27293"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia0b56abe0a5990e527277eaf3397e00dccda3e50 </div>
<div style="display:none"> Gerrit-Change-Number: 27293 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>