<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27272">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/x86-boards: Get rid of power button device in coreboot<br><br>As per the ACPI specification, there are two types of power button<br>devices:<br>1. Fixed hardware power button<br>2. Generic hardware power button<br><br>Fixed hardware power button is added by the OSPM if POWER_BUTTON flag<br>is not set in FADT by the BIOS. This device has its programming model<br>in PM1x_EVT_BLK. All ACPI compliant OSes are expected to add this<br>power button device by default if the power button FADT flag is not<br>set.<br><br>On the other hand, generic hardware power button can be used by<br>platforms if fixed register space cannot be used for the power button<br>device. In order to support this, power button device object with HID<br>PNP0C0C is expected to be added to ACPI tables. Additionally,<br>POWER_BUTTON flag should be set to indicate the presence of control<br>method for power button.<br><br>Chrome EC mainboards implemented the generic hardware power button in<br>a broken manner i.e. power button object with HID PNP0C0C is added to<br>ACPI however none of the boards set POWER_BUTTON flag in FADT. This<br>results in Linux kernel adding both fixed hardware power button as<br>well as generic hardware power button to the list of devices present<br>on the system. Though this is mostly harmless, it is logically<br>incorrect and can confuse any userspace utilities scanning the ACPI<br>devices.<br><br>This change gets rid of the generic hardware power button from all<br>google mainboards and relies completely on the fixed hardware power<br>button.<br><br>BUG=b:110913245<br>TEST=Verified that fixed hardware power button still works correctly<br>on nautilus.<br><br>Change-Id: I733e69affc82ed77aa79c5eca6654aaa531476ca<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/auron/acpi/mainboard.asl<br>M src/mainboard/google/beltino/acpi/mainboard.asl<br>M src/mainboard/google/butterfly/acpi/mainboard.asl<br>M src/mainboard/google/chell/acpi/mainboard.asl<br>M src/mainboard/google/cyan/acpi/mainboard.asl<br>M src/mainboard/google/eve/dsdt.asl<br>M src/mainboard/google/fizz/dsdt.asl<br>D src/mainboard/google/glados/acpi/mainboard.asl<br>M src/mainboard/google/glados/dsdt.asl<br>M src/mainboard/google/jecht/acpi/mainboard.asl<br>M src/mainboard/google/kahlee/dsdt.asl<br>M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/gpe.asl<br>D src/mainboard/google/lars/acpi/mainboard.asl<br>M src/mainboard/google/lars/dsdt.asl<br>M src/mainboard/google/link/acpi/mainboard.asl<br>M src/mainboard/google/parrot/acpi/mainboard.asl<br>M src/mainboard/google/poppy/dsdt.asl<br>M src/mainboard/google/rambi/acpi/mainboard.asl<br>M src/mainboard/google/slippy/acpi/mainboard.asl<br>M src/mainboard/google/stout/acpi/mainboard.asl<br>M src/mainboard/google/zoombini/dsdt.asl<br>21 files changed, 0 insertions(+), 153 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/27272/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/auron/acpi/mainboard.asl b/src/mainboard/google/auron/acpi/mainboard.asl</span><br><span>index 2584015..907590d 100644</span><br><span>--- a/src/mainboard/google/auron/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/auron/acpi/mainboard.asl</span><br><span>@@ -16,14 +16,6 @@</span><br><span> </span><br><span> #include <variant/onboard.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Scope (\_SB.PCI0.RP01)</span><br><span> {</span><br><span> Device (WLAN)</span><br><span>diff --git a/src/mainboard/google/beltino/acpi/mainboard.asl b/src/mainboard/google/beltino/acpi/mainboard.asl</span><br><span>index e6f931e..692d635 100644</span><br><span>--- a/src/mainboard/google/beltino/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/beltino/acpi/mainboard.asl</span><br><span>@@ -16,14 +16,6 @@</span><br><span> </span><br><span> #include <onboard.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*</span><br><span> * LAN connected to Root Port 3, becomes Root Port 1 after coalesce</span><br><span> */</span><br><span>diff --git a/src/mainboard/google/butterfly/acpi/mainboard.asl b/src/mainboard/google/butterfly/acpi/mainboard.asl</span><br><span>index 8ecc128..4721f2a 100644</span><br><span>--- a/src/mainboard/google/butterfly/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/butterfly/acpi/mainboard.asl</span><br><span>@@ -27,11 +27,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Device (TPAD)</span><br><span> {</span><br><span> Name (_ADR, 0x0)</span><br><span>diff --git a/src/mainboard/google/chell/acpi/mainboard.asl b/src/mainboard/google/chell/acpi/mainboard.asl</span><br><span>index 5d382c4..7113617 100644</span><br><span>--- a/src/mainboard/google/chell/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/chell/acpi/mainboard.asl</span><br><span>@@ -15,13 +15,5 @@</span><br><span> </span><br><span> #include "../gpio.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* USB port entries */</span><br><span> #include "usb.asl"</span><br><span>diff --git a/src/mainboard/google/cyan/acpi/mainboard.asl b/src/mainboard/google/cyan/acpi/mainboard.asl</span><br><span>index 1859fa8..9f27ac9 100644</span><br><span>--- a/src/mainboard/google/cyan/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/cyan/acpi/mainboard.asl</span><br><span>@@ -17,15 +17,6 @@</span><br><span> </span><br><span> #include <variant/onboard.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_UID, 1)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Scope (\_SB.GPNC)</span><br><span> {</span><br><span> Method (_AEI, 0, Serialized) // _AEI: ACPI Event Interrupts</span><br><span>diff --git a/src/mainboard/google/eve/dsdt.asl b/src/mainboard/google/eve/dsdt.asl</span><br><span>index 2882d50..9382e35 100644</span><br><span>--- a/src/mainboard/google/eve/dsdt.asl</span><br><span>+++ b/src/mainboard/google/eve/dsdt.asl</span><br><span>@@ -36,10 +36,6 @@</span><br><span> </span><br><span> Scope (\_SB)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> Device (PCI0)</span><br><span> {</span><br><span> #include <soc/intel/skylake/acpi/systemagent.asl></span><br><span>diff --git a/src/mainboard/google/fizz/dsdt.asl b/src/mainboard/google/fizz/dsdt.asl</span><br><span>index 69d9158..dc2fcfa 100644</span><br><span>--- a/src/mainboard/google/fizz/dsdt.asl</span><br><span>+++ b/src/mainboard/google/fizz/dsdt.asl</span><br><span>@@ -36,10 +36,6 @@</span><br><span> </span><br><span> Scope (\_SB)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> Device (PCI0)</span><br><span> {</span><br><span> #include <soc/intel/skylake/acpi/systemagent.asl></span><br><span>diff --git a/src/mainboard/google/glados/acpi/mainboard.asl b/src/mainboard/google/glados/acpi/mainboard.asl</span><br><span>deleted file mode 100644</span><br><span>index 4d0f3fd..0000000</span><br><span>--- a/src/mainboard/google/glados/acpi/mainboard.asl</span><br><span>+++ /dev/null</span><br><span>@@ -1,24 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2015 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include "../gpio.h"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/google/glados/dsdt.asl b/src/mainboard/google/glados/dsdt.asl</span><br><span>index b5a37c6..21e9587 100644</span><br><span>--- a/src/mainboard/google/glados/dsdt.asl</span><br><span>+++ b/src/mainboard/google/glados/dsdt.asl</span><br><span>@@ -49,7 +49,4 @@</span><br><span> </span><br><span> // Chipset specific sleep states</span><br><span> #include <soc/intel/skylake/acpi/sleepstates.asl></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- // Mainboard specific</span><br><span style="color: hsl(0, 100%, 40%);">- #include "acpi/mainboard.asl"</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/jecht/acpi/mainboard.asl b/src/mainboard/google/jecht/acpi/mainboard.asl</span><br><span>index 4b2d9ca..bf6070e 100644</span><br><span>--- a/src/mainboard/google/jecht/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/jecht/acpi/mainboard.asl</span><br><span>@@ -16,14 +16,6 @@</span><br><span> </span><br><span> #include <mainboard/google/jecht/onboard.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*</span><br><span> * LAN connected to Root Port 3, becomes Root Port 1 after coalesce</span><br><span> */</span><br><span>diff --git a/src/mainboard/google/kahlee/dsdt.asl b/src/mainboard/google/kahlee/dsdt.asl</span><br><span>index e5276d3..14f0d40 100644</span><br><span>--- a/src/mainboard/google/kahlee/dsdt.asl</span><br><span>+++ b/src/mainboard/google/kahlee/dsdt.asl</span><br><span>@@ -56,11 +56,6 @@</span><br><span> /* IRQ Routing mapping for this platform (in \_SB scope) */</span><br><span> #include <variant/acpi/routing.asl></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Device(PWRB) {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EISAID("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_UID, 0xAA)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Describe the SOC */</span><br><span> #include <soc.asl></span><br><span> </span><br><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/gpe.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/gpe.asl</span><br><span>index 9dbbde5..dc7c804 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/gpe.asl</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/gpe.asl</span><br><span>@@ -19,7 +19,6 @@</span><br><span> Method (_L08)</span><br><span> {</span><br><span> /* DBGO ("\\_GPE\\_L08\n") */</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */</span><br><span> }</span><br><span> </span><br><span> /* EHCI USB controller PME# SCIMAP24*/</span><br><span>@@ -27,7 +26,6 @@</span><br><span> {</span><br><span> /* DBGO ("\\_GPE\\_L18\n") */</span><br><span> Notify (\_SB.PCI0.EHC0, 0x02) /* NOTIFY_DEVICE_WAKE */</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */</span><br><span> }</span><br><span> </span><br><span> /* XHCI USB controller PME# SCIMAP56*/</span><br><span>@@ -35,6 +33,5 @@</span><br><span> {</span><br><span> /* DBGO ("\\_GPE\\_L1F\n") */</span><br><span> Notify (\_SB.PCI0.XHC0, 0x02) /* NOTIFY_DEVICE_WAKE */</span><br><span style="color: hsl(0, 100%, 40%);">- Notify (\_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */</span><br><span> }</span><br><span> } /* End Scope GPE */</span><br><span>diff --git a/src/mainboard/google/lars/acpi/mainboard.asl b/src/mainboard/google/lars/acpi/mainboard.asl</span><br><span>deleted file mode 100644</span><br><span>index 861d39f..0000000</span><br><span>--- a/src/mainboard/google/lars/acpi/mainboard.asl</span><br><span>+++ /dev/null</span><br><span>@@ -1,25 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-/*</span><br><span style="color: hsl(0, 100%, 40%);">- * This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2014 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright (C) 2015 Intel Corporation.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">- * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">- * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span style="color: hsl(0, 100%, 40%);">- * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">- * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">- * GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include "../gpio.h"</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span>diff --git a/src/mainboard/google/lars/dsdt.asl b/src/mainboard/google/lars/dsdt.asl</span><br><span>index b5a37c6..21e9587 100644</span><br><span>--- a/src/mainboard/google/lars/dsdt.asl</span><br><span>+++ b/src/mainboard/google/lars/dsdt.asl</span><br><span>@@ -49,7 +49,4 @@</span><br><span> </span><br><span> // Chipset specific sleep states</span><br><span> #include <soc/intel/skylake/acpi/sleepstates.asl></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- // Mainboard specific</span><br><span style="color: hsl(0, 100%, 40%);">- #include "acpi/mainboard.asl"</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/link/acpi/mainboard.asl b/src/mainboard/google/link/acpi/mainboard.asl</span><br><span>index aa33d14..6a2d890 100644</span><br><span>--- a/src/mainboard/google/link/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/link/acpi/mainboard.asl</span><br><span>@@ -17,11 +17,6 @@</span><br><span> #include <mainboard/google/link/onboard.h></span><br><span> </span><br><span> Scope (\_SB) {</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Device (TPAD)</span><br><span> {</span><br><span> Name (_ADR, 0x0)</span><br><span>diff --git a/src/mainboard/google/parrot/acpi/mainboard.asl b/src/mainboard/google/parrot/acpi/mainboard.asl</span><br><span>index 2a5c92f..4906efc 100644</span><br><span>--- a/src/mainboard/google/parrot/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/parrot/acpi/mainboard.asl</span><br><span>@@ -41,11 +41,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Device (TPAD)</span><br><span> {</span><br><span> Name (_ADR, 0x0)</span><br><span>diff --git a/src/mainboard/google/poppy/dsdt.asl b/src/mainboard/google/poppy/dsdt.asl</span><br><span>index a922d10..5b776c9 100644</span><br><span>--- a/src/mainboard/google/poppy/dsdt.asl</span><br><span>+++ b/src/mainboard/google/poppy/dsdt.asl</span><br><span>@@ -36,10 +36,6 @@</span><br><span> </span><br><span> Scope (\_SB)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> Device (PCI0)</span><br><span> {</span><br><span> /* Image processing unit */</span><br><span>diff --git a/src/mainboard/google/rambi/acpi/mainboard.asl b/src/mainboard/google/rambi/acpi/mainboard.asl</span><br><span>index e75357d..e9422b1 100644</span><br><span>--- a/src/mainboard/google/rambi/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/rambi/acpi/mainboard.asl</span><br><span>@@ -18,11 +18,6 @@</span><br><span> </span><br><span> Scope (\_SB)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_UID, 1)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> #ifdef BOARD_TRACKPAD_IRQ</span><br><span> /* Wake device for touchpad */</span><br><span> Device (TPAD)</span><br><span>diff --git a/src/mainboard/google/slippy/acpi/mainboard.asl b/src/mainboard/google/slippy/acpi/mainboard.asl</span><br><span>index f12a440..e9ade24 100644</span><br><span>--- a/src/mainboard/google/slippy/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/slippy/acpi/mainboard.asl</span><br><span>@@ -14,14 +14,6 @@</span><br><span> </span><br><span> #include <onboard.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name(_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #include <variant/acpi/mainboard.asl></span><br><span> </span><br><span> /* USB port entries */</span><br><span>diff --git a/src/mainboard/google/stout/acpi/mainboard.asl b/src/mainboard/google/stout/acpi/mainboard.asl</span><br><span>index 194ec63..92f160d 100644</span><br><span>--- a/src/mainboard/google/stout/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/stout/acpi/mainboard.asl</span><br><span>@@ -33,9 +33,4 @@</span><br><span> Store (Arg0, \_SB.PCI0.LPCB.EC0.HWLO)</span><br><span> }</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/zoombini/dsdt.asl b/src/mainboard/google/zoombini/dsdt.asl</span><br><span>index e892b47..3140990 100644</span><br><span>--- a/src/mainboard/google/zoombini/dsdt.asl</span><br><span>+++ b/src/mainboard/google/zoombini/dsdt.asl</span><br><span>@@ -37,10 +37,6 @@</span><br><span> #include <soc/intel/cannonlake/acpi/cpu.asl></span><br><span> </span><br><span> Scope (\_SB) {</span><br><span style="color: hsl(0, 100%, 40%);">- Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> Device (PCI0)</span><br><span> {</span><br><span> #include <soc/intel/cannonlake/acpi/northbridge.asl></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27272">change 27272</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27272"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I733e69affc82ed77aa79c5eca6654aaa531476ca </div>
<div style="display:none"> Gerrit-Change-Number: 27272 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>