<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27273">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Get rid of power button device in coreboot<br><br>Similar to the mainboard change to remove power button device in<br>coreboot, this change gets rid of generic hardware power button device<br>from apollolake asl.<br><br>BUG=b:110913245<br>TEST=Verified that fixed hardware power button still works as expected<br>on octopus.<br><br>Change-Id: I86259465c6cfaf579dd7dc3560b4c9e676b80b55<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/soc/intel/apollolake/acpi/southbridge.asl<br>1 file changed, 0 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/27273/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/acpi/southbridge.asl b/src/soc/intel/apollolake/acpi/southbridge.asl</span><br><span>index 5b8f9b7..9f14db4 100644</span><br><span>--- a/src/soc/intel/apollolake/acpi/southbridge.asl</span><br><span>+++ b/src/soc/intel/apollolake/acpi/southbridge.asl</span><br><span>@@ -18,15 +18,6 @@</span><br><span> #include <intelblocks/pcr.h></span><br><span> #include <soc/gpe.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Power button. */</span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-        Device (PWRB)</span><br><span style="color: hsl(0, 100%, 40%);">-   {</span><br><span style="color: hsl(0, 100%, 40%);">-               Name (_HID, EisaId ("PNP0C0C"))</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* PCIE device */</span><br><span> #include "pcie.asl"</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27273">change 27273</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27273"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I86259465c6cfaf579dd7dc3560b4c9e676b80b55 </div>
<div style="display:none"> Gerrit-Change-Number: 27273 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>