<p>Rajmohan Mani has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27259">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/nocturne: Properly name CAM0/1 files<br><br>Camera sensors connected to port 0 and port 1 of the<br>CIO2 device are named as CAM0 and CAM1.<br>CAM0 and CAM1 devices are named in cam0.asl and<br>cam1.asl filel respectively.<br><br>BUG=None<br>TEST=None<br><br>Change-Id: I0050ec871b7dd755c90b18b4c7aacfce8e2122b1<br>Signed-off-by: Rajmohan Mani <rajmohan.mani@intel.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl<br>2 files changed, 101 insertions(+), 101 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/27259/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>index cff6e66..8a2dbdd 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>@@ -13,14 +13,13 @@</span><br><span> * GNU General Public License for more details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB.PCI0.I2C5)</span><br><span style="color: hsl(120, 100%, 40%);">+Scope (\_SB.PCI0.I2C3)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device (CAM1)</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (CAM0)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, "SONY355A") /* _HID: Hardware ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_HID, "SONY319A") /* _HID: Hardware ID */</span><br><span> Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */</span><br><span> </span><br><span> Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span> {</span><br><span>@@ -29,30 +28,31 @@</span><br><span> </span><br><span> Name (_CRS, ResourceTemplate ()</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- I2cSerialBus (0x001A, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(0, 100%, 40%);">- AddressingMode7Bit, "\\_SB.PCI0.I2C5",</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Port0 of CAM1 is connected to port1 of CIO2 device */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Port0 of CAM0 is connected to port0 of CIO2 device */</span><br><span> Name (STA, 0)</span><br><span> Method (PMON, 0, Serialized) {</span><br><span> If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS(GPIO_RCAM_PWR_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS(GPIO_PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_FCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span> Sleep(3)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS (GPIO_FCAM_RST_L)</span><br><span> </span><br><span> /*</span><br><span style="color: hsl(0, 100%, 40%);">- * A delay of T7 (minimum of 10 ms) + T8</span><br><span style="color: hsl(0, 100%, 40%);">- * (max 1.4 ms + delay of coarse integration</span><br><span style="color: hsl(0, 100%, 40%);">- * time value) is needed to have the sensor</span><br><span style="color: hsl(0, 100%, 40%);">- * ready for streaming, as soon as the power</span><br><span style="color: hsl(0, 100%, 40%);">- * on sequence completes</span><br><span style="color: hsl(120, 100%, 40%);">+ * A delay of T7 (minimum of 5 ms) + T8</span><br><span style="color: hsl(120, 100%, 40%);">+ * (max 5 ms + delay of coarse integration</span><br><span style="color: hsl(120, 100%, 40%);">+ * time value + 14 H, time for 14 horizontal</span><br><span style="color: hsl(120, 100%, 40%);">+ * lines) is needed to have the sensor ready</span><br><span style="color: hsl(120, 100%, 40%);">+ * for streaming, as soon as the power on</span><br><span style="color: hsl(120, 100%, 40%);">+ * sequence completes</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">- Sleep(12)</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep(11);</span><br><span> }</span><br><span> STA++</span><br><span> }</span><br><span>@@ -63,17 +63,17 @@</span><br><span> }</span><br><span> STA--</span><br><span> If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS(GPIO_RCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS (GPIO_FCAM_PWR_EN)</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package (0x01) { FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package (0x01) { FCPR })</span><br><span> </span><br><span> /* Power resource methods for Rear Camera */</span><br><span style="color: hsl(0, 100%, 40%);">- PowerResource (RCPR, 0, 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ PowerResource (FCPR, 0, 0) {</span><br><span> Method (_ON, 0, Serialized) {</span><br><span> PMON ()</span><br><span> }</span><br><span>@@ -98,9 +98,6 @@</span><br><span> ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span> Package () {</span><br><span> Package () { "clock-frequency", 19200000 },</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "lens-focus",</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { \_SB.PCI0.I2C5.VCM0 }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span> })</span><br><span> </span><br><span>@@ -127,45 +124,13 @@</span><br><span> Package() { 360000000 }</span><br><span> },</span><br><span> Package () { "remote-endpoint",</span><br><span style="color: hsl(0, 100%, 40%);">- Package() { \_SB.PCI0.CIO2, 1, 0 }</span><br><span style="color: hsl(120, 100%, 40%);">+ Package() { \_SB.PCI0.CIO2, 0, 0 }</span><br><span> },</span><br><span> }</span><br><span> })</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Device (VCM0)</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, "PRP0001") /* _HID: Hardware ID */</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (0x0F)</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_CRS, ResourceTemplate ()</span><br><span style="color: hsl(0, 100%, 40%);">- {</span><br><span style="color: hsl(0, 100%, 40%);">- I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(0, 100%, 40%);">- AddressingMode7Bit, "\\_SB.PCI0.I2C5",</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(0, 100%, 40%);">- })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DEP, Package() { ^^I2C5.CAM1 })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DSD, Package () {</span><br><span style="color: hsl(0, 100%, 40%);">- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(0, 100%, 40%);">- Package () {</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "compatible", "asahi-kasei,ak7375" },</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- })</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Device (NVM1)</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (NVM0)</span><br><span> {</span><br><span> Name (_HID, "INT3499") /* _HID: Hardware ID */</span><br><span> Name (_UID, Zero) /* _UID: Unique ID */</span><br><span>@@ -178,15 +143,15 @@</span><br><span> </span><br><span> Name (_CRS, ResourceTemplate ()</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- I2cSerialBus (0x0051, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(0, 100%, 40%);">- AddressingMode7Bit, "\\_SB.PCI0.I2C5",</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span> 0x00, ResourceConsumer, ,)</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DEP, Package() { ^^I2C5.CAM1 })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DEP, Package () { ^^I2C3.CAM0 })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package (0x01) { ^^I2C3.CAM0.FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package (0x01) { ^^I2C3.CAM0.FCPR })</span><br><span> </span><br><span> Name (_DSD, Package ()</span><br><span> {</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>index 8a2dbdd..cff6e66 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>@@ -13,13 +13,14 @@</span><br><span> * GNU General Public License for more details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-Scope (\_SB.PCI0.I2C3)</span><br><span style="color: hsl(120, 100%, 40%);">+Scope (\_SB.PCI0.I2C5)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Device (CAM0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (CAM1)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_HID, "SONY319A") /* _HID: Hardware ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_HID, "SONY355A") /* _HID: Hardware ID */</span><br><span> Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */</span><br><span> </span><br><span> Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span> {</span><br><span>@@ -28,31 +29,30 @@</span><br><span> </span><br><span> Name (_CRS, ResourceTemplate ()</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(0, 100%, 40%);">- AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span style="color: hsl(0, 100%, 40%);">- 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x001A, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C5",</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Port0 of CAM0 is connected to port0 of CIO2 device */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Port0 of CAM1 is connected to port1 of CIO2 device */</span><br><span> Name (STA, 0)</span><br><span> Method (PMON, 0, Serialized) {</span><br><span> If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS (GPIO_FCAM_PWR_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(GPIO_RCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(GPIO_PCH_RCAM_CLK_EN)</span><br><span> Sleep(3)</span><br><span style="color: hsl(0, 100%, 40%);">- STXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(GPIO_RCAM_RST_L)</span><br><span> </span><br><span> /*</span><br><span style="color: hsl(0, 100%, 40%);">- * A delay of T7 (minimum of 5 ms) + T8</span><br><span style="color: hsl(0, 100%, 40%);">- * (max 5 ms + delay of coarse integration</span><br><span style="color: hsl(0, 100%, 40%);">- * time value + 14 H, time for 14 horizontal</span><br><span style="color: hsl(0, 100%, 40%);">- * lines) is needed to have the sensor ready</span><br><span style="color: hsl(0, 100%, 40%);">- * for streaming, as soon as the power on</span><br><span style="color: hsl(0, 100%, 40%);">- * sequence completes</span><br><span style="color: hsl(120, 100%, 40%);">+ * A delay of T7 (minimum of 10 ms) + T8</span><br><span style="color: hsl(120, 100%, 40%);">+ * (max 1.4 ms + delay of coarse integration</span><br><span style="color: hsl(120, 100%, 40%);">+ * time value) is needed to have the sensor</span><br><span style="color: hsl(120, 100%, 40%);">+ * ready for streaming, as soon as the power</span><br><span style="color: hsl(120, 100%, 40%);">+ * on sequence completes</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">- Sleep(11);</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep(12)</span><br><span> }</span><br><span> STA++</span><br><span> }</span><br><span>@@ -63,17 +63,17 @@</span><br><span> }</span><br><span> STA--</span><br><span> If (STA == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_FCAM_RST_L)</span><br><span style="color: hsl(0, 100%, 40%);">- CTXS (GPIO_FCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(GPIO_PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(GPIO_RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(GPIO_RCAM_PWR_EN)</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { FCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package (0x01) { RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package (0x01) { RCPR })</span><br><span> </span><br><span> /* Power resource methods for Rear Camera */</span><br><span style="color: hsl(0, 100%, 40%);">- PowerResource (FCPR, 0, 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ PowerResource (RCPR, 0, 0) {</span><br><span> Method (_ON, 0, Serialized) {</span><br><span> PMON ()</span><br><span> }</span><br><span>@@ -98,6 +98,9 @@</span><br><span> ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span> Package () {</span><br><span> Package () { "clock-frequency", 19200000 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "lens-focus",</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { \_SB.PCI0.I2C5.VCM0 }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> })</span><br><span> </span><br><span>@@ -124,13 +127,45 @@</span><br><span> Package() { 360000000 }</span><br><span> },</span><br><span> Package () { "remote-endpoint",</span><br><span style="color: hsl(0, 100%, 40%);">- Package() { \_SB.PCI0.CIO2, 0, 0 }</span><br><span style="color: hsl(120, 100%, 40%);">+ Package() { \_SB.PCI0.CIO2, 1, 0 }</span><br><span> },</span><br><span> }</span><br><span> })</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Device (NVM0)</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (VCM0)</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_HID, "PRP0001") /* _HID: Hardware ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_UID, Zero) /* _UID: Unique ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, NotSerialized) /* _STA: Status */</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x0F)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_CRS, ResourceTemplate ()</span><br><span style="color: hsl(120, 100%, 40%);">+ {</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C5",</span><br><span style="color: hsl(120, 100%, 40%);">+ 0x00, ResourceConsumer, ,</span><br><span style="color: hsl(120, 100%, 40%);">+ )</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DEP, Package() { ^^I2C5.CAM1 })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DSD, Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "compatible", "asahi-kasei,ak7375" },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Device (NVM1)</span><br><span> {</span><br><span> Name (_HID, "INT3499") /* _HID: Hardware ID */</span><br><span> Name (_UID, Zero) /* _UID: Unique ID */</span><br><span>@@ -143,15 +178,15 @@</span><br><span> </span><br><span> Name (_CRS, ResourceTemplate ()</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(0, 100%, 40%);">- AddressingMode7Bit, "\\_SB.PCI0.I2C3",</span><br><span style="color: hsl(120, 100%, 40%);">+ I2cSerialBus (0x0051, ControllerInitiated, 0x00061A80,</span><br><span style="color: hsl(120, 100%, 40%);">+ AddressingMode7Bit, "\\_SB.PCI0.I2C5",</span><br><span> 0x00, ResourceConsumer, ,)</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_DEP, Package () { ^^I2C3.CAM0 })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_DEP, Package() { ^^I2C5.CAM1 })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR0, Package (0x01) { ^^I2C3.CAM0.FCPR })</span><br><span style="color: hsl(0, 100%, 40%);">- Name (_PR3, Package (0x01) { ^^I2C3.CAM0.FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package (0x01) { ^^I2C5.CAM1.RCPR })</span><br><span> </span><br><span> Name (_DSD, Package ()</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27259">change 27259</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27259"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0050ec871b7dd755c90b18b4c7aacfce8e2122b1 </div>
<div style="display:none"> Gerrit-Change-Number: 27259 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rajmohan Mani <rajmohan.mani@intel.com> </div>