<p>Raul Rangel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27268">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stoneyridge: Enable legacy IO<br><br>Legacy IO enables access to RTC IO 0x70-0x73. This is needed for CMOS to<br>function correctly.<br><br>BUG=b:110817463<br>TEST=ran firmware_CorruptFwSigB on grunt<br><br>Change-Id: I533226ba764f567e348577d7fcf6ebe43336609a<br>Signed-off-by: Raul E Rangel <rrangel@chromium.org><br>---<br>M src/soc/amd/stoneyridge/include/soc/southbridge.h<br>M src/soc/amd/stoneyridge/southbridge.c<br>2 files changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27268/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>index 9f8a7d2..3127f5c 100644</span><br><span>--- a/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>+++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h</span><br><span>@@ -34,6 +34,7 @@</span><br><span> /* Power management registers:  0xfed80300 or index/data at IO 0xcd6/cd7 */</span><br><span> #define PM_DECODE_EN                     0x00</span><br><span> #define   CF9_IO_EN                     BIT(1)</span><br><span style="color: hsl(120, 100%, 40%);">+#define   LEGACY_IO_EN                  BIT(0)</span><br><span> #define PM_ISA_CONTROL                        0x04</span><br><span> #define   MMIO_EN                       BIT(1)</span><br><span> #define PM_PCI_CTRL                   0x08</span><br><span>diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>index 591a8f7..18e6c6c 100644</span><br><span>--- a/src/soc/amd/stoneyridge/southbridge.c</span><br><span>+++ b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>@@ -375,6 +375,13 @@</span><br><span>         pm_write32(PM_DECODE_EN, reg | CF9_IO_EN);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void sb_enable_legacy_io(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t reg = pm_read32(PM_DECODE_EN);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     pm_write32(PM_DECODE_EN, reg | LEGACY_IO_EN);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void sb_clk_output_48Mhz(void)</span><br><span> {</span><br><span>    u32 ctrl;</span><br><span>@@ -550,6 +557,7 @@</span><br><span>      sb_disable_4dw_burst(); /* Must be disabled on CZ(ST) */</span><br><span>     sb_acpi_mmio_decode();</span><br><span>       sb_enable_cf9_io();</span><br><span style="color: hsl(120, 100%, 40%);">+   sb_enable_legacy_io();</span><br><span>       enable_aoac_devices();</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27268">change 27268</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27268"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I533226ba764f567e348577d7fcf6ebe43336609a </div>
<div style="display:none"> Gerrit-Change-Number: 27268 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>