<p>Gwendal Grignou has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27264">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nocturne: Fix casing for register definition<br><br>Use lower case for hex values.<br><br>BUG=b:74363445<br>TEST=compile<br><br>Change-Id: I24afea58b1a791fac3c87ad397a696f7f6e0d127<br>Signed-off-by: Gwendal Grignou <gwendal@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>1 file changed, 14 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/27264/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 91c0b44..09b7ef9 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -305,15 +305,15 @@</span><br><span> register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)"</span><br><span> register "speed" = "I2C_SPEED_FAST_PLUS"</span><br><span> register "uid" = "0"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl0" = "0x1A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl0" = "0x1a"</span><br><span> register "reg_prox_ctrl1" = "0x00"</span><br><span> register "reg_prox_ctrl2" = "0x84"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl3" = "0x0E"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl3" = "0x0e"</span><br><span> register "reg_prox_ctrl4" = "0x07"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl5" = "0xC6"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl5" = "0xc6"</span><br><span> register "reg_prox_ctrl6" = "0x20"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl7" = "0x0D"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl8" = "0x8D"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl7" = "0x0d"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl8" = "0x8d"</span><br><span> register "reg_prox_ctrl9" = "0x43"</span><br><span> register "reg_prox_ctrl10" = "0x11"</span><br><span> register "reg_prox_ctrl11" = "0x00"</span><br><span>@@ -326,8 +326,8 @@</span><br><span> register "reg_prox_ctrl18" = "0x00"</span><br><span> register "reg_prox_ctrl19" = "0x00"</span><br><span> register "reg_sar_ctrl0" = "0x50"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_sar_ctrl1" = "0x8A"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_sar_ctrl2" = "0x3C"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_sar_ctrl1" = "0x8a"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_sar_ctrl2" = "0x3c"</span><br><span> device i2c 28 on end</span><br><span> end</span><br><span> end # I2C #1</span><br><span>@@ -346,15 +346,15 @@</span><br><span> register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D10_IRQ)"</span><br><span> register "speed" = "I2C_SPEED_FAST_PLUS"</span><br><span> register "uid" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl0" = "0x1A"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl0" = "0x1a"</span><br><span> register "reg_prox_ctrl1" = "0x00"</span><br><span> register "reg_prox_ctrl2" = "0x84"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl3" = "0x0E"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl3" = "0x0e"</span><br><span> register "reg_prox_ctrl4" = "0x07"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl5" = "0xC6"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl5" = "0xc6"</span><br><span> register "reg_prox_ctrl6" = "0x20"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl7" = "0x0D"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_prox_ctrl8" = "0x8D"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl7" = "0x0d"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_prox_ctrl8" = "0x8d"</span><br><span> register "reg_prox_ctrl9" = "0x43"</span><br><span> register "reg_prox_ctrl10" = "0x11"</span><br><span> register "reg_prox_ctrl11" = "0x00"</span><br><span>@@ -367,8 +367,8 @@</span><br><span> register "reg_prox_ctrl18" = "0x00"</span><br><span> register "reg_prox_ctrl19" = "0x00"</span><br><span> register "reg_sar_ctrl0" = "0x50"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_sar_ctrl1" = "0x8A"</span><br><span style="color: hsl(0, 100%, 40%);">- register "reg_sar_ctrl2" = "0x3C"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_sar_ctrl1" = "0x8a"</span><br><span style="color: hsl(120, 100%, 40%);">+ register "reg_sar_ctrl2" = "0x3c"</span><br><span> device i2c 28 on end</span><br><span> end</span><br><span> end # I2C #5</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27264">change 27264</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27264"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I24afea58b1a791fac3c87ad397a696f7f6e0d127 </div>
<div style="display:none"> Gerrit-Change-Number: 27264 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Gwendal Grignou <gwendal@chromium.org> </div>