<p>John Su has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27260">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami: Perform PL2 setting for sona<br>different cpu model<br><br>According to sona thermal table, PL2 need to check cpu mode.<br>And then set PL2 value.<br><br>BUG=b:1075491<br>TEST=The thermal team verify OK<br><br>Change-Id: I5759fb3c685e3d4eef1be054541f950843d19874<br>Signed-off-by: John Su <john_su@compal.corp-partner.google.com><br>---<br>M src/mainboard/google/poppy/variants/nami/mainboard.c<br>1 file changed, 13 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/27260/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c</span><br><span>index 1d5a0b2..e0b89ee 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/mainboard.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c</span><br><span>@@ -31,13 +31,21 @@</span><br><span> </span><br><span> #define PL2_I7_SKU  44</span><br><span> #define PL2_DEFAULT       29</span><br><span style="color: hsl(120, 100%, 40%);">+#define PL2_KBL_R      25</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static uint32_t get_pl2(void)</span><br><span style="color: hsl(120, 100%, 40%);">+static uint32_t get_pl2(uint32_t sku_id)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   if (cpuid_eax(1) == CPUID_KABYLAKE_Y0)</span><br><span style="color: hsl(0, 100%, 40%);">-          return PL2_I7_SKU;</span><br><span style="color: hsl(120, 100%, 40%);">+    if ((sku_id == SKU_0_SONA) | (sku_id == SKU_1_SONA)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                if (cpuid_eax(1) == CPUID_KABYLAKE_Y0)</span><br><span style="color: hsl(120, 100%, 40%);">+                        return PL2_DEFAULT;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- return PL2_DEFAULT;</span><br><span style="color: hsl(120, 100%, 40%);">+           return PL2_KBL_R;</span><br><span style="color: hsl(120, 100%, 40%);">+     } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (cpuid_eax(1) == CPUID_KABYLAKE_Y0)</span><br><span style="color: hsl(120, 100%, 40%);">+                        return PL2_I7_SKU;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+          return PL2_DEFAULT;</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span> }</span><br><span> </span><br><span> uint32_t variant_board_sku(void)</span><br><span>@@ -62,7 +70,7 @@</span><br><span>   config_t *cfg = root->chip_info;</span><br><span> </span><br><span>      /* Update PL2 based on SKU. */</span><br><span style="color: hsl(0, 100%, 40%);">-  cfg->tdp_pl2_override = get_pl2();</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg->tdp_pl2_override = get_pl2(sku_id);</span><br><span> </span><br><span>      switch (sku_id) {</span><br><span>    case SKU_0_VAYNE:</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27260">change 27260</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27260"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5759fb3c685e3d4eef1be054541f950843d19874 </div>
<div style="display:none"> Gerrit-Change-Number: 27260 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John Su <john_su@compal.corp-partner.google.com> </div>