<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/27220">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU<br><br>We would use GPP_B20 instead of board id to determine nautilus SKU.<br><br>BUG=b:80052672<br>BRANCH=poppy<br>TEST=Verified the new coreboot could determine SKU correctly<br><br>Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36<br>Signed-off-by: Seunghwan Kim <sh_.kim@samsung.com><br>Reviewed-on: https://review.coreboot.org/27220<br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>---<br>M src/mainboard/google/poppy/variants/nautilus/mainboard.c<br>1 file changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c</span><br><span>index b4ef1c2..502195e 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c</span><br><span>@@ -13,9 +13,9 @@</span><br><span>  * GNU General Public License for more details.</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <boardid.h></span><br><span> #include <baseboard/variants.h></span><br><span> #include <chip.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gpio.h></span><br><span> #include <device/device.h></span><br><span> #include <variant/sku.h></span><br><span> </span><br><span>@@ -26,7 +26,13 @@</span><br><span>         if (sku_id != SKU_UNKNOWN)</span><br><span>           return sku_id;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      if (board_id() < 9)</span><br><span style="color: hsl(120, 100%, 40%);">+        /*</span><br><span style="color: hsl(120, 100%, 40%);">+    *  Nautilus uses GPP_B20 to determine SKU</span><br><span style="color: hsl(120, 100%, 40%);">+     *  0 - Wifi SKU</span><br><span style="color: hsl(120, 100%, 40%);">+       *  1 - LTE SKU</span><br><span style="color: hsl(120, 100%, 40%);">+        */</span><br><span style="color: hsl(120, 100%, 40%);">+    gpio_input_pulldown(GPP_B20);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!gpio_get(GPP_B20))</span><br><span>              sku_id = SKU_0_NAUTILUS;</span><br><span>     else</span><br><span>                 sku_id = SKU_1_NAUTILUS_LTE;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27220">change 27220</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27220"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 </div>
<div style="display:none"> Gerrit-Change-Number: 27220 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Seunghwan Kim <sh_.kim@samsung.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Philip Chen <philipchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>