<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27266">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cbfstool: fix FIT entry checksum value for ucode entries<br><br>commit c1072f2 [cbfstool: Update FIT entries in the second bootblock]<br>incorrectly changed the value of type_checksum_valid for microcode<br>entries from FIT_TYPE_MICROCODE to 0, breaking microcode loading on<br>Skylake/FSP1.1 devices (and others?).  Correct this by reverting to the<br>previous value.<br><br>Test: build/boot google/chell, observe FspTempRamInit no longer fails,<br>device boots as expected.<br><br>Change-Id: Ib2a90137c7d4acf6ecd9f06cb6f856bd7e783676<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M util/cbfstool/fit.c<br>1 file changed, 1 insertion(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/27266/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/cbfstool/fit.c b/util/cbfstool/fit.c</span><br><span>index 31ab3de..ad9ab37 100644</span><br><span>--- a/util/cbfstool/fit.c</span><br><span>+++ b/util/cbfstool/fit.c</span><br><span>@@ -182,8 +182,7 @@</span><br><span>   * rather from the MCU header, hence we can assign zero here</span><br><span>          */</span><br><span>  entry->size_reserved = 0x0000;</span><br><span style="color: hsl(0, 100%, 40%);">-       /* Checksum valid should be cleared for MCU */</span><br><span style="color: hsl(0, 100%, 40%);">-  entry->type_checksum_valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+    entry->type_checksum_valid = FIT_TYPE_MICROCODE;</span><br><span>  entry->version = FIT_MICROCODE_VERSION;</span><br><span>   entry->checksum = 0;</span><br><span>      fit_entry_add_size(&fit->header, sizeof(struct fit_entry));</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27266">change 27266</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27266"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib2a90137c7d4acf6ecd9f06cb6f856bd7e783676 </div>
<div style="display:none"> Gerrit-Change-Number: 27266 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>