<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27249">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Remove call to pmc_fixup_power_state<br><br>On APL, call to pmc_fixup_power_state was added because GPE0_EN<br>registers did not have the right bits set on resume from S3 -- this<br>was a result of GPE_CFG registers getting reset to their default state<br>on resume. GPE_CFG registers are programmed as part of pmc_gpe_init<br>which was previously done only in ramstage.<br><br>However, with change a673d1c (soc/intel/apollolake: Initialize GPEs in<br>bootblock), call to pmc_gpe_init was added to bootblock which means<br>that GPE_CFG registers will have the right state by the time control<br>reaches romstage where pmc_fill_power_state is called. Thus, call to<br>pmc_fixup_power_state is totally redundant and in fact leads to<br>side-effects because of the call to pmc_disable_all_gpe at the end of<br>pmc_fill_power_state.<br><br>BUG=b:110836465<br>TEST=Verified on yorp that wake source is correctly identified on<br>resume from S3.<br><br>Change-Id: Ia63ddbe381ce8a59736c231d745fd71d008d5d92<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/soc/intel/apollolake/pmc.c<br>1 file changed, 0 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/27249/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/pmc.c b/src/soc/intel/apollolake/pmc.c</span><br><span>index 58cb71a..15ef243 100644</span><br><span>--- a/src/soc/intel/apollolake/pmc.c</span><br><span>+++ b/src/soc/intel/apollolake/pmc.c</span><br><span>@@ -97,7 +97,6 @@</span><br><span> </span><br><span>   /* Set up GPE configuration */</span><br><span>       pmc_gpe_init();</span><br><span style="color: hsl(0, 100%, 40%);">- pmc_fixup_power_state();</span><br><span>     pmc_set_acpi_mode();</span><br><span> </span><br><span>     if (cfg != NULL)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27249">change 27249</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27249"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ia63ddbe381ce8a59736c231d745fd71d008d5d92 </div>
<div style="display:none"> Gerrit-Change-Number: 27249 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>