<p>Vincent Palatin has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27221">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity<br><br>the FPMCU_INT_L on GPP_C11 active low but the kernel irq handler is<br>defined as IRQF_TRIGGER_LOW, so do not invert it twice.<br><br>BRANCH=poppy<br>BUG=b:78613978<br>TEST=On Nocturne, the 'cros_ec' IRQ count in /proc/interrupts does not<br>increment wildly.<br><br>Change-Id: I56c13c797b133dd22669a2299bcd16ef14eed335<br>Signed-off-by: Vincent Palatin <vpalatin@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/nocturne/gpio.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/27221/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>index f602479..b6327d0 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c</span><br><span>@@ -135,7 +135,7 @@</span><br><span>      /* C10 : UART0_RTS# ==> PCH_FPMCU_RST_ODL */</span><br><span>      PAD_CFG_GPO(GPP_C10, 0, DEEP),</span><br><span>       /* C11 : UART0_CTS# ==> FPMCU_INT */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI_APIC_INVERT(GPP_C11, NONE, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_CFG_GPI_APIC(GPP_C11, NONE, DEEP),</span><br><span>       /* C12 : UART1_RXD ==> PCH_MEM_CONFIG[0] */</span><br><span>       PAD_CFG_GPI_GPIO_DRIVER(GPP_C12, NONE, DEEP),</span><br><span>        /* C13 : UART1_TXD ==> PCH_MEM_CONFIG[1] */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27221">change 27221</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27221"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I56c13c797b133dd22669a2299bcd16ef14eed335 </div>
<div style="display:none"> Gerrit-Change-Number: 27221 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vincent Palatin <vpalatin@chromium.org> </div>