<p>Justin TerAvest has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27223">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Create bobba variant<br><br>This creates a bobba variant for octopus. Nothing is set in the variant<br>files here; everything is picked up from baseboard.<br><br>BUG=b:110781720<br>TEST=None<br><br>Change-Id: Ic30c6b0d955ce26f4a9f40cd7fef1c429ab950fc<br>Signed-off-by: Justin TerAvest <teravest@chromium.org><br>---<br>M src/mainboard/google/octopus/Kconfig<br>M src/mainboard/google/octopus/Kconfig.name<br>A src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl<br>A src/mainboard/google/octopus/variants/bobba/include/variant/ec.h<br>A src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h<br>5 files changed, 68 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/27223/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig</span><br><span>index 226e44f..06f5786 100644</span><br><span>--- a/src/mainboard/google/octopus/Kconfig</span><br><span>+++ b/src/mainboard/google/octopus/Kconfig</span><br><span>@@ -43,6 +43,7 @@</span><br><span> default "bip" if BOARD_GOOGLE_BIP</span><br><span> default "phaser" if BOARD_GOOGLE_PHASER</span><br><span> default "fleex" if BOARD_GOOGLE_FLEEX</span><br><span style="color: hsl(120, 100%, 40%);">+ default "bobba" if BOARD_GOOGLE_BOBBA</span><br><span> default "octopus" if BOARD_GOOGLE_OCTOPUS</span><br><span> </span><br><span> config DEVICETREE</span><br><span>@@ -56,6 +57,7 @@</span><br><span> default "Bip" if BOARD_GOOGLE_BIP</span><br><span> default "Phaser" if BOARD_GOOGLE_PHASER</span><br><span> default "Fleex" if BOARD_GOOGLE_FLEEX</span><br><span style="color: hsl(120, 100%, 40%);">+ default "Bobba" if BOARD_GOOGLE_BOBBA</span><br><span> default "Octopus" if BOARD_GOOGLE_OCTOPUS</span><br><span> </span><br><span> config MAINBOARD_FAMILY</span><br><span>@@ -69,6 +71,7 @@</span><br><span> default "BIP TEST 5732" if BOARD_GOOGLE_BIP</span><br><span> default "PHASER TEST 7167" if BOARD_GOOGLE_PHASER</span><br><span> default "FLEEX TEST 7423" if BOARD_GOOGLE_FLEEX</span><br><span style="color: hsl(120, 100%, 40%);">+ default "BOBBA TEST 4516" if BOARD_GOOGLE_BOBBA</span><br><span> default "OCTOPUS TEST 6859" if BOARD_GOOGLE_OCTOPUS</span><br><span> </span><br><span> config MAX_CPUS</span><br><span>diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name</span><br><span>index f30b46f..cfe051c 100644</span><br><span>--- a/src/mainboard/google/octopus/Kconfig.name</span><br><span>+++ b/src/mainboard/google/octopus/Kconfig.name</span><br><span>@@ -30,3 +30,10 @@</span><br><span> select BOARD_GOOGLE_BASEBOARD_OCTOPUS</span><br><span> select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if CHROMEOS</span><br><span> select NHLT_DA7219 if INCLUDE_NHLT_BLOBS</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config BOARD_GOOGLE_BOBBA</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "-> Bobba"</span><br><span style="color: hsl(120, 100%, 40%);">+ select BASEBOARD_OCTOPUS_LAPTOP</span><br><span style="color: hsl(120, 100%, 40%);">+ select BOARD_GOOGLE_BASEBOARD_OCTOPUS</span><br><span style="color: hsl(120, 100%, 40%);">+ select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if CHROMEOS</span><br><span style="color: hsl(120, 100%, 40%);">+ select NHLT_DA7219 if INCLUDE_NHLT_BLOBS</span><br><span>diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl b/src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..cc17d56</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl</span><br><span>@@ -0,0 +1,16 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/acpi/dptf.asl></span><br><span>diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h</span><br><span>new file mode 100644</span><br><span>index 0000000..16f931b</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h</span><br><span>@@ -0,0 +1,21 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef MAINBOARD_EC_H</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_EC_H</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/ec.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h b/src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h</span><br><span>new file mode 100644</span><br><span>index 0000000..1fd1e11</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h</span><br><span>@@ -0,0 +1,21 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Google LLC</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef MAINBOARD_GPIO_H</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAINBOARD_GPIO_H</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <baseboard/gpio.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* MAINBOARD_GPIO_H */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27223">change 27223</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27223"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic30c6b0d955ce26f4a9f40cd7fef1c429ab950fc </div>
<div style="display:none"> Gerrit-Change-Number: 27223 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Justin TerAvest <teravest@chromium.org> </div>