<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27234">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Enable logging for wake sources in S0ix<br><br>This change adds GSMI callback elog_gsmi_cb_platform_log_wake_source<br>to enable wake source logging from S0ix on APL/GLK. Additionally,<br>elog.c is added to smm stage.<br><br>BUG=b:79449585<br>TEST=Verified that S0ix entry/exit events are added to eventlog:<br><br>=========== Power button ============<br>59 | 2018-06-25 14:01:11 | S0ix Enter<br>60 | 2018-06-25 14:01:30 | S0ix Exit<br>61 | 2018-06-25 14:02:00 | Wake Source | Power Button | 0<br><br>=========== Lid open ================<br>62 | 2018-06-25 14:02:36 | S0ix Enter<br>63 | 2018-06-25 14:02:56 | S0ix Exit<br>64 | 2018-06-25 14:03:26 | Wake Source | GPE # | 15<br>65 | 2018-06-25 14:03:32 | Wake Source | GPE # | 65<br>66 | 2018-06-25 14:03:37 | EC Event | Lid Open<br><br>=========== Trackpad ================<br>67 | 2018-06-25 14:04:20 | S0ix Enter<br>68 | 2018-06-25 14:04:33 | S0ix Exit<br>69 | 2018-06-25 14:05:03 | Wake Source | GPE # | 15<br>70 | 2018-06-25 14:05:08 | Wake Source | GPE # | 66<br><br>Change-Id: I005de58c73d00dc9d7e64f1459f6d786792b94db<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/soc/intel/apollolake/Makefile.inc<br>M src/soc/intel/apollolake/elog.c<br>2 files changed, 12 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/27234/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.inc</span><br><span>index 9b09b09..cb66365 100644</span><br><span>--- a/src/soc/intel/apollolake/Makefile.inc</span><br><span>+++ b/src/soc/intel/apollolake/Makefile.inc</span><br><span>@@ -43,6 +43,7 @@</span><br><span> smm-y += smihandler.c</span><br><span> smm-y += spi.c</span><br><span> smm-$(CONFIG_SOC_UART_DEBUG) += uart.c</span><br><span style="color: hsl(120, 100%, 40%);">+smm-y += elog.c</span><br><span> </span><br><span> ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi.c</span><br><span> ramstage-y += cpu.c</span><br><span>diff --git a/src/soc/intel/apollolake/elog.c b/src/soc/intel/apollolake/elog.c</span><br><span>index 1e9b7d8..cbd13a8 100644</span><br><span>--- a/src/soc/intel/apollolake/elog.c</span><br><span>+++ b/src/soc/intel/apollolake/elog.c</span><br><span>@@ -18,6 +18,7 @@</span><br><span> #include <cbmem.h></span><br><span> #include <console/console.h></span><br><span> #include <elog.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <intelblocks/pmclib.h></span><br><span> #include <soc/pm.h></span><br><span> #include <soc/pci_devs.h></span><br><span> #include <stdint.h></span><br><span>@@ -57,7 +58,8 @@</span><br><span> elog_add_event_wake(ELOG_WAKE_SOURCE_SMBUS, 0);</span><br><span> </span><br><span> /* ACPI Wake Event - Always Log prev_sleep_state*/</span><br><span style="color: hsl(0, 100%, 40%);">- elog_add_event_byte(ELOG_TYPE_ACPI_WAKE, ps->prev_sleep_state);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ps->prev_sleep_state != ACPI_S0)</span><br><span style="color: hsl(120, 100%, 40%);">+ elog_add_event_byte(ELOG_TYPE_ACPI_WAKE, ps->prev_sleep_state);</span><br><span> </span><br><span> /* Log GPIO events in set A-D */</span><br><span> pch_log_gpio_gpe(ps->gpe0_sts[GPE0_A], ps->gpe0_en[GPE0_A], 0);</span><br><span>@@ -105,3 +107,11 @@</span><br><span> if (ps->prev_sleep_state > ACPI_S0)</span><br><span> pch_log_wake_source(ps);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void elog_gsmi_cb_platform_log_wake_source(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct chipset_power_state ps;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ pmc_fill_pm_reg_info(&ps);</span><br><span style="color: hsl(120, 100%, 40%);">+ pch_log_wake_source(&ps);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27234">change 27234</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27234"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I005de58c73d00dc9d7e64f1459f6d786792b94db </div>
<div style="display:none"> Gerrit-Change-Number: 27234 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>