<p>Quan Tran has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27168">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">inteltool: Add PCI IDs for the C220 PCH series<br><br>The C220 PCH series is a ICH8 generation southbridge. There is already existing code<br>to dump this southbridge. This patch adds the missing PCI IDs to<br>allow the tool to dump them.<br>Documentation on the PCH can be found here:<br>https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/8-series-chipset-pch-datasheet.pdf<br><br>Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35<br>Signed-off-by: Quan Tran <qeed.quan@gmail.com><br>---<br>M util/inteltool/gpio.c<br>M util/inteltool/inteltool.c<br>M util/inteltool/inteltool.h<br>M util/inteltool/powermgt.c<br>M util/inteltool/rootcmplx.c<br>M util/inteltool/spi.c<br>6 files changed, 121 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/27168/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c</span><br><span>index 5e31035..5ef96fd 100644</span><br><span>--- a/util/inteltool/gpio.c</span><br><span>+++ b/util/inteltool/gpio.c</span><br><span>@@ -849,6 +849,21 @@</span><br><span> case PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_BASE:</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_PREM:</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_MOBILE:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_DESKTOP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM86:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_QM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_B85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C222:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C224:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C226:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H81:</span><br><span> gpiobase = pci_read_word(sb, 0x48) & 0xfffc;</span><br><span> gpio_registers = lynxpoint_lp_gpio_registers;</span><br><span> size = ARRAY_SIZE(lynxpoint_lp_gpio_registers);</span><br><span>diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c</span><br><span>index 24d62e1..e475157 100644</span><br><span>--- a/util/inteltool/inteltool.c</span><br><span>+++ b/util/inteltool/inteltool.c</span><br><span>@@ -232,6 +232,36 @@</span><br><span> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HM175, "HM175" },</span><br><span> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QM175, "QM175" },</span><br><span> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CM238, "CM238" },</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C8_MOBILE,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) C8 Mobile"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C8_DESKTOP,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) C8 Desktop"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z87,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) Z87"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Z85,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) Z85"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HM86,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) HM86"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H87,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) H87"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HM87,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) HM87"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Q85,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) Q85"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_Q87,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) Q87"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QM87,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) QM87"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_B85,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) B85"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C222,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) C222"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C224,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) C224"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C226,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) C226"},</span><br><span style="color: hsl(120, 100%, 40%);">+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H81,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Intel(R) H81"},</span><br><span> /* Intel GPUs */</span><br><span> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_G35_EXPRESS,</span><br><span> "Intel(R) G35 Express Chipset Family" },</span><br><span>diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h</span><br><span>index 3ca91cd..7f2372b 100644</span><br><span>--- a/util/inteltool/inteltool.h</span><br><span>+++ b/util/inteltool/inteltool.h</span><br><span>@@ -184,6 +184,22 @@</span><br><span> #define PCI_DEVICE_ID_INTEL_82B43 0x2e40</span><br><span> #define PCI_DEVICE_ID_INTEL_82B43_2 0x2e90</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_C8_MOBILE 0x8c41</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_C8_DESKTOP 0x8c42</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_Z87 0x8c44</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_Z85 0x8c46</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_HM86 0x8c49</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_H87 0x8c4a</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_HM87 0x8c4b</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_Q85 0x8c4c</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_Q87 0x8c4e</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_QM87 0x8c4f</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_B85 0x8c50</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_C222 0x8c52</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_C224 0x8c54</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_C226 0x8c56</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCI_DEVICE_ID_INTEL_H81 0x8c5c</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #define PCI_DEVICE_ID_INTEL_82X58 0x3405</span><br><span> #define PCI_DEVICE_ID_INTEL_SCH_POULSBO 0x8100</span><br><span> #define PCI_DEVICE_ID_INTEL_ATOM_DXXX 0xa000</span><br><span>diff --git a/util/inteltool/powermgt.c b/util/inteltool/powermgt.c</span><br><span>index f022904..45cbb33 100644</span><br><span>--- a/util/inteltool/powermgt.c</span><br><span>+++ b/util/inteltool/powermgt.c</span><br><span>@@ -730,6 +730,21 @@</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_PREM:</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP:</span><br><span> case PCI_DEVICE_ID_INTEL_BAYTRAIL_LPC:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_MOBILE:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_DESKTOP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM86:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_QM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_B85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C222:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C224:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C226:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H81:</span><br><span> pmbase = pci_read_word(sb, 0x40) & 0xff80;</span><br><span> pm_registers = pch_pm_registers;</span><br><span> size = ARRAY_SIZE(pch_pm_registers);</span><br><span>diff --git a/util/inteltool/rootcmplx.c b/util/inteltool/rootcmplx.c</span><br><span>index 2ad3410..76cb287 100644</span><br><span>--- a/util/inteltool/rootcmplx.c</span><br><span>+++ b/util/inteltool/rootcmplx.c</span><br><span>@@ -97,6 +97,21 @@</span><br><span> case PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_BASE:</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_PREM:</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_MOBILE:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_DESKTOP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM86:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_QM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_B85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C222:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C224:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C226:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H81:</span><br><span> rcba_phys = pci_read_long(sb, 0xf0) & 0xfffffffe;</span><br><span> break;</span><br><span> case PCI_DEVICE_ID_INTEL_ICH:</span><br><span>diff --git a/util/inteltool/spi.c b/util/inteltool/spi.c</span><br><span>index 6d11fa5..18600b6 100644</span><br><span>--- a/util/inteltool/spi.c</span><br><span>+++ b/util/inteltool/spi.c</span><br><span>@@ -160,6 +160,21 @@</span><br><span> case PCI_DEVICE_ID_INTEL_HM75:</span><br><span> case PCI_DEVICE_ID_INTEL_HM70:</span><br><span> case PCI_DEVICE_ID_INTEL_NM70:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_MOBILE:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_DESKTOP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM86:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_QM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_B85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C222:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C224:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C226:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H81:</span><br><span> bios_cntl = pci_read_byte(sb, 0xdc);</span><br><span> bios_cntl_register = pch_bios_cntl_registers;</span><br><span> size = ARRAY_SIZE(pch_bios_cntl_registers);</span><br><span>@@ -273,6 +288,21 @@</span><br><span> case PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_BASE:</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP_PREM:</span><br><span> case PCI_DEVICE_ID_INTEL_WILDCATPOINT_LP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_MOBILE:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C8_DESKTOP:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Z85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM86:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_HM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_Q87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_QM87:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_B85:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C222:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C224:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_C226:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCI_DEVICE_ID_INTEL_H81:</span><br><span> spibaroffset = ICH9_SPIBAR;</span><br><span> rcba_phys = pci_read_long(sb, 0xf0) & 0xfffffffe;</span><br><span> size = ARRAY_SIZE(spi_bar_registers);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27168">change 27168</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27168"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35 </div>
<div style="display:none"> Gerrit-Change-Number: 27168 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Quan Tran <qeed.quan@gmail.com> </div>