<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27145">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP] Update libgfxinit for dynamic CPU detection<br><br>Change-Id: I8c349f0ee42c7b201ef0c7461c39c82dede823a9<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M 3rdparty/libgfxinit<br>M 3rdparty/libhwbase<br>M src/drivers/intel/gma/Kconfig<br>M src/drivers/intel/gma/hires_fb/gma.adb<br>4 files changed, 22 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/27145/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit</span><br><span>index 718c79b..26d68ca 160000</span><br><span>--- a/3rdparty/libgfxinit</span><br><span>+++ b/3rdparty/libgfxinit</span><br><span>@@ -1 +1 @@</span><br><span style="color: hsl(0, 100%, 40%);">-Subproject commit 718c79bb0713b5b90c9cc44e03197dc777066e3d</span><br><span style="color: hsl(120, 100%, 40%);">+Subproject commit 26d68ca84e2e7bae1387e06c55e9b7b9d5230282</span><br><span>diff --git a/3rdparty/libhwbase b/3rdparty/libhwbase</span><br><span>index 637f2a4..b38f4b2 160000</span><br><span>--- a/3rdparty/libhwbase</span><br><span>+++ b/3rdparty/libhwbase</span><br><span>@@ -1 +1 @@</span><br><span style="color: hsl(0, 100%, 40%);">-Subproject commit 637f2a4f21ead8ccc45d5256834eb27ce72088db</span><br><span style="color: hsl(120, 100%, 40%);">+Subproject commit b38f4b254801aa0c30b25d7f4cd383cac7b04fb5</span><br><span>diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig</span><br><span>index 1b9c2a6..6e4a875 100644</span><br><span>--- a/src/drivers/intel/gma/Kconfig</span><br><span>+++ b/src/drivers/intel/gma/Kconfig</span><br><span>@@ -73,6 +73,22 @@</span><br><span> </span><br><span> if GFX_GMA</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config GFX_GMA_GENERATION</span><br><span style="color: hsl(120, 100%, 40%);">+    string</span><br><span style="color: hsl(120, 100%, 40%);">+        default "Skylake" if SOC_INTEL_SKYLAKE</span><br><span style="color: hsl(120, 100%, 40%);">+      default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL</span><br><span style="color: hsl(120, 100%, 40%);">+       default "Ironlake" if NORTHBRIDGE_INTEL_NEHALEM || \</span><br><span style="color: hsl(120, 100%, 40%);">+                                NORTHBRIDGE_INTEL_SANDYBRIDGE || \</span><br><span style="color: hsl(120, 100%, 40%);">+                            NORTHBRIDGE_INTEL_IVYBRIDGE</span><br><span style="color: hsl(120, 100%, 40%);">+   default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config GFX_GMA_DYN_CPU</span><br><span style="color: hsl(120, 100%, 40%);">+  boolean</span><br><span style="color: hsl(120, 100%, 40%);">+       default y if    NORTHBRIDGE_INTEL_SANDYBRIDGE || \</span><br><span style="color: hsl(120, 100%, 40%);">+                    NORTHBRIDGE_INTEL_IVYBRIDGE || \</span><br><span style="color: hsl(120, 100%, 40%);">+                      (NORTHBRIDGE_INTEL_HASWELL && !INTEL_LYNXPOINT_LP) || \</span><br><span style="color: hsl(120, 100%, 40%);">+                       (SOC_INTEL_SKYLAKE && SKYLAKE_SOC_PCH_H)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> config GFX_GMA_CPU</span><br><span>     string</span><br><span>       default "Skylake" if SOC_INTEL_SKYLAKE</span><br><span>diff --git a/src/drivers/intel/gma/hires_fb/gma.adb b/src/drivers/intel/gma/hires_fb/gma.adb</span><br><span>index ca0f708..bd14132 100644</span><br><span>--- a/src/drivers/intel/gma/hires_fb/gma.adb</span><br><span>+++ b/src/drivers/intel/gma/hires_fb/gma.adb</span><br><span>@@ -60,8 +60,8 @@</span><br><span> </span><br><span>       success : boolean;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      min_h : pos16 := pos16'last;</span><br><span style="color: hsl(0, 100%, 40%);">-      min_v : pos16 := pos16'last;</span><br><span style="color: hsl(120, 100%, 40%);">+      min_h : pos32 := pos32'last;</span><br><span style="color: hsl(120, 100%, 40%);">+      min_v : pos32 := pos32'last;</span><br><span>    begin</span><br><span>       lightup_ok := 0;</span><br><span> </span><br><span>@@ -75,8 +75,8 @@</span><br><span>             for i in Pipe_Index loop</span><br><span>                exit when configs (i).Port = Disabled;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-               min_h := pos16'min (min_h, configs (i).Mode.H_Visible);</span><br><span style="color: hsl(0, 100%, 40%);">-               min_v := pos16'min (min_v, configs (i).Mode.V_Visible);</span><br><span style="color: hsl(120, 100%, 40%);">+               min_h := pos32'min (min_h, configs (i).Mode.H_Visible);</span><br><span style="color: hsl(120, 100%, 40%);">+               min_v := pos32'min (min_v, configs (i).Mode.V_Visible);</span><br><span>             end loop;</span><br><span> </span><br><span>             fb := configs (Primary).Framebuffer;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27145">change 27145</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27145"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8c349f0ee42c7b201ef0c7461c39c82dede823a9 </div>
<div style="display:none"> Gerrit-Change-Number: 27145 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>