<p><a href="https://review.coreboot.org/27137">View Change</a></p><p>37 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch">File payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@16">Patch Set #1, Line 16:</a> <code style="font-family:monospace,monospace"> } else {
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace"> Length = strlen(Str);
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace"> if (Length < 4) {
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace">- strncpy (TemStr + 4 - Length, Str, Length);
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace">+ memcpy (TemStr + 4 - Length, Str, Length);
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@21">Patch Set #1, Line 21:</a> <code style="font-family:monospace,monospace"> } else {
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace">- strncpy (TemStr, Str + Length - 4, 4);
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@23">Patch Set #1, Line 23:</a> <code style="font-family:monospace,monospace">+ memcpy (TemStr, Str + Length - 4, 4);
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@24">Patch Set #1, Line 24:</a> <code style="font-family:monospace,monospace"> }
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@25">Patch Set #1, Line 25:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@26">Patch Set #1, Line 26:</a> <code style="font-family:monospace,monospace"> sscanf (
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@28">Patch Set #1, Line 28:</a> <code style="font-family:monospace,monospace"> //
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@29">Patch Set #1, Line 29:</a> <code style="font-family:monospace,monospace"> FitStartPtr = (FIT_TABLE *) RelativeAddress;
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@31">Patch Set #1, Line 31:</a> <code style="font-family:monospace,monospace">- strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ "
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace">+ memcpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ "
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@33">Patch Set #1, Line 33:</a> <code style="font-family:monospace,monospace"> assert (((VtfInfo->CompSize & 0x00FFFFFF) % 16) == 0);
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@34">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace"> FitStartPtr->CompSize = (VtfInfo->CompSize & 0x00FFFFFF) / 16;
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@35">Patch Set #1, Line 35:</a> <code style="font-family:monospace,monospace"> FitStartPtr->CompVersion = MAKE_VERSION (VtfInfo->MajorVer, VtfInfo->MinorVer);
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace">-- </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch">File payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@17">Patch Set #1, Line 17:</a> <code style="font-family:monospace,monospace"> UINT8 BlockType;
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace"> EFI_HII_STRING_PACKAGE_HDR *PkgHeader;
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace">- if (mStringFileName == '\0' ) {
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@21">Patch Set #1, Line 21:</a> <code style="font-family:monospace,monospace">+ if (mStringFileName == NULL ) {
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace"> return NULL;
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@23">Patch Set #1, Line 23:</a> <code style="font-family:monospace,monospace"> }
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@24">Patch Set #1, Line 24:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@30">Patch Set #1, Line 30:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@31">Patch Set #1, Line 31:</a> <code style="font-family:monospace,monospace"> StringPtr = ConfigAltResp;
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@32">Patch Set #1, Line 32:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@33">Patch Set #1, Line 33:</a> <code style="font-family:monospace,monospace">- while (StringPtr != L'\0') {
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@34">Patch Set #1, Line 34:</a> <code style="font-family:monospace,monospace">+ while (StringPtr != NULL) {
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOS line endings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@35">Patch Set #1, Line 35:</a> <code style="font-family:monospace,monospace"> //
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace"> // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=...
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace"> //
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch@38">Patch Set #1, Line 38:</a> <code style="font-family:monospace,monospace">-- </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27137">change 27137</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27137"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7e2efea930b27749b1097607ab143ce2f91e79ec </div>
<div style="display:none"> Gerrit-Change-Number: 27137 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 17 Jun 2018 09:09:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>