<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27140">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/baytrail: Fix Kconfig for mrc.bin inclusion<br><br>Is used the sandybridge systemagent binary and mentioned that in the<br>help text which is simply wrong and won't work.<br><br>This copies the nb/intel/haswell/Kconfig to not include an mrc.bin by<br>default.<br><br>Change-Id: I2e151a66abc6dab710abdbb92c0c28884d88912e<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/soc/intel/baytrail/Kconfig<br>1 file changed, 8 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/27140/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig</span><br><span>index 1f7e21e..b4dc823 100644</span><br><span>--- a/src/soc/intel/baytrail/Kconfig</span><br><span>+++ b/src/soc/intel/baytrail/Kconfig</span><br><span>@@ -67,22 +67,20 @@</span><br><span> default 0x100000</span><br><span> </span><br><span> config HAVE_MRC</span><br><span style="color: hsl(0, 100%, 40%);">- bool "Add a Memory Reference Code binary"</span><br><span style="color: hsl(0, 100%, 40%);">- default y</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Add a System Agent binary"</span><br><span> help</span><br><span style="color: hsl(0, 100%, 40%);">- Select this option to add a blob containing</span><br><span style="color: hsl(0, 100%, 40%);">- memory reference code.</span><br><span style="color: hsl(120, 100%, 40%);">+ Select this option to add a System Agent binary to</span><br><span style="color: hsl(120, 100%, 40%);">+ the resulting coreboot image.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> Note: Without this binary coreboot will not work</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-if HAVE_MRC</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> config MRC_FILE</span><br><span style="color: hsl(0, 100%, 40%);">- string "Intel memory refeference code path and filename"</span><br><span style="color: hsl(0, 100%, 40%);">- default "3rdparty/blobs/northbridge/intel/sandybridge/systemagent-r6.bin"</span><br><span style="color: hsl(120, 100%, 40%);">+ string "Intel System Agent path and filename"</span><br><span style="color: hsl(120, 100%, 40%);">+ depends on HAVE_MRC</span><br><span style="color: hsl(120, 100%, 40%);">+ default "mrc.bin"</span><br><span> help</span><br><span> The path and filename of the file to use as System Agent</span><br><span style="color: hsl(0, 100%, 40%);">- binary. Note that this points to the sandybridge binary file</span><br><span style="color: hsl(0, 100%, 40%);">- which is will not work, but it serves its purpose to do builds.</span><br><span style="color: hsl(120, 100%, 40%);">+ binary.</span><br><span> </span><br><span> config MRC_BIN_ADDRESS</span><br><span> hex</span><br><span>@@ -92,8 +90,6 @@</span><br><span> bool "Enable MRC RMT training + debug prints"</span><br><span> default n</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-endif # HAVE_MRC</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> # Cache As RAM region layout:</span><br><span> #</span><br><span> # +-------------+ DCACHE_RAM_BASE + DCACHE_RAM_SIZE + DCACHE_RAM_MRC_VAR_SIZE</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27140">change 27140</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27140"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2e151a66abc6dab710abdbb92c0c28884d88912e </div>
<div style="display:none"> Gerrit-Change-Number: 27140 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>