<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27144">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile: Add bincompare target<br><br>Change-Id: I7d2dfc7a2e34851fe01a9d72e0d90db00a284eaf<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M Makefile<br>A Makefile.compare<br>2 files changed, 30 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/44/27144/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile b/Makefile</span><br><span>index a25deb6..8b9ff08 100644</span><br><span>--- a/Makefile</span><br><span>+++ b/Makefile</span><br><span>@@ -3,7 +3,7 @@</span><br><span> DESTDIR ?= dest</span><br><span> </span><br><span> name ?= hw</span><br><span style="color: hsl(0, 100%, 40%);">-hw-install = Makefile Makefile.proof debug.adc gnat.adc spark.adc</span><br><span style="color: hsl(120, 100%, 40%);">+hw-install = Makefile Makefile.compare Makefile.proof debug.adc gnat.adc spark.adc</span><br><span> </span><br><span> top := $(CURDIR)</span><br><span> cnf := .config</span><br><span>@@ -32,6 +32,7 @@</span><br><span>   $(eval -include $($(dep)-dir)/config))</span><br><span> -include $(cnf)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+include $(libhw-dir)/Makefile.compare</span><br><span> include $(libhw-dir)/Makefile.proof</span><br><span> </span><br><span> ifeq ($(DEBUG),1)</span><br><span>diff --git a/Makefile.compare b/Makefile.compare</span><br><span>new file mode 100644</span><br><span>index 0000000..7a707c8</span><br><span>--- /dev/null</span><br><span>+++ b/Makefile.compare</span><br><span>@@ -0,0 +1,28 @@</span><br><span style="color: hsl(120, 100%, 40%);">+bincompare-configs := $(wildcard configs/*)</span><br><span style="color: hsl(120, 100%, 40%);">+bincompare-targets := $(addprefix bincompare-,$(notdir $(bincompare-configs)))</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+$(bincompare-targets): bincompare-%: configs/%</span><br><span style="color: hsl(120, 100%, 40%);">+    $(MAKE) CFLAGS=-Os obj=$(objprefix)/$* cnf=configs/$*</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+bincompare: ref := HEAD^</span><br><span style="color: hsl(120, 100%, 40%);">+bincompare:</span><br><span style="color: hsl(120, 100%, 40%);">+        rm -rf bincmp.ref/ bincmp.head/</span><br><span style="color: hsl(120, 100%, 40%);">+       [ "$$(git rev-parse $(ref))" = "$$(git rev-parse HEAD)" ] || {      \</span><br><span style="color: hsl(120, 100%, 40%);">+     git checkout $(ref) &&                                          \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(MAKE) objprefix=bincmp.ref $(bincompare-targets) ||           \</span><br><span style="color: hsl(120, 100%, 40%);">+                             { git checkout HEAD@{1}; exit 1; } &&   \</span><br><span style="color: hsl(120, 100%, 40%);">+     git checkout HEAD@{1} &&                                        \</span><br><span style="color: hsl(120, 100%, 40%);">+     $(MAKE) objprefix=bincmp.head $(bincompare-targets) &&          \</span><br><span style="color: hsl(120, 100%, 40%);">+     res=0 &&                                                        \</span><br><span style="color: hsl(120, 100%, 40%);">+     for t in $(patsubst bincompare-%,%,$(bincompare-targets));      \</span><br><span style="color: hsl(120, 100%, 40%);">+     do                                                              \</span><br><span style="color: hsl(120, 100%, 40%);">+             b=$$t/$(notdir $(binary));                              \</span><br><span style="color: hsl(120, 100%, 40%);">+             r=$$(objdump -d bincmp.ref/$$b | grep -v bincmp);       \</span><br><span style="color: hsl(120, 100%, 40%);">+             h=$$(objdump -d bincmp.head/$$b | grep -v bincmp);      \</span><br><span style="color: hsl(120, 100%, 40%);">+             if [ "$$r" != "$$h" ]; then                         \</span><br><span style="color: hsl(120, 100%, 40%);">+                     printf "Binaries for %s differ.\n" "$$t";   \</span><br><span style="color: hsl(120, 100%, 40%);">+                     res=1;                                          \</span><br><span style="color: hsl(120, 100%, 40%);">+             fi;                                                     \</span><br><span style="color: hsl(120, 100%, 40%);">+     done; exit $$res; }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+.PHONY: bincompare $(bincompare-targets)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27144">change 27144</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27144"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libhwbase </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7d2dfc7a2e34851fe01a9d72e0d90db00a284eaf </div>
<div style="display:none"> Gerrit-Change-Number: 27144 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>