<p>Caveh Jalali would like caveh jalali to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/27127">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">atlas: enable touchscreen<br><br>This adds the necessary config to enable touchscreen sensor in linux.<br><br>BUG=b:110286344,b:110286345<br>BRANCH=none<br>TEST=verified touch functionality using eval board<br><br>Change-Id: I21efafda3f2ae1dcea19e44f8d66f6dfaac1bb12<br>Signed-off-by: Caveh Jalali <caveh@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/atlas/devicetree.cb<br>M src/mainboard/google/poppy/variants/atlas/gpio.c<br>2 files changed, 14 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/27127/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>index 2789632..2de96a9 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb</span><br><span>@@ -258,7 +258,18 @@</span><br><span>             device pci 14.0 on  end # USB xHCI</span><br><span>           device pci 14.1 on  end # USB xDCI (OTG)</span><br><span>             device pci 14.2 on  end # Thermal Subsystem</span><br><span style="color: hsl(0, 100%, 40%);">-             device pci 15.0 on  end # I2C #0 - Touchscreen</span><br><span style="color: hsl(120, 100%, 40%);">+                device pci 15.0 on</span><br><span style="color: hsl(120, 100%, 40%);">+                    chip drivers/i2c/hid</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "generic.hid" = ""ACPI0C50""</span><br><span style="color: hsl(120, 100%, 40%);">+                           register "generic.desc" = ""STM Touchscreen""</span><br><span style="color: hsl(120, 100%, 40%);">+                           register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "generic.speed" = "I2C_SPEED_FAST"</span><br><span style="color: hsl(120, 100%, 40%);">+                                register "generic.probed" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                                register "generic.has_power_resource" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "hid_desc_reg_offset" = "0xab"</span><br><span style="color: hsl(120, 100%, 40%);">+                           device i2c 0x49 on end</span><br><span style="color: hsl(120, 100%, 40%);">+                        end</span><br><span style="color: hsl(120, 100%, 40%);">+           end # I2C #0 - Touchscreen</span><br><span>           device pci 15.1 off end # I2C #1</span><br><span>             device pci 15.2 on</span><br><span>                   chip drivers/i2c/hid</span><br><span>diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>index acaa225..3a7b722 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c</span><br><span>@@ -156,7 +156,7 @@</span><br><span>      /* C21 : UART2_TXD ==> PCHTX_SERVORX_UART */</span><br><span>      PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1),</span><br><span>        /* C22 : UART2_RTS# ==> EN_PP3300_DX_TOUCHSCREEN */</span><br><span style="color: hsl(0, 100%, 40%);">-  PAD_CFG_GPO(GPP_C22, 0, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+        PAD_CFG_GPO(GPP_C22, 1, DEEP),</span><br><span>       /* C23 : UART2_CTS# ==> PCH_WP */</span><br><span>         PAD_CFG_GPI_GPIO_DRIVER(GPP_C23, 20K_PU, DEEP),</span><br><span> </span><br><span>@@ -232,7 +232,7 @@</span><br><span>    /* E10 : USB2_OC1# ==> USB_C1_OC_ODL */</span><br><span>   PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1),</span><br><span>        /* E11 : USB2_OC2# ==> TOUCHSCREEN_RESET_L */</span><br><span style="color: hsl(0, 100%, 40%);">-        PAD_CFG_GPO(GPP_E11, 0, DEEP),</span><br><span style="color: hsl(120, 100%, 40%);">+        PAD_CFG_GPO(GPP_E11, 1, DEEP),</span><br><span>       /* E12 : USB2_OC3# ==> NC */</span><br><span>      PAD_CFG_NC(GPP_E12),</span><br><span>         /* E13 : DDPB_HPD0 ==> USB_C1_DP_HPD */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27127">change 27127</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27127"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I21efafda3f2ae1dcea19e44f8d66f6dfaac1bb12 </div>
<div style="display:none"> Gerrit-Change-Number: 27127 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: caveh jalali <caveh@chromium.org> </div>