<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27122">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/*/*: Harmonise FD and devicetree on boards featuring ICH7<br><br>On some boards the devicetree and Function Disable register did not<br>match. In this case the FD values are put in the devicetree as these<br>were the values that were actually used in practice.<br><br>A complete devicetree will make it easier to automatically disable<br>devices in ramstage.<br><br>Change-Id: I1692ca5f490ea84e2fc520d3f66044ad7514f76e<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/apple/macbook21/devicetree.cb<br>M src/mainboard/asrock/g41c-gs/devicetree.cb<br>M src/mainboard/asus/p5gc-mx/devicetree.cb<br>M src/mainboard/foxconn/g41s-k/devicetree.cb<br>M src/mainboard/getac/p470/devicetree.cb<br>M src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb<br>M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c<br>M src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb<br>M src/mainboard/ibase/mb899/devicetree.cb<br>M src/mainboard/intel/d510mo/devicetree.cb<br>M src/mainboard/intel/d945gclf/devicetree.cb<br>M src/mainboard/kontron/986lcd-m/devicetree.cb<br>M src/mainboard/lenovo/t60/devicetree.cb<br>M src/mainboard/lenovo/x60/devicetree.cb<br>M src/mainboard/lenovo/z61t/devicetree.cb<br>M src/mainboard/roda/rk886ex/devicetree.cb<br>16 files changed, 92 insertions(+), 57 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/27122/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb</span><br><span>index b6e61eb..898aae4 100644</span><br><span>--- a/src/mainboard/apple/macbook21/devicetree.cb</span><br><span>+++ b/src/mainboard/apple/macbook21/devicetree.cb</span><br><span>@@ -83,6 +83,11 @@</span><br><span> end</span><br><span> device pci 1c.0 on end # Ethernet</span><br><span> device pci 1c.1 on end # Atheros WLAN</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 off end # PCIe #3</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 off end # PCIe #4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe #5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe #6</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> device pci 1d.0 on # USB UHCI</span><br><span> subsystemid 0x8086 0x7270</span><br><span> end</span><br><span>@@ -98,6 +103,9 @@</span><br><span> device pci 1d.7 on # USB2 EHCI</span><br><span> subsystemid 0x8086 0x7270</span><br><span> end</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # PCI-LPC bridge</span><br><span> subsystemid 0x8086 0x7270</span><br><span> end</span><br><span>diff --git a/src/mainboard/asrock/g41c-gs/devicetree.cb b/src/mainboard/asrock/g41c-gs/devicetree.cb</span><br><span>index f58fae7..1e22be6 100644</span><br><span>--- a/src/mainboard/asrock/g41c-gs/devicetree.cb</span><br><span>+++ b/src/mainboard/asrock/g41c-gs/devicetree.cb</span><br><span>@@ -62,6 +62,8 @@</span><br><span> device pci 1c.1 on end # PCIe 2</span><br><span> device pci 1c.2 off end # PCIe 3</span><br><span> device pci 1c.3 off end # PCIe 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe 6</span><br><span> device pci 1d.0 on # USB</span><br><span> subsystemid 0x1849 0x27c8</span><br><span> end</span><br><span>@@ -78,6 +80,8 @@</span><br><span> subsystemid 0x1849 0x27cc</span><br><span> end</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # ISA bridge</span><br><span> subsystemid 0x1849 0x27b8</span><br><span> chip superio/nuvoton/nct6776</span><br><span>@@ -147,9 +151,6 @@</span><br><span> device i2c 69 on end</span><br><span> end</span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.4 off end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.5 off end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.6 off end</span><br><span> end</span><br><span> end</span><br><span> end</span><br><span>diff --git a/src/mainboard/asus/p5gc-mx/devicetree.cb b/src/mainboard/asus/p5gc-mx/devicetree.cb</span><br><span>index cefa711..642f1ee 100644</span><br><span>--- a/src/mainboard/asus/p5gc-mx/devicetree.cb</span><br><span>+++ b/src/mainboard/asus/p5gc-mx/devicetree.cb</span><br><span>@@ -62,10 +62,10 @@</span><br><span> end</span><br><span> device pci 1c.0 on end # PCIe</span><br><span> device pci 1c.1 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.2 off end # PCIe port 3</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 off end # PCIe port 3</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span> device pci 1d.0 on # USB UHCI</span><br><span> ioapic_irq 2 INTA 0x10</span><br><span> end</span><br><span>@@ -82,6 +82,8 @@</span><br><span> ioapic_irq 2 INTA 0x10</span><br><span> end</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> </span><br><span> device pci 1f.0 on # LPC bridge</span><br><span> ioapic_irq 2 INTA 0x10</span><br><span>diff --git a/src/mainboard/foxconn/g41s-k/devicetree.cb b/src/mainboard/foxconn/g41s-k/devicetree.cb</span><br><span>index e57436a..6a5089a 100644</span><br><span>--- a/src/mainboard/foxconn/g41s-k/devicetree.cb</span><br><span>+++ b/src/mainboard/foxconn/g41s-k/devicetree.cb</span><br><span>@@ -66,6 +66,8 @@</span><br><span> end</span><br><span> device pci 1c.2 off end # PCIe 3</span><br><span> device pci 1c.3 off end # PCIe 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe 6</span><br><span> device pci 1d.0 on # USB</span><br><span> subsystemid 0x105b 0x0dda</span><br><span> end</span><br><span>@@ -82,6 +84,8 @@</span><br><span> subsystemid 0x105b 0x0dda</span><br><span> end</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # ISA bridge</span><br><span> subsystemid 0x105b 0x0dda</span><br><span> chip superio/ite/it8720f # Super I/O</span><br><span>@@ -181,9 +185,6 @@</span><br><span> device pci 1f.3 on # SMbus</span><br><span> subsystemid 0x105b 0x0dda</span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.4 off end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.5 off end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.6 off end</span><br><span> end</span><br><span> end</span><br><span> end</span><br><span>diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb</span><br><span>index ad3b625..a81ef3a 100644</span><br><span>--- a/src/mainboard/getac/p470/devicetree.cb</span><br><span>+++ b/src/mainboard/getac/p470/devicetree.cb</span><br><span>@@ -68,8 +68,8 @@</span><br><span> device pci 1c.1 on end # PCIe port 2</span><br><span> device pci 1c.2 on end # PCIe port 3</span><br><span> device pci 1c.3 on end # PCIe port 4</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span> device pci 1d.0 on end # USB UHCI</span><br><span> device pci 1d.1 on end # USB UHCI</span><br><span> device pci 1d.2 on end # USB UHCI</span><br><span>@@ -80,8 +80,8 @@</span><br><span> </span><br><span> end</span><br><span> end # PCI bridge</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.3 off end # AC'97 Modem</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # LPC bridge</span><br><span> chip superio/smsc/fdc37n972</span><br><span> device pnp 2e.0 off # Floppy</span><br><span>@@ -143,7 +143,7 @@</span><br><span> end</span><br><span> </span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.1 on end # IDE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1f.1 off end # IDE</span><br><span> device pci 1f.2 on end # SATA</span><br><span> device pci 1f.3 on end # SMBus</span><br><span> end</span><br><span>diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb b/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb</span><br><span>index 6bdc134..7ed4d19 100644</span><br><span>--- a/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb</span><br><span>+++ b/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb</span><br><span>@@ -86,10 +86,10 @@</span><br><span> end</span><br><span> device pci 1c.0 on end # PCIe</span><br><span> device pci 1c.1 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.2 off end # PCIe port 3</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 off end # PCIe port 3</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span> device pci 1d.0 on # USB UHCI</span><br><span> ioapic_irq 2 INTA 0x10</span><br><span> end</span><br><span>@@ -106,6 +106,8 @@</span><br><span> ioapic_irq 2 INTA 0x10</span><br><span> end</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> </span><br><span> device pci 1f.0 on # LPC bridge</span><br><span> ioapic_irq 2 INTA 0x10</span><br><span>diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c</span><br><span>index 926a5a7..f30066e 100644</span><br><span>--- a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c</span><br><span>+++ b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c</span><br><span>@@ -87,7 +87,8 @@</span><br><span> RCBA8(OIC) = 0x03;</span><br><span> </span><br><span> /* Disable unused devices */</span><br><span style="color: hsl(0, 100%, 40%);">- RCBA32(FD) = 0x003c0061;</span><br><span style="color: hsl(120, 100%, 40%);">+ RCBA32(FD) = FD_PCIE6 | FD_PCIE5 | FD_PCIE4 | FD_PCIE3</span><br><span style="color: hsl(120, 100%, 40%);">+ | FD_ACMOD | FD_ACAUD | 1;</span><br><span> </span><br><span> /* Enable PCIe Root Port Clock Gate */</span><br><span> RCBA32(CG) = 0x00000001;</span><br><span>diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb b/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb</span><br><span>index d948398..9f92d2a 100644</span><br><span>--- a/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb</span><br><span>+++ b/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb</span><br><span>@@ -62,7 +62,9 @@</span><br><span> end</span><br><span> end</span><br><span> device pci 1c.2 on end # PCIe 3</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.3 on end # PCIe 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 off end # PCIe 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe 6</span><br><span> device pci 1d.0 on # USB</span><br><span> subsystemid 0x1458 0x5004</span><br><span> end</span><br><span>@@ -79,6 +81,8 @@</span><br><span> subsystemid 0x1458 0x5006</span><br><span> end</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # ISA bridge</span><br><span> subsystemid 0x1458 0x5001</span><br><span> chip superio/ite/it8718f # Super I/O</span><br><span>@@ -164,9 +168,6 @@</span><br><span> device pci 1f.3 on # SMbus</span><br><span> subsystemid 0x1458 0x5001</span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.4 off end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.5 off end</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.6 off end</span><br><span> end</span><br><span> end</span><br><span> end</span><br><span>diff --git a/src/mainboard/ibase/mb899/devicetree.cb b/src/mainboard/ibase/mb899/devicetree.cb</span><br><span>index c63e5d6..3544c96 100644</span><br><span>--- a/src/mainboard/ibase/mb899/devicetree.cb</span><br><span>+++ b/src/mainboard/ibase/mb899/devicetree.cb</span><br><span>@@ -45,17 +45,17 @@</span><br><span> device pci 1c.0 on end # PCIe</span><br><span> device pci 1c.1 on end # PCIe</span><br><span> device pci 1c.2 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 on end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 on end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 on end # PCIe port 6</span><br><span> device pci 1d.0 on end # USB UHCI</span><br><span> device pci 1d.1 on end # USB UHCI</span><br><span> device pci 1d.2 on end # USB UHCI</span><br><span> device pci 1d.3 on end # USB UHCI</span><br><span> device pci 1d.7 on end # USB2 EHCI</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.3 off end # AC'97 Modem</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 on end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 on end # AC'97 Modem</span><br><span> device pci 1f.0 on # LPC bridge</span><br><span> chip superio/winbond/w83627ehg</span><br><span> device pnp 4e.0 off end # Floppy</span><br><span>@@ -108,7 +108,6 @@</span><br><span> device pci 1f.1 on end # IDE</span><br><span> device pci 1f.2 on end # SATA</span><br><span> device pci 1f.3 on end # SMBus</span><br><span style="color: hsl(0, 100%, 40%);">- # device pci 1f.4 off end # Realtek ID Codec</span><br><span> end # chip southbridge/intel/i82801gx</span><br><span> </span><br><span> end # device domain0</span><br><span>diff --git a/src/mainboard/intel/d510mo/devicetree.cb b/src/mainboard/intel/d510mo/devicetree.cb</span><br><span>index 4733038..782adf4 100644</span><br><span>--- a/src/mainboard/intel/d510mo/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/d510mo/devicetree.cb</span><br><span>@@ -49,12 +49,15 @@</span><br><span> device pci 1c.1 on end # PCIe 2</span><br><span> device pci 1c.2 on end # PCIe 3</span><br><span> device pci 1c.3 on end # PCIe 4</span><br><span style="color: hsl(120, 100%, 40%);">+ # (PCIe 5 and 6 not on nm10?)</span><br><span> device pci 1d.0 on end # USB</span><br><span> device pci 1d.1 on end # USB</span><br><span> device pci 1d.2 on end # USB</span><br><span> device pci 1d.3 on end # USB</span><br><span> device pci 1d.7 on end # USB</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ #device pci 1e.2 off end # AC'97 Audio (not on nm10?)</span><br><span style="color: hsl(120, 100%, 40%);">+ #device pci 1e.3 off end # AC'97 Modem (not on nm10?)</span><br><span> device pci 1f.0 on # ISA bridge</span><br><span> chip superio/winbond/w83627thg # Super I/O</span><br><span> device pnp 4e.0 off end # Floppy</span><br><span>diff --git a/src/mainboard/intel/d945gclf/devicetree.cb b/src/mainboard/intel/d945gclf/devicetree.cb</span><br><span>index d9eda6b..eaa26ef 100644</span><br><span>--- a/src/mainboard/intel/d945gclf/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/d945gclf/devicetree.cb</span><br><span>@@ -55,20 +55,20 @@</span><br><span> register "p_cnt_throttling_supported" = "0"</span><br><span> </span><br><span> device pci 1b.0 on end # High Definition Audio</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.0 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.1 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.2 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.0 on end # PCIe port 1</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.1 off end # PCIe port 2</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 on end # PCIe port 3</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 on end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span> device pci 1d.0 on end # USB UHCI</span><br><span> device pci 1d.1 on end # USB UHCI</span><br><span> device pci 1d.2 on end # USB UHCI</span><br><span> device pci 1d.3 on end # USB UHCI</span><br><span> device pci 1d.7 on end # USB2 EHCI</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.3 off end # AC'97 Modem</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # LPC bridge</span><br><span> chip superio/smsc/lpc47m15x</span><br><span> device pnp 2e.0 off # Floppy</span><br><span>@@ -100,10 +100,9 @@</span><br><span> end</span><br><span> end</span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1f.1 off end # IDE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1f.1 off end # IDE</span><br><span> device pci 1f.2 on end # SATA</span><br><span> device pci 1f.3 on end # SMBus</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1f.4 off end # Realtek ID Codec</span><br><span> end</span><br><span> end</span><br><span> end</span><br><span>diff --git a/src/mainboard/kontron/986lcd-m/devicetree.cb b/src/mainboard/kontron/986lcd-m/devicetree.cb</span><br><span>index c768b64..06f29e0 100644</span><br><span>--- a/src/mainboard/kontron/986lcd-m/devicetree.cb</span><br><span>+++ b/src/mainboard/kontron/986lcd-m/devicetree.cb</span><br><span>@@ -44,17 +44,17 @@</span><br><span> device pci 1c.0 on end # PCIe</span><br><span> device pci 1c.1 on end # PCIe</span><br><span> device pci 1c.2 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span> device pci 1d.0 on end # USB UHCI</span><br><span> device pci 1d.1 on end # USB UHCI</span><br><span> device pci 1d.2 on end # USB UHCI</span><br><span> device pci 1d.3 on end # USB UHCI</span><br><span> device pci 1d.7 on end # USB2 EHCI</span><br><span> device pci 1e.0 on end # PCI bridge</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.3 off end # AC'97 Modem</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # LPC bridge</span><br><span> chip superio/winbond/w83627thg</span><br><span> device pnp 2e.0 off # Floppy</span><br><span>@@ -128,10 +128,9 @@</span><br><span> end</span><br><span> </span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1f.1 off end # IDE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1f.1 off end # IDE</span><br><span> device pci 1f.2 on end # SATA</span><br><span> device pci 1f.3 on end # SMBus</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1f.4 off end # Realtek ID Codec</span><br><span> end</span><br><span> end</span><br><span> end</span><br><span>diff --git a/src/mainboard/lenovo/t60/devicetree.cb b/src/mainboard/lenovo/t60/devicetree.cb</span><br><span>index 053b9d3..7b1721e 100644</span><br><span>--- a/src/mainboard/lenovo/t60/devicetree.cb</span><br><span>+++ b/src/mainboard/lenovo/t60/devicetree.cb</span><br><span>@@ -90,6 +90,11 @@</span><br><span> subsystemid 0x17aa 0x2001</span><br><span> end</span><br><span> device pci 1c.1 on end # WLAN</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 on end # PCIe port 3</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 on end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> device pci 1d.0 on # USB UHCI</span><br><span> subsystemid 0x17aa 0x200a</span><br><span> end</span><br><span>@@ -115,6 +120,8 @@</span><br><span> </span><br><span> end</span><br><span> end</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # PCI-LPC bridge</span><br><span> subsystemid 0x17aa 0x2009</span><br><span> chip ec/lenovo/pmh7</span><br><span>diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb</span><br><span>index da9bff7..2a60b87 100644</span><br><span>--- a/src/mainboard/lenovo/x60/devicetree.cb</span><br><span>+++ b/src/mainboard/lenovo/x60/devicetree.cb</span><br><span>@@ -82,6 +82,11 @@</span><br><span> end</span><br><span> device pci 1c.0 on end # Ethernet</span><br><span> device pci 1c.1 on end # Atheros WLAN</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 on end # PCIe port 3</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 on end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> device pci 1d.0 on # USB UHCI</span><br><span> subsystemid 0x17aa 0x200a</span><br><span> end</span><br><span>@@ -97,6 +102,9 @@</span><br><span> device pci 1d.7 on # USB2 EHCI</span><br><span> subsystemid 0x17aa 0x200b</span><br><span> end</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.0 on end # PCI Bridge</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # PCI-LPC bridge</span><br><span> subsystemid 0x17aa 0x2009</span><br><span> chip ec/lenovo/pmh7</span><br><span>diff --git a/src/mainboard/lenovo/z61t/devicetree.cb b/src/mainboard/lenovo/z61t/devicetree.cb</span><br><span>index 1c60e6b..92bf3ce 100644</span><br><span>--- a/src/mainboard/lenovo/z61t/devicetree.cb</span><br><span>+++ b/src/mainboard/lenovo/z61t/devicetree.cb</span><br><span>@@ -97,6 +97,9 @@</span><br><span> device pci 1c.3 on # PCI Express Port 4</span><br><span> subsystemid 0x17aa 0x2011</span><br><span> end</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> device pci 1d.0 on # USB UHCI</span><br><span> subsystemid 0x17aa 0x200a</span><br><span> end</span><br><span>@@ -122,6 +125,8 @@</span><br><span> </span><br><span> end</span><br><span> end</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # PCI-LPC bridge</span><br><span> subsystemid 0x17aa 0x2009</span><br><span> chip ec/lenovo/pmh7</span><br><span>diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb</span><br><span>index bb057f1..e3bcc5b 100644</span><br><span>--- a/src/mainboard/roda/rk886ex/devicetree.cb</span><br><span>+++ b/src/mainboard/roda/rk886ex/devicetree.cb</span><br><span>@@ -64,12 +64,12 @@</span><br><span> register "sata_ahci" = "0x0"</span><br><span> </span><br><span> device pci 1b.0 on end # High Definition Audio</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.0 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.1 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.2 on end # PCIe</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.3 off end # PCIe port 4</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1c.5 off end # PCIe port 6</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.0 on end # PCIe port 1</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.1 off end # PCIe port 2</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 off end # PCIe port 3</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.3 on end # PCIe port 4</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.4 off end # PCIe port 5</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.5 off end # PCIe port 6</span><br><span> device pci 1d.0 on end # USB UHCI</span><br><span> device pci 1d.1 on end # USB UHCI</span><br><span> device pci 1d.2 on end # USB UHCI</span><br><span>@@ -84,8 +84,8 @@</span><br><span> device pci 3.3 off end # smartcard</span><br><span> end</span><br><span> end # PCI bridge</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1e.3 off end # AC'97 Modem</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.2 off end # AC'97 Audio</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1e.3 off end # AC'97 Modem</span><br><span> device pci 1f.0 on # LPC bridge</span><br><span> chip superio/smsc/lpc47n227</span><br><span> device pnp 2e.1 on # Parallel port</span><br><span>@@ -115,10 +115,9 @@</span><br><span> end</span><br><span> </span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1f.1 off end # IDE</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1f.1 off end # IDE</span><br><span> device pci 1f.2 on end # SATA</span><br><span> device pci 1f.3 on end # SMBus</span><br><span style="color: hsl(0, 100%, 40%);">- #device pci 1f.4 off end # Realtek ID Codec</span><br><span> end</span><br><span> end</span><br><span> end</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27122">change 27122</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27122"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1692ca5f490ea84e2fc520d3f66044ad7514f76e </div>
<div style="display:none"> Gerrit-Change-Number: 27122 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>