<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27115">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP]cbfstool: Add compression attribute<br><br>Add the compression attribute to stage, payload and flat payloads.<br><br>Test:<br>The compression is shown in cbfstool coreboot.rom print instead of "none".<br><br>Change-Id: I03927dcbd486602f54210a344d5cc7af2265c965<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M util/cbfstool/cbfstool.c<br>1 file changed, 38 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/27115/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c</span><br><span>index 08f2e32..2b6cb31 100644</span><br><span>--- a/util/cbfstool/cbfstool.c</span><br><span>+++ b/util/cbfstool/cbfstool.c</span><br><span>@@ -614,6 +614,19 @@</span><br><span> ret = parse_elf_to_stage(buffer, &output, param.compression,</span><br><span> offset, param.ignore_section);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ struct cbfs_file_attr_compression *attrs =</span><br><span style="color: hsl(120, 100%, 40%);">+ (struct cbfs_file_attr_compression *)</span><br><span style="color: hsl(120, 100%, 40%);">+ cbfs_add_file_attr(header,</span><br><span style="color: hsl(120, 100%, 40%);">+ CBFS_FILE_ATTR_TAG_COMPRESSION,</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(struct cbfs_file_attr_compression));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (attrs == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+ buffer_delete(buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ attrs->compression = htonl(param.compression);</span><br><span style="color: hsl(120, 100%, 40%);">+ attrs->decompressed_size = htonl(buffer_size(buffer));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> if (ret != 0)</span><br><span> return -1;</span><br><span> buffer_delete(buffer);</span><br><span>@@ -647,6 +660,18 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ struct cbfs_file_attr_compression *attrs =</span><br><span style="color: hsl(120, 100%, 40%);">+ (struct cbfs_file_attr_compression *)</span><br><span style="color: hsl(120, 100%, 40%);">+ cbfs_add_file_attr(header,</span><br><span style="color: hsl(120, 100%, 40%);">+ CBFS_FILE_ATTR_TAG_COMPRESSION,</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(struct cbfs_file_attr_compression));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (attrs == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+ buffer_delete(buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ attrs->compression = htonl(param.compression);</span><br><span style="color: hsl(120, 100%, 40%);">+ attrs->decompressed_size = htonl(buffer_size(buffer));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> buffer_delete(buffer);</span><br><span> // direct assign, no dupe.</span><br><span> memcpy(buffer, &output, sizeof(*buffer));</span><br><span>@@ -664,6 +689,19 @@</span><br><span> param.compression) != 0) {</span><br><span> return -1;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ struct cbfs_file_attr_compression *attrs =</span><br><span style="color: hsl(120, 100%, 40%);">+ (struct cbfs_file_attr_compression *)</span><br><span style="color: hsl(120, 100%, 40%);">+ cbfs_add_file_attr(header,</span><br><span style="color: hsl(120, 100%, 40%);">+ CBFS_FILE_ATTR_TAG_COMPRESSION,</span><br><span style="color: hsl(120, 100%, 40%);">+ sizeof(struct cbfs_file_attr_compression));</span><br><span style="color: hsl(120, 100%, 40%);">+ if (attrs == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+ buffer_delete(buffer);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ attrs->compression = htonl(param.compression);</span><br><span style="color: hsl(120, 100%, 40%);">+ attrs->decompressed_size = htonl(buffer_size(buffer));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> buffer_delete(buffer);</span><br><span> // direct assign, no dupe.</span><br><span> memcpy(buffer, &output, sizeof(*buffer));</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27115">change 27115</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27115"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I03927dcbd486602f54210a344d5cc7af2265c965 </div>
<div style="display:none"> Gerrit-Change-Number: 27115 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>