<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27104">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/nehalem: Fix DEVEN defines<br><br>The DEVEN defines are wrong, but weren't used at all.<br>Fix them as they are needed by the hybrid_graphics_driver and<br>use the defines instead of magic values.<br><br>Tested on Lenovo T410: The IGD turns on with the correct value.<br><br>Change-Id: Idf9fc0115de5c72f7d5d88cbb09ae1d2fee0afd0<br>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com><br>---<br>M src/northbridge/intel/nehalem/early_init.c<br>M src/northbridge/intel/nehalem/nehalem.h<br>2 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/27104/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/nehalem/early_init.c b/src/northbridge/intel/nehalem/early_init.c</span><br><span>index 319d81d..1424b91 100644</span><br><span>--- a/src/northbridge/intel/nehalem/early_init.c</span><br><span>+++ b/src/northbridge/intel/nehalem/early_init.c</span><br><span>@@ -151,7 +151,8 @@</span><br><span>        nehalem_setup_bars();</span><br><span> </span><br><span>    /* Device Enable */</span><br><span style="color: hsl(0, 100%, 40%);">-     pci_write_config32(PCI_DEV(0, 0, 0), D0F0_DEVEN, 9 | 2);</span><br><span style="color: hsl(120, 100%, 40%);">+      pci_write_config32(PCI_DEV(0, 0, 0), D0F0_DEVEN,</span><br><span style="color: hsl(120, 100%, 40%);">+                         DEVEN_IGD | DEVEN_PEG10 | DEVEN_HOST);</span><br><span> </span><br><span>        early_cpu_init();</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/nehalem/nehalem.h b/src/northbridge/intel/nehalem/nehalem.h</span><br><span>index 33df32f..bbdd290 100644</span><br><span>--- a/src/northbridge/intel/nehalem/nehalem.h</span><br><span>+++ b/src/northbridge/intel/nehalem/nehalem.h</span><br><span>@@ -69,11 +69,10 @@</span><br><span> #define D0F0_MCHBAR_HI 0x4c</span><br><span> #define D0F0_GGC 0x52</span><br><span> #define D0F0_DEVEN 0x54</span><br><span style="color: hsl(120, 100%, 40%);">+/* Note: Intel's datasheet is broken. Assume the following values are correct */</span><br><span> #define  DEVEN_PEG60   (1 << 13)</span><br><span style="color: hsl(0, 100%, 40%);">-#define  DEVEN_IGD       (1 << 4)</span><br><span style="color: hsl(0, 100%, 40%);">-#define  DEVEN_PEG10      (1 << 3)</span><br><span style="color: hsl(0, 100%, 40%);">-#define  DEVEN_PEG11      (1 << 2)</span><br><span style="color: hsl(0, 100%, 40%);">-#define  DEVEN_PEG12      (1 << 1)</span><br><span style="color: hsl(120, 100%, 40%);">+#define  DEVEN_IGD      (1 << 3)</span><br><span style="color: hsl(120, 100%, 40%);">+#define  DEVEN_PEG10    (1 << 1)</span><br><span> #define  DEVEN_HOST   (1 << 0)</span><br><span> #define D0F0_PCIEXBAR_LO 0x60</span><br><span> #define D0F0_PCIEXBAR_HI 0x64</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27104">change 27104</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27104"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Idf9fc0115de5c72f7d5d88cbb09ae1d2fee0afd0 </div>
<div style="display:none"> Gerrit-Change-Number: 27104 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> </div>