<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27096">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src: Use NULL instead of 0 for pointer<br><br>Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/arch/x86/exception.c<br>M src/arch/x86/mpspec.c<br>M src/arch/x86/smbios.c<br>M src/device/dram/ddr2.c<br>M src/device/oprom/x86emu/debug.c<br>M src/drivers/amd/agesa/oem_s3.c<br>M src/drivers/i2c/tpm/tis.c<br>M src/drivers/intel/fsp1_1/hob.c<br>M src/drivers/intel/fsp1_1/stage_cache.c<br>M src/drivers/intel/fsp2_0/mma_core.c<br>M src/drivers/intel/fsp2_0/stage_cache.c<br>M src/drivers/intel/i210/i210.c<br>M src/drivers/pc80/vga/vga.c<br>M src/drivers/spi/tpm/tpm.c<br>M src/drivers/xgi/common/vb_setmode.c<br>M src/ec/google/chromeec/ec.c<br>M src/lib/device_tree.c<br>M src/mainboard/google/beltino/lan.c<br>M src/mainboard/google/butterfly/mainboard.c<br>M src/mainboard/google/jecht/lan.c<br>M src/mainboard/google/poppy/variants/atlas/nhlt.c<br>M src/mainboard/google/poppy/variants/baseboard/gpio.c<br>M src/mainboard/google/poppy/variants/baseboard/nhlt.c<br>M src/mainboard/google/poppy/variants/nami/nhlt.c<br>M src/mainboard/google/poppy/variants/nautilus/nhlt.c<br>M src/mainboard/google/poppy/variants/nocturne/nhlt.c<br>M src/mainboard/google/rambi/variants/ninja/lan.c<br>M src/mainboard/google/rambi/variants/sumo/lan.c<br>M src/mainboard/google/reef/mainboard.c<br>M src/northbridge/amd/amdmct/mct/mct_d_gcc.c<br>M src/northbridge/amd/amdmct/mct/mctardk3.c<br>M src/northbridge/amd/amdmct/mct/mctardk4.c<br>M src/northbridge/amd/amdmct/mct/mctdqs_d.c<br>M src/northbridge/amd/amdmct/mct/mctpro_d.c<br>M src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.c<br>M src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c<br>M src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c<br>M src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c<br>M src/northbridge/amd/amdmct/mct_ddr3/s3utils.c<br>M src/northbridge/intel/fsp_rangeley/northbridge.c<br>M src/northbridge/intel/gm45/northbridge.c<br>M src/northbridge/intel/gm45/raminit.c<br>M src/northbridge/intel/haswell/northbridge.c<br>M src/northbridge/intel/i945/northbridge.c<br>M src/northbridge/intel/i945/rcven.c<br>M src/northbridge/intel/nehalem/raminit.c<br>M src/northbridge/intel/pineview/ram_calc.c<br>M src/northbridge/intel/pineview/raminit.c<br>M src/northbridge/intel/sandybridge/northbridge.c<br>M src/northbridge/intel/sandybridge/raminit_sandy.c<br>M src/northbridge/intel/x4x/ram_calc.c<br>M src/northbridge/intel/x4x/raminit.c<br>M src/soc/amd/stoneyridge/gpio.c<br>M src/soc/intel/broadwell/igd.c<br>M src/soc/intel/broadwell/systemagent.c<br>M src/soc/intel/common/block/acpi/acpi.c<br>56 files changed, 84 insertions(+), 84 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/27096/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c</span><br><span>index f668ffc..eb5d50d 100644</span><br><span>--- a/src/arch/x86/exception.c</span><br><span>+++ b/src/arch/x86/exception.c</span><br><span>@@ -273,7 +273,7 @@</span><br><span> char *start;</span><br><span> </span><br><span> start = *ptr;</span><br><span style="color: hsl(0, 100%, 40%);">- *value = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *value = NULL;</span><br><span> </span><br><span> while ((digit = hex(**ptr)) >= 0) {</span><br><span> *value = ((*value) << 4) | digit;</span><br><span>@@ -294,7 +294,7 @@</span><br><span> *buf++ = hexchars[ch >> 4];</span><br><span> *buf++ = hexchars[ch & 0x0f];</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- *buf = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *buf = NULL;</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c</span><br><span>index 8280171..03b54ed 100644</span><br><span>--- a/src/arch/x86/mpspec.c</span><br><span>+++ b/src/arch/x86/mpspec.c</span><br><span>@@ -487,7 +487,7 @@</span><br><span> if (!isa_bus)</span><br><span> isa_bus = &dummy;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *max_pci_bus = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *max_pci_bus = NULL;</span><br><span> highest = 0;</span><br><span> memset(buses, 0, sizeof(buses));</span><br><span> </span><br><span>diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c</span><br><span>index da1b711..eeff760 100644</span><br><span>--- a/src/arch/x86/smbios.c</span><br><span>+++ b/src/arch/x86/smbios.c</span><br><span>@@ -205,7 +205,7 @@</span><br><span> </span><br><span> for (char *p = buffer + len - 1; p >= buffer; --p) {</span><br><span> if (*p == ' ')</span><br><span style="color: hsl(0, 100%, 40%);">- *p = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *p = NULL;</span><br><span> else</span><br><span> break;</span><br><span> }</span><br><span>diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c</span><br><span>index 0d395c4..1055af1 100644</span><br><span>--- a/src/device/dram/ddr2.c</span><br><span>+++ b/src/device/dram/ddr2.c</span><br><span>@@ -741,7 +741,7 @@</span><br><span> } else if (*tclk <= TCK_200MHZ) {</span><br><span> *tclk = TCK_200MHZ;</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- *tclk = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *tclk = NULL;</span><br><span> printk(BIOS_ERR, "Too slow common tCLK found\n");</span><br><span> }</span><br><span> }</span><br><span>diff --git a/src/device/oprom/x86emu/debug.c b/src/device/oprom/x86emu/debug.c</span><br><span>index 9e216e9..ad9d9db 100644</span><br><span>--- a/src/device/oprom/x86emu/debug.c</span><br><span>+++ b/src/device/oprom/x86emu/debug.c</span><br><span>@@ -331,7 +331,7 @@</span><br><span> #if 0</span><br><span> int cmd;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *n = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *n = NULL;</span><br><span> while(*s == ' ' || *s == '\t') s++;</span><br><span> ps[*n] = *s;</span><br><span> switch (*s) {</span><br><span>diff --git a/src/drivers/amd/agesa/oem_s3.c b/src/drivers/amd/agesa/oem_s3.c</span><br><span>index 1ca6e5b..9d13302 100644</span><br><span>--- a/src/drivers/amd/agesa/oem_s3.c</span><br><span>+++ b/src/drivers/amd/agesa/oem_s3.c</span><br><span>@@ -51,8 +51,8 @@</span><br><span> *len = S3_DATA_NONVOLATILE_SIZE;</span><br><span> break;</span><br><span> default:</span><br><span style="color: hsl(0, 100%, 40%);">- *pos = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *pos = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len = NULL;</span><br><span> break;</span><br><span> }</span><br><span> }</span><br><span>diff --git a/src/drivers/i2c/tpm/tis.c b/src/drivers/i2c/tpm/tis.c</span><br><span>index 1893d16..300b244 100644</span><br><span>--- a/src/drivers/i2c/tpm/tis.c</span><br><span>+++ b/src/drivers/i2c/tpm/tis.c</span><br><span>@@ -153,7 +153,7 @@</span><br><span> int len = tpm_transmit(sendbuf, sbuf_size, recvbuf, *rbuf_len);</span><br><span> </span><br><span> if (len < 10) {</span><br><span style="color: hsl(0, 100%, 40%);">- *rbuf_len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *rbuf_len = NULL;</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/drivers/intel/fsp1_1/hob.c b/src/drivers/intel/fsp1_1/hob.c</span><br><span>index 85d0f35..e5d97a6 100644</span><br><span>--- a/src/drivers/intel/fsp1_1/hob.c</span><br><span>+++ b/src/drivers/intel/fsp1_1/hob.c</span><br><span>@@ -276,7 +276,7 @@</span><br><span> void print_hob_type_structure(u16 hob_type, void *hob_list_ptr)</span><br><span> {</span><br><span> u32 *current_hob;</span><br><span style="color: hsl(0, 100%, 40%);">- u32 *next_hob = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ u32 *next_hob = NULL;</span><br><span> u8 last_hob = 0;</span><br><span> u32 current_type;</span><br><span> const char *current_type_str;</span><br><span>diff --git a/src/drivers/intel/fsp1_1/stage_cache.c b/src/drivers/intel/fsp1_1/stage_cache.c</span><br><span>index 2d594e6..b918120 100644</span><br><span>--- a/src/drivers/intel/fsp1_1/stage_cache.c</span><br><span>+++ b/src/drivers/intel/fsp1_1/stage_cache.c</span><br><span>@@ -23,6 +23,6 @@</span><br><span> if (smm_subregion(SMM_SUBREGION_CACHE, base, size)) {</span><br><span> printk(BIOS_ERR, "ERROR: No cache SMM subregion.\n");</span><br><span> *base = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- *size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *size = NULL;</span><br><span> }</span><br><span> }</span><br><span>diff --git a/src/drivers/intel/fsp2_0/mma_core.c b/src/drivers/intel/fsp2_0/mma_core.c</span><br><span>index dfb1a1f..ad3b2cb 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/mma_core.c</span><br><span>+++ b/src/drivers/intel/fsp2_0/mma_core.c</span><br><span>@@ -23,7 +23,7 @@</span><br><span> </span><br><span> int fsp_locate_mma_results(const void **mma_hob, size_t *mma_hob_size)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *mma_hob_size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *mma_hob_size = NULL;</span><br><span> *mma_hob = fsp_find_extension_hob_by_guid(mma_results_uuid,</span><br><span> mma_hob_size);</span><br><span> </span><br><span>diff --git a/src/drivers/intel/fsp2_0/stage_cache.c b/src/drivers/intel/fsp2_0/stage_cache.c</span><br><span>index 434eae9..67e1635 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/stage_cache.c</span><br><span>+++ b/src/drivers/intel/fsp2_0/stage_cache.c</span><br><span>@@ -25,6 +25,6 @@</span><br><span> if (smm_subregion(SMM_SUBREGION_CACHE, base, size)) {</span><br><span> printk(BIOS_ERR, "ERROR: No cache SMM subregion.\n");</span><br><span> *base = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- *size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *size = NULL;</span><br><span> }</span><br><span> }</span><br><span>diff --git a/src/drivers/intel/i210/i210.c b/src/drivers/intel/i210/i210.c</span><br><span>index 2eae6a9..b6a4fda 100644</span><br><span>--- a/src/drivers/intel/i210/i210.c</span><br><span>+++ b/src/drivers/intel/i210/i210.c</span><br><span>@@ -92,7 +92,7 @@</span><br><span> return I210_READ_ERROR;</span><br><span> /* The checksum is computed in that way that after summarize all the */</span><br><span> /* data from word address 0 to 0x3f the result is 0xBABA. */</span><br><span style="color: hsl(0, 100%, 40%);">- *checksum = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *checksum = NULL;</span><br><span> for (i = 0; i < 0x3f; i++)</span><br><span> *checksum += eep_data[i];</span><br><span> *checksum = I210_TARGET_CHECKSUM - *checksum;</span><br><span>diff --git a/src/drivers/pc80/vga/vga.c b/src/drivers/pc80/vga/vga.c</span><br><span>index 6e225e9..efcd8a7 100644</span><br><span>--- a/src/drivers/pc80/vga/vga.c</span><br><span>+++ b/src/drivers/pc80/vga/vga.c</span><br><span>@@ -204,7 +204,7 @@</span><br><span> if (j < height)</span><br><span> *p = vga_font_8x16[i][j];</span><br><span> else</span><br><span style="color: hsl(0, 100%, 40%);">- *p = 0x00;</span><br><span style="color: hsl(120, 100%, 40%);">+ *p = NULL;</span><br><span> p++;</span><br><span> }</span><br><span> }</span><br><span>diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c</span><br><span>index 3206ba1..d996d12 100644</span><br><span>--- a/src/drivers/spi/tpm/tpm.c</span><br><span>+++ b/src/drivers/spi/tpm/tpm.c</span><br><span>@@ -238,7 +238,7 @@</span><br><span> car_set_var(prev_prefix, *prefix);</span><br><span> car_set_var(prev_reg, reg);</span><br><span> printk(BIOS_DEBUG, "\n%s %2.2x:", prefix, reg);</span><br><span style="color: hsl(0, 100%, 40%);">- *current_char_ptr = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *current_char_ptr = NULL;</span><br><span> }</span><br><span> </span><br><span> if ((reg != TPM_DATA_FIFO_REG) && (bytes == 4)) {</span><br><span>@@ -258,7 +258,7 @@</span><br><span> if (*current_char_ptr &&</span><br><span> !(*current_char_ptr % BYTES_PER_LINE)) {</span><br><span> printk(BIOS_DEBUG, "\n ");</span><br><span style="color: hsl(0, 100%, 40%);">- *current_char_ptr = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *current_char_ptr = NULL;</span><br><span> }</span><br><span> (*current_char_ptr)++;</span><br><span> printk(BIOS_DEBUG, " %2.2x", buffer[i]);</span><br><span>diff --git a/src/drivers/xgi/common/vb_setmode.c b/src/drivers/xgi/common/vb_setmode.c</span><br><span>index 1678b75..e47e105 100644</span><br><span>--- a/src/drivers/xgi/common/vb_setmode.c</span><br><span>+++ b/src/drivers/xgi/common/vb_setmode.c</span><br><span>@@ -4595,9 +4595,9 @@</span><br><span> static void XGI_GetTVPtrIndex2(unsigned short *tempbx, unsigned char *tempcl,</span><br><span> unsigned char *tempch, struct vb_device_info *pVBInfo)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *tempbx = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *tempcl = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *tempch = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *tempbx = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *tempcl = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *tempch = NULL;</span><br><span> </span><br><span> if (pVBInfo->TVInfo & TVSetPAL)</span><br><span> *tempbx = 1;</span><br><span>diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c</span><br><span>index 094f7ce..0cc5d79 100644</span><br><span>--- a/src/ec/google/chromeec/ec.c</span><br><span>+++ b/src/ec/google/chromeec/ec.c</span><br><span>@@ -175,7 +175,7 @@</span><br><span> if (action != EC_HOST_EVENT_GET)</span><br><span> req.value = *value;</span><br><span> else</span><br><span style="color: hsl(0, 100%, 40%);">- *value = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *value = NULL;</span><br><span> cmd.cmd_code = EC_CMD_HOST_EVENT;</span><br><span> cmd.cmd_version = 0;</span><br><span> cmd.cmd_data_in = &req;</span><br><span>@@ -207,7 +207,7 @@</span><br><span> if (action != EC_HOST_EVENT_GET)</span><br><span> req.mask = (uint32_t)*value;</span><br><span> else</span><br><span style="color: hsl(0, 100%, 40%);">- *value = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *value = NULL;</span><br><span> </span><br><span> cmd.cmd_code = hcmd;</span><br><span> cmd.cmd_version = 0;</span><br><span>diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c</span><br><span>index 0a88c1f..e424bb6 100644</span><br><span>--- a/src/lib/device_tree.c</span><br><span>+++ b/src/lib/device_tree.c</span><br><span>@@ -801,7 +801,7 @@</span><br><span> struct device_tree_property *prop;</span><br><span> </span><br><span> *data = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- *size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *size = NULL;</span><br><span> </span><br><span> list_for_each(prop, node->properties, list_node) {</span><br><span> if (!strcmp(prop->prop.name, name)) {</span><br><span>diff --git a/src/mainboard/google/beltino/lan.c b/src/mainboard/google/beltino/lan.c</span><br><span>index 140c814..a8acf72 100644</span><br><span>--- a/src/mainboard/google/beltino/lan.c</span><br><span>+++ b/src/mainboard/google/beltino/lan.c</span><br><span>@@ -74,7 +74,7 @@</span><br><span> printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);</span><br><span> </span><br><span> offset += sizeof(key); /* move to next character */</span><br><span style="color: hsl(0, 100%, 40%);">- *high_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *high_dword = NULL;</span><br><span> </span><br><span> /* Fetch the MAC address and put the octets in the correct order to</span><br><span> * be programmed.</span><br><span>@@ -93,7 +93,7 @@</span><br><span> offset += 3;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *low_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *low_dword = NULL;</span><br><span> for (i = 0; i < 2; i++) {</span><br><span> *low_dword |= (get_hex_digit(search_address + offset)</span><br><span> << (4 + (i * 8)));</span><br><span>diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c</span><br><span>index e7235ed..af1b837 100644</span><br><span>--- a/src/mainboard/google/butterfly/mainboard.c</span><br><span>+++ b/src/mainboard/google/butterfly/mainboard.c</span><br><span>@@ -87,7 +87,7 @@</span><br><span> printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);</span><br><span> </span><br><span> offset += sizeof(key); /* move to next character */</span><br><span style="color: hsl(0, 100%, 40%);">- *high_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *high_dword = NULL;</span><br><span> </span><br><span> /* Fetch the MAC address and put the octets in the correct order to</span><br><span> * be programmed.</span><br><span>@@ -106,7 +106,7 @@</span><br><span> offset += 3;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *low_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *low_dword = NULL;</span><br><span> for (i = 0; i < 2; i++) {</span><br><span> *low_dword |= (get_hex_digit((char *)(search_address + offset))</span><br><span> << (4 + (i * 8)));</span><br><span>diff --git a/src/mainboard/google/jecht/lan.c b/src/mainboard/google/jecht/lan.c</span><br><span>index 59ed111..495b0c1 100644</span><br><span>--- a/src/mainboard/google/jecht/lan.c</span><br><span>+++ b/src/mainboard/google/jecht/lan.c</span><br><span>@@ -74,7 +74,7 @@</span><br><span> printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);</span><br><span> </span><br><span> offset += sizeof(key); /* move to next character */</span><br><span style="color: hsl(0, 100%, 40%);">- *high_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *high_dword = NULL;</span><br><span> </span><br><span> /* Fetch the MAC address and put the octets in the correct order to</span><br><span> * be programmed.</span><br><span>@@ -93,7 +93,7 @@</span><br><span> offset += 3;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *low_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *low_dword = NULL;</span><br><span> for (i = 0; i < 2; i++) {</span><br><span> *low_dword |= (get_hex_digit(search_address + offset)</span><br><span> << (4 + (i * 8)));</span><br><span>diff --git a/src/mainboard/google/poppy/variants/atlas/nhlt.c b/src/mainboard/google/poppy/variants/atlas/nhlt.c</span><br><span>index 4d0fd1e..700cfc2 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/atlas/nhlt.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/atlas/nhlt.c</span><br><span>@@ -38,5 +38,5 @@</span><br><span> {</span><br><span> *oem_id = "GOOGLE";</span><br><span> *oem_table_id = "ATLASMAX";</span><br><span style="color: hsl(0, 100%, 40%);">- *oem_revision = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *oem_revision = NULL;</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>index 25202e6..7fbeebf 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>@@ -389,7 +389,7 @@</span><br><span> const struct pad_config * __weak</span><br><span> variant_sku_gpio_table(size_t *num)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *num = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *num = NULL;</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/nhlt.c b/src/mainboard/google/poppy/variants/baseboard/nhlt.c</span><br><span>index 927cb24..b5fa6a3 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/nhlt.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/nhlt.c</span><br><span>@@ -44,5 +44,5 @@</span><br><span> {</span><br><span> *oem_id = "GOOGLE";</span><br><span> *oem_table_id = "POPPYMAX";</span><br><span style="color: hsl(0, 100%, 40%);">- *oem_revision = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *oem_revision = NULL;</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nami/nhlt.c b/src/mainboard/google/poppy/variants/nami/nhlt.c</span><br><span>index c3096d4..7816d13 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/nhlt.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/nhlt.c</span><br><span>@@ -39,5 +39,5 @@</span><br><span> {</span><br><span> *oem_id = "GOOGLE";</span><br><span> *oem_table_id = "NAMIMAX";</span><br><span style="color: hsl(0, 100%, 40%);">- *oem_revision = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *oem_revision = NULL;</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nautilus/nhlt.c b/src/mainboard/google/poppy/variants/nautilus/nhlt.c</span><br><span>index 1fe3668..1b11d4c 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nautilus/nhlt.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nautilus/nhlt.c</span><br><span>@@ -39,5 +39,5 @@</span><br><span> {</span><br><span> *oem_id = "GOOGLE";</span><br><span> *oem_table_id = "NAUTILUSMAX";</span><br><span style="color: hsl(0, 100%, 40%);">- *oem_revision = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *oem_revision = NULL;</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/nhlt.c b/src/mainboard/google/poppy/variants/nocturne/nhlt.c</span><br><span>index 04a4482..9ac9399 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/nhlt.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/nhlt.c</span><br><span>@@ -34,5 +34,5 @@</span><br><span> {</span><br><span> *oem_id = "GOOGLE";</span><br><span> *oem_table_id = "NOCTURNE";</span><br><span style="color: hsl(0, 100%, 40%);">- *oem_revision = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *oem_revision = NULL;</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/rambi/variants/ninja/lan.c b/src/mainboard/google/rambi/variants/ninja/lan.c</span><br><span>index 3d08ad7..e1ce844 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/ninja/lan.c</span><br><span>+++ b/src/mainboard/google/rambi/variants/ninja/lan.c</span><br><span>@@ -73,7 +73,7 @@</span><br><span> printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);</span><br><span> </span><br><span> offset += sizeof(key); /* move to next character */</span><br><span style="color: hsl(0, 100%, 40%);">- *high_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *high_dword = NULL;</span><br><span> </span><br><span> /* Fetch the MAC address and put the octets in the correct order to</span><br><span> * be programmed.</span><br><span>@@ -92,7 +92,7 @@</span><br><span> offset += 3;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *low_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *low_dword = NULL;</span><br><span> for (i = 0; i < 2; i++) {</span><br><span> *low_dword |= (get_hex_digit(search_address + offset)</span><br><span> << (4 + (i * 8)));</span><br><span>diff --git a/src/mainboard/google/rambi/variants/sumo/lan.c b/src/mainboard/google/rambi/variants/sumo/lan.c</span><br><span>index 07fe3d9..f6059f6 100644</span><br><span>--- a/src/mainboard/google/rambi/variants/sumo/lan.c</span><br><span>+++ b/src/mainboard/google/rambi/variants/sumo/lan.c</span><br><span>@@ -73,7 +73,7 @@</span><br><span> printk(BIOS_DEBUG, "Located '%s' in VPD\n", key);</span><br><span> </span><br><span> offset += sizeof(key); /* move to next character */</span><br><span style="color: hsl(0, 100%, 40%);">- *high_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *high_dword = NULL;</span><br><span> </span><br><span> /* Fetch the MAC address and put the octets in the correct order to</span><br><span> * be programmed.</span><br><span>@@ -92,7 +92,7 @@</span><br><span> offset += 3;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *low_dword = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *low_dword = NULL;</span><br><span> for (i = 0; i < 2; i++) {</span><br><span> *low_dword |= (get_hex_digit(search_address + offset)</span><br><span> << (4 + (i * 8)));</span><br><span>diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c</span><br><span>index 6db9ac6..40c6020 100644</span><br><span>--- a/src/mainboard/google/reef/mainboard.c</span><br><span>+++ b/src/mainboard/google/reef/mainboard.c</span><br><span>@@ -34,7 +34,7 @@</span><br><span> const struct pad_config __weak</span><br><span> *variant_sku_gpio_table(size_t *num)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *num = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *num = NULL;</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/northbridge/amd/amdmct/mct/mct_d_gcc.c b/src/northbridge/amd/amdmct/mct/mct_d_gcc.c</span><br><span>index 59618f6..b440634 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct/mct_d_gcc.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct/mct_d_gcc.c</span><br><span>@@ -346,6 +346,6 @@</span><br><span> </span><br><span> u8 oemNodePresent_D(u8 Node, u8 *ret)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *ret = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *ret = NULL;</span><br><span> return 0;</span><br><span> }</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct/mctardk3.c b/src/northbridge/amd/amdmct/mct/mctardk3.c</span><br><span>index ce79a52..e8a6ea4 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct/mctardk3.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct/mctardk3.c</span><br><span>@@ -159,8 +159,8 @@</span><br><span> {</span><br><span> const u8 *p;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *AddrTmgCTL = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *ODC_CTL = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *AddrTmgCTL = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *ODC_CTL = NULL;</span><br><span> </span><br><span> if (mctGet_NVbits(NV_MAX_DIMMS) == 8) {</span><br><span> /* 8 DIMM Table */</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct/mctardk4.c b/src/northbridge/amd/amdmct/mct/mctardk4.c</span><br><span>index f7a4bee..8388249 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct/mctardk4.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct/mctardk4.c</span><br><span>@@ -84,8 +84,8 @@</span><br><span> {</span><br><span> u8 const *p;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *AddrTmgCTL = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *ODC_CTL = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *AddrTmgCTL = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *ODC_CTL = NULL;</span><br><span> *CMDmode = 1;</span><br><span> </span><br><span> // FIXME: add Ax support</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct/mctdqs_d.c b/src/northbridge/amd/amdmct/mct/mctdqs_d.c</span><br><span>index 7140007..708aed5 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct/mctdqs_d.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct/mctdqs_d.c</span><br><span>@@ -1063,7 +1063,7 @@</span><br><span> u32 dword;</span><br><span> u32 dev = pDCTstat->dev_dct;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *valid = NULL;</span><br><span> </span><br><span> </span><br><span> if (!pDCTstat->GangedMode) {</span><br><span>@@ -1122,7 +1122,7 @@</span><br><span> lo >>= 8;</span><br><span> if ((val >= lo) && (val < _4GB_RJ8)) {</span><br><span> val = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *valid = NULL;</span><br><span> goto exitGetAddr;</span><br><span> } else {</span><br><span> *valid = 1;</span><br><span>@@ -1145,7 +1145,7 @@</span><br><span> if (dword != 0) {</span><br><span> if ((val >= dword) && (val < _4GB_RJ8)) {</span><br><span> val = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *valid = NULL;</span><br><span> } else {</span><br><span> *valid = 1;</span><br><span> }</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct/mctpro_d.c b/src/northbridge/amd/amdmct/mct/mctpro_d.c</span><br><span>index 0acb6f4..b600e4b 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct/mctpro_d.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct/mctpro_d.c</span><br><span>@@ -347,7 +347,7 @@</span><br><span> }</span><br><span> }</span><br><span> if (mct_AdjustDQSPosDelay_D(pDCTstat, DQSDelay)) {</span><br><span style="color: hsl(0, 100%, 40%);">- *result = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *result = NULL;</span><br><span> }</span><br><span> }</span><br><span> }</span><br><span>@@ -386,12 +386,12 @@</span><br><span> /* Erratum #202: disable DCache scrubber for Ax parts */</span><br><span> </span><br><span> if (pDCTstat->LogicalCPUID & (AMD_DR_Ax)) {</span><br><span style="color: hsl(0, 100%, 40%);">- *scrub_request = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *scrub_request = NULL;</span><br><span> pDCTstat->ErrStatus |= 1 << SB_DCBKScrubDis;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span> void beforeInterleaveChannels_D(struct DCTStatStruc *pDCTstatA, u8 *enabled) {</span><br><span> if (pDCTstatA->LogicalCPUID & (AMD_DR_Ax))</span><br><span style="color: hsl(0, 100%, 40%);">- *enabled = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *enabled = NULL;</span><br><span> }</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.c</span><br><span>index 82911c0..ade3b01 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.c</span><br><span>@@ -291,6 +291,6 @@</span><br><span> </span><br><span> u8 oemNodePresent_D(u8 Node, u8 *ret)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *ret = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *ret = NULL;</span><br><span> return 0;</span><br><span> }</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c b/src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c</span><br><span>index d6480ab..f99bd19 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct_ddr3/mctardk6.c</span><br><span>@@ -54,8 +54,8 @@</span><br><span> u8 DATAAload, u32 *AddrTmgCTL, u32 *ODC_CTL,</span><br><span> u8 *CMDmode)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *AddrTmgCTL = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *ODC_CTL = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *AddrTmgCTL = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *ODC_CTL = NULL;</span><br><span> *CMDmode = 1;</span><br><span> </span><br><span> if (mctGet_NVbits(NV_MAX_DIMMS) == 4) {</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c</span><br><span>index f751733..86ca59e 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c</span><br><span>@@ -2336,7 +2336,7 @@</span><br><span> u32 dword;</span><br><span> u32 dev = pDCTstat->dev_dct;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *valid = NULL;</span><br><span> </span><br><span> </span><br><span> if (!pDCTstat->GangedMode) {</span><br><span>@@ -2395,7 +2395,7 @@</span><br><span> lo >>= 8;</span><br><span> if ((val >= lo) && (val < _4GB_RJ8)) {</span><br><span> val = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *valid = NULL;</span><br><span> goto exitGetAddr;</span><br><span> } else {</span><br><span> *valid = 1;</span><br><span>@@ -2418,7 +2418,7 @@</span><br><span> if (dword != 0) {</span><br><span> if ((val >= dword) && (val < _4GB_RJ8)) {</span><br><span> val = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *valid = NULL;</span><br><span> } else {</span><br><span> *valid = 1;</span><br><span> }</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c b/src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c</span><br><span>index 039a747..4ea0b95 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct_ddr3/mcttmrl.c</span><br><span>@@ -287,7 +287,7 @@</span><br><span> ch_end = Channel + 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *valid = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *valid = NULL;</span><br><span> </span><br><span> for (ch = ch_start; ch < ch_end; ch++) {</span><br><span> for (d = 0; d < 4; d++) {</span><br><span>diff --git a/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c b/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c</span><br><span>index 4100b26..857d1fa 100644</span><br><span>--- a/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c</span><br><span>+++ b/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c</span><br><span>@@ -296,7 +296,7 @@</span><br><span> if (mem_info->mct_stat.GStatus & (1 << GSB_ConfigRestored))</span><br><span> *restored = 1;</span><br><span> else</span><br><span style="color: hsl(0, 100%, 40%);">- *restored = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *restored = NULL;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.c b/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>index 27153f8..5607540 100644</span><br><span>--- a/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>+++ b/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>@@ -61,7 +61,7 @@</span><br><span> struct device *dev;</span><br><span> u32 pciexbar_reg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span> </span><br><span> dev = dev_find_slot(0, PCI_DEVFN(0, 0));</span><br><span> if (!dev)</span><br><span>diff --git a/src/northbridge/intel/gm45/northbridge.c b/src/northbridge/intel/gm45/northbridge.c</span><br><span>index 4c42513..571e7ff 100644</span><br><span>--- a/src/northbridge/intel/gm45/northbridge.c</span><br><span>+++ b/src/northbridge/intel/gm45/northbridge.c</span><br><span>@@ -38,8 +38,8 @@</span><br><span> </span><br><span> static int decode_pcie_bar(u32 *const base, u32 *const len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len = NULL;</span><br><span> </span><br><span> struct device *dev = dev_find_slot(0, PCI_DEVFN(0, 0));</span><br><span> if (!dev)</span><br><span>diff --git a/src/northbridge/intel/gm45/raminit.c b/src/northbridge/intel/gm45/raminit.c</span><br><span>index 08f954d..83491e8 100644</span><br><span>--- a/src/northbridge/intel/gm45/raminit.c</span><br><span>+++ b/src/northbridge/intel/gm45/raminit.c</span><br><span>@@ -395,7 +395,7 @@</span><br><span> else if (*clock >= 333)</span><br><span> *clock = 333;</span><br><span> else</span><br><span style="color: hsl(0, 100%, 40%);">- *clock = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *clock = NULL;</span><br><span> }</span><br><span> static void lower_clock(unsigned int *const clock)</span><br><span> {</span><br><span>diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c</span><br><span>index f61a478..01da25f 100644</span><br><span>--- a/src/northbridge/intel/haswell/northbridge.c</span><br><span>+++ b/src/northbridge/intel/haswell/northbridge.c</span><br><span>@@ -38,8 +38,8 @@</span><br><span> u32 pciexbar_reg;</span><br><span> u32 mask;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len = NULL;</span><br><span> </span><br><span> pciexbar_reg = pci_read_config32(dev, index);</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c</span><br><span>index b8a2255..d1e7381 100644</span><br><span>--- a/src/northbridge/intel/i945/northbridge.c</span><br><span>+++ b/src/northbridge/intel/i945/northbridge.c</span><br><span>@@ -31,7 +31,7 @@</span><br><span> struct device *dev;</span><br><span> u32 pciexbar_reg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span> </span><br><span> dev = dev_find_slot(0, PCI_DEVFN(0, 0));</span><br><span> if (!dev)</span><br><span>diff --git a/src/northbridge/intel/i945/rcven.c b/src/northbridge/intel/i945/rcven.c</span><br><span>index 07580d1..ec1b445 100644</span><br><span>--- a/src/northbridge/intel/i945/rcven.c</span><br><span>+++ b/src/northbridge/intel/i945/rcven.c</span><br><span>@@ -246,7 +246,7 @@</span><br><span> continue;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *fine = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *fine = NULL;</span><br><span> *mediumcoarse += 2;</span><br><span> if (*mediumcoarse <= 0x40) {</span><br><span> set_receive_enable(channel_offset, *mediumcoarse & 3,</span><br><span>diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c</span><br><span>index 6a27b57..b2179da 100644</span><br><span>--- a/src/northbridge/intel/nehalem/raminit.c</span><br><span>+++ b/src/northbridge/intel/nehalem/raminit.c</span><br><span>@@ -1853,12 +1853,12 @@</span><br><span> if (!head->length) {</span><br><span> write32(DEFAULT_HECIBAR + 0x4,</span><br><span> read32(DEFAULT_HECIBAR + 0x4) | 2);</span><br><span style="color: hsl(0, 100%, 40%);">- *packet_size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *packet_size = NULL;</span><br><span> return 0;</span><br><span> }</span><br><span> if (head->length + 4 > 4 * csr.csr.buffer_depth</span><br><span> || head->length > *packet_size) {</span><br><span style="color: hsl(0, 100%, 40%);">- *packet_size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *packet_size = NULL;</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span>@@ -1871,7 +1871,7 @@</span><br><span> packet[i++] = read32(DEFAULT_HECIBAR + 0x8);</span><br><span> *packet_size = head->length;</span><br><span> if (!csr.csr.ready)</span><br><span style="color: hsl(0, 100%, 40%);">- *packet_size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *packet_size = NULL;</span><br><span> write32(DEFAULT_HECIBAR + 0x4, read32(DEFAULT_HECIBAR + 0x4) | 4);</span><br><span> return 0;</span><br><span> }</span><br><span>diff --git a/src/northbridge/intel/pineview/ram_calc.c b/src/northbridge/intel/pineview/ram_calc.c</span><br><span>index d116709..6136183 100644</span><br><span>--- a/src/northbridge/intel/pineview/ram_calc.c</span><br><span>+++ b/src/northbridge/intel/pineview/ram_calc.c</span><br><span>@@ -27,8 +27,8 @@</span><br><span> </span><br><span> u8 decode_pciebar(u32 *const base, u32 *const len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len = NULL;</span><br><span> const pci_devfn_t dev = PCI_DEV(0,0,0);</span><br><span> u32 pciexbar = 0;</span><br><span> u32 pciexbar_reg;</span><br><span>diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c</span><br><span>index f31f032..c7fd713 100644</span><br><span>--- a/src/northbridge/intel/pineview/raminit.c</span><br><span>+++ b/src/northbridge/intel/pineview/raminit.c</span><br><span>@@ -1864,7 +1864,7 @@</span><br><span> MCHBAR16(0x58c) = (MCHBAR16(0x58c) & (u16)(~(0x3 << (bytelane*2))))</span><br><span> | (*medium << (bytelane*2));</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- *medium = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *medium = NULL;</span><br><span> (*coarse)++;</span><br><span> MCHBAR32(0x248) = (MCHBAR32(0x248) & ~0xf0000) | (*coarse << 16);</span><br><span> MCHBAR16(0x58c) = (MCHBAR16(0x58c) & (u16)(~0x3 << (bytelane*2)))</span><br><span>diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>index 8c2aaf3..3a46955 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>@@ -64,7 +64,7 @@</span><br><span> struct device *dev;</span><br><span> u32 pciexbar_reg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span> </span><br><span> dev = dev_find_slot(0, PCI_DEVFN(0, 0));</span><br><span> if (!dev)</span><br><span>diff --git a/src/northbridge/intel/sandybridge/raminit_sandy.c b/src/northbridge/intel/sandybridge/raminit_sandy.c</span><br><span>index 9fa6c7b..f64c706 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit_sandy.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit_sandy.c</span><br><span>@@ -150,7 +150,7 @@</span><br><span> } else if (*tclk <= TCK_400MHZ) {</span><br><span> *tclk = TCK_400MHZ;</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- *tclk = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *tclk = NULL;</span><br><span> }</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/northbridge/intel/x4x/ram_calc.c b/src/northbridge/intel/x4x/ram_calc.c</span><br><span>index 49afdc3..cfaa7f2 100644</span><br><span>--- a/src/northbridge/intel/x4x/ram_calc.c</span><br><span>+++ b/src/northbridge/intel/x4x/ram_calc.c</span><br><span>@@ -54,8 +54,8 @@</span><br><span> </span><br><span> u8 decode_pciebar(u32 *const base, u32 *const len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len = NULL;</span><br><span> const pci_devfn_t dev = PCI_DEV(0, 0, 0);</span><br><span> u32 pciexbar = 0;</span><br><span> u32 pciexbar_reg;</span><br><span>diff --git a/src/northbridge/intel/x4x/raminit.c b/src/northbridge/intel/x4x/raminit.c</span><br><span>index 9e649b0..bb847a3 100644</span><br><span>--- a/src/northbridge/intel/x4x/raminit.c</span><br><span>+++ b/src/northbridge/intel/x4x/raminit.c</span><br><span>@@ -253,7 +253,7 @@</span><br><span> else if (*tCLK <= TCK_400MHZ)</span><br><span> *tCLK = TCK_400MHZ;</span><br><span> else</span><br><span style="color: hsl(0, 100%, 40%);">- *tCLK = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *tCLK = NULL;</span><br><span> }</span><br><span> </span><br><span> static void select_cas_dramfreq_ddr3(struct sysinfo *s,</span><br><span>diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c</span><br><span>index 6513476..933cee6 100644</span><br><span>--- a/src/soc/amd/stoneyridge/gpio.c</span><br><span>+++ b/src/soc/amd/stoneyridge/gpio.c</span><br><span>@@ -111,7 +111,7 @@</span><br><span> switch (trigger) {</span><br><span> case GPIO_TRIGGER_LEVEL_LOW:</span><br><span> *edge = SCI_TRIGGER_LEVEL;</span><br><span style="color: hsl(0, 100%, 40%);">- *level = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *level = NULL;</span><br><span> break;</span><br><span> case GPIO_TRIGGER_LEVEL_HIGH:</span><br><span> *edge = SCI_TRIGGER_LEVEL;</span><br><span>@@ -119,7 +119,7 @@</span><br><span> break;</span><br><span> case GPIO_TRIGGER_EDGE_LOW:</span><br><span> *edge = SCI_TRIGGER_EDGE;</span><br><span style="color: hsl(0, 100%, 40%);">- *level = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *level = NULL;</span><br><span> break;</span><br><span> case GPIO_TRIGGER_EDGE_HIGH:</span><br><span> *edge = SCI_TRIGGER_EDGE;</span><br><span>diff --git a/src/soc/intel/broadwell/igd.c b/src/soc/intel/broadwell/igd.c</span><br><span>index 23c650a..583e207 100644</span><br><span>--- a/src/soc/intel/broadwell/igd.c</span><br><span>+++ b/src/soc/intel/broadwell/igd.c</span><br><span>@@ -398,7 +398,7 @@</span><br><span> *inform_pc = 1;</span><br><span> } else {</span><br><span> cdclk = GT_CDCLK_450;</span><br><span style="color: hsl(0, 100%, 40%);">- *inform_pc = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *inform_pc = NULL;</span><br><span> }</span><br><span> </span><br><span> /* Check for fixed fused clock */</span><br><span>diff --git a/src/soc/intel/broadwell/systemagent.c b/src/soc/intel/broadwell/systemagent.c</span><br><span>index afb6038..9a411ae 100644</span><br><span>--- a/src/soc/intel/broadwell/systemagent.c</span><br><span>+++ b/src/soc/intel/broadwell/systemagent.c</span><br><span>@@ -42,8 +42,8 @@</span><br><span> {</span><br><span> u32 pciexbar_reg;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- *base = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- *len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *base = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len = NULL;</span><br><span> </span><br><span> pciexbar_reg = pci_read_config32(dev, index);</span><br><span> </span><br><span>diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c</span><br><span>index 02ab886..c90d867 100644</span><br><span>--- a/src/soc/intel/common/block/acpi/acpi.c</span><br><span>+++ b/src/soc/intel/common/block/acpi/acpi.c</span><br><span>@@ -376,7 +376,7 @@</span><br><span> </span><br><span> static acpi_tstate_t *soc_get_tss_table(int *entries)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- *entries = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ *entries = NULL;</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27096">change 27096</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27096"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie9d22a4d6bab1caf61f4f89e236ae3cd2f7fb42c </div>
<div style="display:none"> Gerrit-Change-Number: 27096 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>