<p>Lijian Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27094">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/nocturne: Set camera power sequence<br><br>To make image senor working, the intended power sequence need to<br>applied.<br><br>BUG=NONE<br>TEST=NONE<br><br>Change-Id: I4833c0e303174b297c1d193495e08e55d294a717<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>---<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h<br>3 files changed, 63 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/27094/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>index c42188f..7396fc7 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>@@ -35,6 +35,34 @@</span><br><span> )</span><br><span> })</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ Method (PMON, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(RCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(PCH_RCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep(3)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (PMOF, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(RCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package (0x01) { RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package (0x01) { RCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Power resource methods for Rear Camera */</span><br><span style="color: hsl(120, 100%, 40%);">+ PowerResource (RCPR, 0, 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_ON, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ PMON()</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_OFF, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ PMOF()</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x0F)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Port0 of CAM0 is connected to port0 of CIO2 device */</span><br><span> Name (_DSD, Package () {</span><br><span> ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>index 1859aaf..029429b 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>@@ -34,6 +34,33 @@</span><br><span> )</span><br><span> })</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ Method (PMON, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(FCAM_PWR_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(PCH_FCAM_CLK_EN)</span><br><span style="color: hsl(120, 100%, 40%);">+ Sleep(3)</span><br><span style="color: hsl(120, 100%, 40%);">+ STXS(FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (PMOF, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CTXS(FCAM_RST_L)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR0, Package (0x01) { FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (_PR3, Package (0x01) { FCPR })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Power resource methods for Rear Camera */</span><br><span style="color: hsl(120, 100%, 40%);">+ PowerResource (FCPR, 0, 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_ON, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ PMON()</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_OFF, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ PMOF()</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Method (_STA, 0, Serialized) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (0x0F)</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> /* Port0 of CAM1 is connected to port1 of CIO2 device */</span><br><span> Name (_DSD, Package () {</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h</span><br><span>index 08b51b2..2afb39c 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h</span><br><span>@@ -37,4 +37,12 @@</span><br><span> /* eSPI virtual wire reporting */</span><br><span> #define EC_SCI_GPI GPE0_ESPI</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Camera Sensor config */</span><br><span style="color: hsl(120, 100%, 40%);">+#define RCAM_PWR_EN GPP_D7</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCH_RCAM_CLK_EN GPP_D14</span><br><span style="color: hsl(120, 100%, 40%);">+#define RCAM_RST_L GPP_D16</span><br><span style="color: hsl(120, 100%, 40%);">+#define FCAM_PWR_EN GPP_D8</span><br><span style="color: hsl(120, 100%, 40%);">+#define PCH_FCAM_CLK_EN GPP_D13</span><br><span style="color: hsl(120, 100%, 40%);">+#define FCAM_RST_L GPP_D15</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #endif /* BASEBOARD_GPIO_H */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27094">change 27094</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27094"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 </div>
<div style="display:none"> Gerrit-Change-Number: 27094 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>