<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27058">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gfx_test: Use GMA.Read_GTT() instead of own GTT mapping<br><br>Change-Id: Iabf26cebc91ccf62711a9a83a68b6ffd2182e3fe<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M gfxtest/hw-gfx-gma-gfx_test.adb<br>1 file changed, 7 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/58/27058/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>index 6839dc3..736b93d 100644</span><br><span>--- a/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>+++ b/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>@@ -28,21 +28,17 @@</span><br><span> </span><br><span> package Dev is new PCI.Dev (PCI.Address'(0, 2, 0));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- type GTT_PTE_Type is mod 2 ** (Config.GTT_PTE_Size * 8);</span><br><span style="color: hsl(0, 100%, 40%);">- type GTT_Registers_Type is array (GTT_Range) of GTT_PTE_Type;</span><br><span style="color: hsl(0, 100%, 40%);">- package GTT is new MMIO_Range</span><br><span style="color: hsl(0, 100%, 40%);">- (Base_Addr => 0,</span><br><span style="color: hsl(0, 100%, 40%);">- Element_T => GTT_PTE_Type,</span><br><span style="color: hsl(0, 100%, 40%);">- Index_T => GTT_Range,</span><br><span style="color: hsl(0, 100%, 40%);">- Array_T => GTT_Registers_Type);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- GTT_Backup : GTT_Registers_Type;</span><br><span style="color: hsl(120, 100%, 40%);">+ type GTT_Entry is record</span><br><span style="color: hsl(120, 100%, 40%);">+ Addr : GTT_Address_Type;</span><br><span style="color: hsl(120, 100%, 40%);">+ Valid : Boolean;</span><br><span style="color: hsl(120, 100%, 40%);">+ end record;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTT_Backup : array (GTT_Range) of GTT_Entry;</span><br><span> </span><br><span> procedure Backup_GTT</span><br><span> is</span><br><span> begin</span><br><span> for Idx in GTT_Range loop</span><br><span style="color: hsl(0, 100%, 40%);">- GTT.Read (GTT_Backup (Idx), Idx);</span><br><span style="color: hsl(120, 100%, 40%);">+ Read_GTT (GTT_Backup (Idx).Addr, GTT_Backup (Idx).Valid, Idx);</span><br><span> end loop;</span><br><span> end Backup_GTT;</span><br><span> </span><br><span>@@ -50,7 +46,7 @@</span><br><span> is</span><br><span> begin</span><br><span> for Idx in GTT_Range loop</span><br><span style="color: hsl(0, 100%, 40%);">- GTT.Write (Idx, GTT_Backup (Idx));</span><br><span style="color: hsl(120, 100%, 40%);">+ Write_GTT (Idx, GTT_Backup (Idx).Addr, GTT_Backup (Idx).Valid);</span><br><span> end loop;</span><br><span> end Restore_GTT;</span><br><span> </span><br><span>@@ -574,13 +570,6 @@</span><br><span> return;</span><br><span> end if;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Dev.Map (Res_Addr, PCI.Res0, Offset => Config.GTT_Offset);</span><br><span style="color: hsl(0, 100%, 40%);">- if Res_Addr = 0 then</span><br><span style="color: hsl(0, 100%, 40%);">- Debug.Put_Line ("Failed to map PCI resource0.");</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(0, 100%, 40%);">- end if;</span><br><span style="color: hsl(0, 100%, 40%);">- GTT.Set_Base_Address (Res_Addr);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Dev.Map (Res_Addr, PCI.Res2, WC => True);</span><br><span> if Res_Addr = 0 then</span><br><span> Debug.Put_Line ("Failed to map PCI resource2.");</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27058">change 27058</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27058"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iabf26cebc91ccf62711a9a83a68b6ffd2182e3fe </div>
<div style="display:none"> Gerrit-Change-Number: 27058 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>