<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27050">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma config: Introduce Has_Broadwell_DDI_Bufs<br><br>Change-Id: I8b17825006d35ec19ebf3e5a276aefa4d326fd73<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb<br>M common/hw-gfx-gma-config.ads.template<br>2 files changed, 20 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/50/27050/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb b/common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb</span><br><span>index baceb10..f345bc5 100644</span><br><span>--- a/common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb</span><br><span>+++ b/common/haswell/hw-gfx-gma-connectors-ddi-buffers.adb</span><br><span>@@ -125,27 +125,25 @@</span><br><span> else Config.Default_DDI_HDMI_Buffer_Translation);</span><br><span> begin</span><br><span> Trans :=</span><br><span style="color: hsl(0, 100%, 40%);">- (case Config.CPU is</span><br><span style="color: hsl(0, 100%, 40%);">- when Broadwell =></span><br><span style="color: hsl(0, 100%, 40%);">- (case Port is</span><br><span style="color: hsl(0, 100%, 40%);">- when DIGI_A =></span><br><span style="color: hsl(0, 100%, 40%);">- (if Config.EDP_Low_Voltage_Swing</span><br><span style="color: hsl(0, 100%, 40%);">- then Broadwell_Trans_EDP</span><br><span style="color: hsl(0, 100%, 40%);">- else Broadwell_Trans_DP),</span><br><span style="color: hsl(0, 100%, 40%);">- when DIGI_B .. DIGI_D => Broadwell_Trans_DP,</span><br><span style="color: hsl(0, 100%, 40%);">- when DIGI_E => Broadwell_Trans_FDI),</span><br><span style="color: hsl(0, 100%, 40%);">- when others =></span><br><span style="color: hsl(0, 100%, 40%);">- (case Port is</span><br><span style="color: hsl(0, 100%, 40%);">- when DIGI_A .. DIGI_D => Haswell_Trans_DP,</span><br><span style="color: hsl(0, 100%, 40%);">- when DIGI_E => Haswell_Trans_FDI));</span><br><span style="color: hsl(0, 100%, 40%);">- case Config.CPU is</span><br><span style="color: hsl(0, 100%, 40%);">- when Broadwell =></span><br><span style="color: hsl(0, 100%, 40%);">- Trans (18) := Broadwell_Trans_HDMI (HDMI_Trans).Trans1;</span><br><span style="color: hsl(0, 100%, 40%);">- Trans (19) := Broadwell_Trans_HDMI (HDMI_Trans).Trans2;</span><br><span style="color: hsl(0, 100%, 40%);">- when others =></span><br><span style="color: hsl(0, 100%, 40%);">- Trans (18) := Haswell_Trans_HDMI (HDMI_Trans).Trans1;</span><br><span style="color: hsl(0, 100%, 40%);">- Trans (19) := Haswell_Trans_HDMI (HDMI_Trans).Trans2;</span><br><span style="color: hsl(0, 100%, 40%);">- end case;</span><br><span style="color: hsl(120, 100%, 40%);">+ (if Config.Has_Broadwell_DDI_Bufs then</span><br><span style="color: hsl(120, 100%, 40%);">+ (case Port is</span><br><span style="color: hsl(120, 100%, 40%);">+ when DIGI_A =></span><br><span style="color: hsl(120, 100%, 40%);">+ (if Config.EDP_Low_Voltage_Swing</span><br><span style="color: hsl(120, 100%, 40%);">+ then Broadwell_Trans_EDP</span><br><span style="color: hsl(120, 100%, 40%);">+ else Broadwell_Trans_DP),</span><br><span style="color: hsl(120, 100%, 40%);">+ when DIGI_B .. DIGI_D => Broadwell_Trans_DP,</span><br><span style="color: hsl(120, 100%, 40%);">+ when DIGI_E => Broadwell_Trans_FDI)</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ (case Port is</span><br><span style="color: hsl(120, 100%, 40%);">+ when DIGI_A .. DIGI_D => Haswell_Trans_DP,</span><br><span style="color: hsl(120, 100%, 40%);">+ when DIGI_E => Haswell_Trans_FDI));</span><br><span style="color: hsl(120, 100%, 40%);">+ if Config.Has_Broadwell_DDI_Bufs then</span><br><span style="color: hsl(120, 100%, 40%);">+ Trans (18) := Broadwell_Trans_HDMI (HDMI_Trans).Trans1;</span><br><span style="color: hsl(120, 100%, 40%);">+ Trans (19) := Broadwell_Trans_HDMI (HDMI_Trans).Trans2;</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ Trans (18) := Haswell_Trans_HDMI (HDMI_Trans).Trans1;</span><br><span style="color: hsl(120, 100%, 40%);">+ Trans (19) := Haswell_Trans_HDMI (HDMI_Trans).Trans2;</span><br><span style="color: hsl(120, 100%, 40%);">+ end if;</span><br><span> end Translations;</span><br><span> </span><br><span> end HW.GFX.GMA.Connectors.DDI.Buffers;</span><br><span>diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template</span><br><span>index af55575..7548ce5 100644</span><br><span>--- a/common/hw-gfx-gma-config.ads.template</span><br><span>+++ b/common/hw-gfx-gma-config.ads.template</span><br><span>@@ -113,6 +113,7 @@</span><br><span> </span><br><span> Has_DDI_Buffer_Trans : constant Boolean := CPU >= Haswell and</span><br><span> CPU /= Broxton;</span><br><span style="color: hsl(120, 100%, 40%);">+ Has_Broadwell_DDI_Bufs : constant Boolean := CPU = Broadwell;</span><br><span> Has_Low_Voltage_Swing : constant Boolean := CPU >= Broxton;</span><br><span> Has_Iboost_Config : constant Boolean := CPU >= Skylake;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27050">change 27050</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27050"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8b17825006d35ec19ebf3e5a276aefa4d326fd73 </div>
<div style="display:none"> Gerrit-Change-Number: 27050 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>