<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27048">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma config: Introduce Has_Tertiary_Pipe<br><br>And use it instead of `Supported_Pipe`.<br><br>Change-Id: Id3c4bdaf0d6b6c6126692b00cbabaf7d3f85b4bf<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M common/hw-gfx-gma-config.ads.template<br>M common/hw-gfx-gma-config_helpers.adb<br>2 files changed, 3 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/48/27048/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template</span><br><span>index f498921..20ef5c0 100644</span><br><span>--- a/common/hw-gfx-gma-config.ads.template</span><br><span>+++ b/common/hw-gfx-gma-config.ads.template</span><br><span>@@ -44,6 +44,7 @@</span><br><span> Has_Presence_Straps : constant Boolean := CPU /= Broxton;</span><br><span> </span><br><span> ----- CPU pipe: --------</span><br><span style="color: hsl(120, 100%, 40%);">+ Has_Tertiary_Pipe : constant Boolean := CPU >= Ivybridge;</span><br><span> Disable_Trickle_Feed : constant Boolean := not</span><br><span> (CPU in Haswell .. Broadwell);</span><br><span> Pipe_Enabled_Workaround : constant Boolean := CPU = Broadwell;</span><br><span>@@ -134,15 +135,7 @@</span><br><span> ----------------------------------------------------------------------------</span><br><span> </span><br><span> Max_Pipe : constant Pipe_Index :=</span><br><span style="color: hsl(0, 100%, 40%);">- (if CPU <= Sandybridge</span><br><span style="color: hsl(0, 100%, 40%);">- then Secondary</span><br><span style="color: hsl(0, 100%, 40%);">- else Tertiary);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- type Supported_Pipe_Array is array (Pipe_Index) of Boolean;</span><br><span style="color: hsl(0, 100%, 40%);">- Supported_Pipe : constant Supported_Pipe_Array :=</span><br><span style="color: hsl(0, 100%, 40%);">- (Primary => Primary <= Max_Pipe,</span><br><span style="color: hsl(0, 100%, 40%);">- Secondary => Secondary <= Max_Pipe,</span><br><span style="color: hsl(0, 100%, 40%);">- Tertiary => Tertiary <= Max_Pipe);</span><br><span style="color: hsl(120, 100%, 40%);">+ (if Has_Tertiary_Pipe then Tertiary else Secondary);</span><br><span> </span><br><span> Valid_Port : array (Port_Type) of Boolean := (others => False)</span><br><span> with</span><br><span>diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb</span><br><span>index b7f4833..57163a6 100644</span><br><span>--- a/common/hw-gfx-gma-config_helpers.adb</span><br><span>+++ b/common/hw-gfx-gma-config_helpers.adb</span><br><span>@@ -131,7 +131,7 @@</span><br><span> is</span><br><span> begin</span><br><span> Success :=</span><br><span style="color: hsl(0, 100%, 40%);">- Config.Supported_Pipe (Pipe) and then</span><br><span style="color: hsl(120, 100%, 40%);">+ (Config.Has_Tertiary_Pipe or Pipe <= Secondary) and then</span><br><span> Config.Valid_Port (Port) and then</span><br><span> Port /= Disabled; -- Valid_Port should already cover this, but the</span><br><span> -- array is writeable, so it's hard to prove this.</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27048">change 27048</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27048"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id3c4bdaf0d6b6c6126692b00cbabaf7d3f85b4bf </div>
<div style="display:none"> Gerrit-Change-Number: 27048 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>