<p><a href="https://review.coreboot.org/27038">View Change</a></p><p>32 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h">File src/southbridge/intel/bd82x6x/pch.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@273">Patch Set #1, Line 273:</a> <code style="font-family:monospace,monospace">#define RCBA8(x) *((volatile u8 *)(DEFAULT_RCBA + x))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@274">Patch Set #1, Line 274:</a> <code style="font-family:monospace,monospace">#define RCBA16(x) *((volatile u16 *)(DEFAULT_RCBA + x))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@275">Patch Set #1, Line 275:</a> <code style="font-family:monospace,monospace">#define RCBA32(x) *((volatile u32 *)(DEFAULT_RCBA + x))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@277">Patch Set #1, Line 277:</a> <code style="font-family:monospace,monospace">#define RCBA_AND_OR(bits, x, and, or) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@278">Patch Set #1, Line 278:</a> <code style="font-family:monospace,monospace"> RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@278">Patch Set #1, Line 278:</a> <code style="font-family:monospace,monospace"> RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@324">Patch Set #1, Line 324:</a> <code style="font-family:monospace,monospace">#define RPFN_FNGET(reg,port) (((reg) >> ((port) * 4)) & 7)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@326">Patch Set #1, Line 326:</a> <code style="font-family:monospace,monospace">#define RPFN_FNSET(port,func) (((func) & 7) << ((port) * 4))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@413">Patch Set #1, Line 413:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@413">Patch Set #1, Line 413:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@413">Patch Set #1, Line 413:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@413">Patch Set #1, Line 413:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@413">Patch Set #1, Line 413:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@414">Patch Set #1, Line 414:</a> <code style="font-family:monospace,monospace"> RCBA16(x) = (((d) << DIR_IDR) | ((c) << DIR_ICR) | \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@415">Patch Set #1, Line 415:</a> <code style="font-family:monospace,monospace"> ((b) << DIR_IBR) | ((a) << DIR_IAR))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/bd82x6x/pch.h@415">Patch Set #1, Line 415:</a> <code style="font-family:monospace,monospace"> ((b) << DIR_IBR) | ((a) << DIR_IAR))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h">File src/southbridge/intel/ibexpeak/pch.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@245">Patch Set #1, Line 245:</a> <code style="font-family:monospace,monospace">#define RCBA8(x) *((volatile u8 *)(DEFAULT_RCBA + x))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@246">Patch Set #1, Line 246:</a> <code style="font-family:monospace,monospace">#define RCBA16(x) *((volatile u16 *)(DEFAULT_RCBA + x))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@247">Patch Set #1, Line 247:</a> <code style="font-family:monospace,monospace">#define RCBA32(x) *((volatile u32 *)(DEFAULT_RCBA + x))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@249">Patch Set #1, Line 249:</a> <code style="font-family:monospace,monospace">#define RCBA_AND_OR(bits, x, and, or) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@250">Patch Set #1, Line 250:</a> <code style="font-family:monospace,monospace"> RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@250">Patch Set #1, Line 250:</a> <code style="font-family:monospace,monospace"> RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@296">Patch Set #1, Line 296:</a> <code style="font-family:monospace,monospace">#define RPFN_FNGET(reg,port) (((reg) >> ((port) * 4)) & 7)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@298">Patch Set #1, Line 298:</a> <code style="font-family:monospace,monospace">#define RPFN_FNSET(port,func) (((func) & 7) << ((port) * 4))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@386">Patch Set #1, Line 386:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@386">Patch Set #1, Line 386:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@386">Patch Set #1, Line 386:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@386">Patch Set #1, Line 386:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that ',' (ctx:VxV)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@386">Patch Set #1, Line 386:</a> <code style="font-family:monospace,monospace">#define DIR_ROUTE(x,a,b,c,d) \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@387">Patch Set #1, Line 387:</a> <code style="font-family:monospace,monospace"> RCBA32(x) = (((d) << DIR_IDR) | ((c) << DIR_ICR) | \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@388">Patch Set #1, Line 388:</a> <code style="font-family:monospace,monospace"> ((b) << DIR_IBR) | ((a) << DIR_IAR))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27038/1/src/southbridge/intel/ibexpeak/pch.h@388">Patch Set #1, Line 388:</a> <code style="font-family:monospace,monospace"> ((b) << DIR_IBR) | ((a) << DIR_IAR))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no spaces at the start of a line</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27038">change 27038</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27038"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Icbf4db8590e60573c8c11385835e0231cf8d63e6 </div>
<div style="display:none"> Gerrit-Change-Number: 27038 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 12 Jun 2018 21:27:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>