<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27012">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/fizz: fix LAN driver chip_info attachment<br><br>As a result of commit:<br>[711fb81] soc/intel/skylake: Swap PCI devfn resides in same PCI device<br><br>fizz's chip_info for the LAN driver is being overwritten/nulled, as the<br>LAN device is on function 2 (PCIe port 3), but the driver info was set<br>for the post-swapped PCIe port (1).<br>Move the driver chip_info to function 2/port 3, so that it follows the<br>PCI device function when swapped after FSP-s, and is correctly passed<br>to the LAN driver.<br><br>Test: boot google/fizz (teemo variant), check cbmem console and<br>verify ethernet MAC address and LED config correctly set.<br><br>Change-Id: I08810c0c89d99af5799f42c7c4e51814f09aafec<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/fizz/devicetree.cb<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/27012/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb</span><br><span>index 67828d1..0ac403e 100644</span><br><span>--- a/src/mainboard/google/fizz/devicetree.cb</span><br><span>+++ b/src/mainboard/google/fizz/devicetree.cb</span><br><span>@@ -429,17 +429,17 @@</span><br><span> end</span><br><span> end # I2C #5</span><br><span> device pci 19.2 off end # I2C #4</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.0 on # PCI Express Port 1</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.0 on end # PCI Express Port 1</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.1 off end # PCI Express Port 2</span><br><span style="color: hsl(120, 100%, 40%);">+ # PCI Express Port 3 for LAN, will be swapped to port 1 by FSP</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1c.2 on</span><br><span> chip drivers/net</span><br><span> register "customized_leds" = "0x0fa5"</span><br><span> register "wake" = "GPE0_PCI_EXP"</span><br><span> register "device_index" = "1"</span><br><span> device pci 00.0 on end</span><br><span> end</span><br><span style="color: hsl(0, 100%, 40%);">- end # PCI Express Port 1</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.1 off end # PCI Express Port 2</span><br><span style="color: hsl(0, 100%, 40%);">- # PCI Express Port 3 for LAN, but will be swapped to port 1</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1c.2 on end</span><br><span style="color: hsl(120, 100%, 40%);">+ end # PCI Express Port 3</span><br><span> device pci 1c.3 on</span><br><span> chip drivers/intel/wifi</span><br><span> register "wake" = "GPE0_PCI_EXP"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27012">change 27012</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27012"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I08810c0c89d99af5799f42c7c4e51814f09aafec </div>
<div style="display:none"> Gerrit-Change-Number: 27012 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>