<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27009">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/i2c/generic: Encure config is not NULL before accessing it<br><br>This change checks to ensure that config is not NULL before it is<br>accessed for the first time.<br><br>Reported by: Coverity CID #1393312<br><br>Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/drivers/i2c/generic/generic.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/27009/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c</span><br><span>index 7f1ce16..1b12df5 100644</span><br><span>--- a/src/drivers/i2c/generic/generic.c</span><br><span>+++ b/src/drivers/i2c/generic/generic.c</span><br><span>@@ -202,6 +202,9 @@</span><br><span> {</span><br><span>  struct drivers_i2c_generic_config *config = dev->chip_info;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    if (!config)</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    /* Check if device is present by reading GPIO */</span><br><span>     if (config->device_present_gpio) {</span><br><span>                int present = gpio_get(config->device_present_gpio);</span><br><span>@@ -219,9 +222,8 @@</span><br><span>        dev->ops = &i2c_generic_ops;</span><br><span> </span><br><span>      /* Name the device as per description provided in devicetree */</span><br><span style="color: hsl(0, 100%, 40%);">- if (config && config->desc) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (config->desc)</span><br><span>                 dev->name = config->desc;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span> </span><br><span> struct chip_operations drivers_i2c_generic_ops = {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27009">change 27009</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27009"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c </div>
<div style="display:none"> Gerrit-Change-Number: 27009 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>