<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/26950">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Raul Rangel: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Use 66MHz SPI clock for fast read<br><br>Looking at the 100MHz signal, we were violating the timing requirements.<br>66MHz still isn't great, but it's a good tradeoff between improving<br>the signal and losing boot speed time.<br><br>This slows down the boot time by about 20mS.<br><br>BUG=b:109583457<br>TEST=Boot grunt, look at signal on scope<br><br>Change-Id: I7ce70c992822dd17c5877226e74c1890660768c6<br>Signed-off-by: Martin Roth <martinroth@google.com><br>Reviewed-on: https://review.coreboot.org/26950<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Raul Rangel <rrangel@chromium.org><br>---<br>M src/mainboard/google/kahlee/bootblock/bootblock.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c</span><br><span>index 8f124b3..7e6524d 100644</span><br><span>--- a/src/mainboard/google/kahlee/bootblock/bootblock.c</span><br><span>+++ b/src/mainboard/google/kahlee/bootblock/bootblock.c</span><br><span>@@ -44,7 +44,7 @@</span><br><span> </span><br><span> /* Set SPI speeds before verstage. Needed for TPM */</span><br><span> sb_set_spi100(SPI_SPEED_33M, /* Normal */</span><br><span style="color: hsl(0, 100%, 40%);">- SPI_SPEED_100M, /* Fast */</span><br><span style="color: hsl(120, 100%, 40%);">+ SPI_SPEED_66M, /* Fast */</span><br><span> SPI_SPEED_66M, /* AltIO */</span><br><span> SPI_SPEED_66M); /* TPM */</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26950">change 26950</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26950"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I7ce70c992822dd17c5877226e74c1890660768c6 </div>
<div style="display:none"> Gerrit-Change-Number: 26950 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>