<p>Rajneesh Bhardwaj would like Haridhar Kalvala to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/26940">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Enable low power S0Idle capability<br><br>This patch sets the ACPI FADT flag ACPI_FADT_LOW_POWER_S0<br>if S0ix is enabled for the platform. This also sets the<br>FSPUPD to indicate the status of S0ix on the platform.<br><br>BUG=b:79559085<br>TEST= Boot to OS and check the ACPI_FADT_LOW_PWR_IDLE_S0<br>      flag is set in FACP table - FADT.Flags[21] bit.<br><br>Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210<br>Signed-off-by: Haridhar Kalvala <haridhar.kalvala@intel.com><br>Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com><br>---<br>M src/soc/intel/skylake/acpi.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/26940/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c</span><br><span>index be1200b..560b20c 100644</span><br><span>--- a/src/soc/intel/skylake/acpi.c</span><br><span>+++ b/src/soc/intel/skylake/acpi.c</span><br><span>@@ -234,6 +234,8 @@</span><br><span> </span><br><span> void acpi_fill_fadt(acpi_fadt_t *fadt)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+        const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC);</span><br><span style="color: hsl(120, 100%, 40%);">+        const struct soc_intel_skylake_config *config = dev->chip_info;</span><br><span>        const uint16_t pmbase = ACPI_BASE_ADDRESS;</span><br><span> </span><br><span>       /* Use ACPI 3.0 revision */</span><br><span>@@ -282,6 +284,9 @@</span><br><span>                    ACPI_FADT_RESET_REGISTER | ACPI_FADT_SEALED_CASE |</span><br><span>                   ACPI_FADT_S4_RTC_WAKE | ACPI_FADT_PLATFORM_CLOCK;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        if(config->s0ix_enable)</span><br><span style="color: hsl(120, 100%, 40%);">+                fadt->flags |= ACPI_FADT_LOW_PWR_IDLE_S0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    fadt->reset_reg.space_id = 1;</span><br><span>     fadt->reset_reg.bit_width = 8;</span><br><span>    fadt->reset_reg.bit_offset = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26940">change 26940</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26940"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210 </div>
<div style="display:none"> Gerrit-Change-Number: 26940 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Haridhar Kalvala <haridhar.kalvala@intel.com> </div>