<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26878">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile.inc: Skip -fconserve-stack flag if running scan-build<br><br>Scan-build refuses to run if the -fconserve-stack flag is added to<br>cflags.  It fails with the cryptic message "could not find clang line".<br><br>Change-Id: Ib1b56ef7d217138a1a195fe993d8e8dd965bd855<br>Signed-off-by: Martin Roth <gaumless@gmail.com><br>---<br>M Makefile.inc<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/26878/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile.inc b/Makefile.inc</span><br><span>index ec086b9..b7c4904 100644</span><br><span>--- a/Makefile.inc</span><br><span>+++ b/Makefile.inc</span><br><span>@@ -395,7 +395,11 @@</span><br><span> CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer</span><br><span> CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie</span><br><span> ifeq ($(CONFIG_COMPILER_GCC),y)</span><br><span style="color: hsl(0, 100%, 40%);">-CFLAGS_common += -fno-delete-null-pointer-checks -fconserve-stack</span><br><span style="color: hsl(120, 100%, 40%);">+CFLAGS_common += -fno-delete-null-pointer-checks</span><br><span style="color: hsl(120, 100%, 40%);">+# Don't add these GCC specific flags when running scan-build</span><br><span style="color: hsl(120, 100%, 40%);">+ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),)</span><br><span style="color: hsl(120, 100%, 40%);">+CFLAGS_common += -fconserve-stack</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span> endif</span><br><span> </span><br><span> ADAFLAGS_common += -gnatp</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26878">change 26878</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26878"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib1b56ef7d217138a1a195fe993d8e8dd965bd855 </div>
<div style="display:none"> Gerrit-Change-Number: 26878 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>