<p>Naresh Solanki has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26864">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">arch/x86/smbios: smbios walk on enabled devices<br><br>Check whether device is enabled before calling smbios ops.<br><br>BUG=None<br>BRANCH=None<br>TEST=Build & boot Soraka.<br><br>Change-Id: I79681c10679e1de3a2d177503f29239968d0c157<br>Signed-off-by: Naresh G Solanki <naresh.solanki@intel.com><br>---<br>M src/arch/x86/smbios.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/26864/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c</span><br><span>index 25a41b5..1a3bb22 100644</span><br><span>--- a/src/arch/x86/smbios.c</span><br><span>+++ b/src/arch/x86/smbios.c</span><br><span>@@ -675,10 +675,11 @@</span><br><span>       int len = 0;</span><br><span> </span><br><span>     for (dev = tree; dev; dev = dev->next) {</span><br><span style="color: hsl(0, 100%, 40%);">-             printk(BIOS_INFO, "%s (%s)\n", dev_path(dev), dev_name(dev));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-         if (dev->ops && dev->ops->get_smbios_data)</span><br><span style="color: hsl(120, 100%, 40%);">+           if (dev->enabled && dev->ops && dev->ops->get_smbios_data) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      printk(BIOS_INFO, "%s (%s)\n", dev_path(dev), \</span><br><span style="color: hsl(120, 100%, 40%);">+                             dev_name(dev));</span><br><span>                      len += dev->ops->get_smbios_data(dev, handle, current);</span><br><span style="color: hsl(120, 100%, 40%);">+         }</span><br><span>    }</span><br><span>    return len;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26864">change 26864</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26864"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I79681c10679e1de3a2d177503f29239968d0c157 </div>
<div style="display:none"> Gerrit-Change-Number: 26864 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Naresh Solanki <naresh.solanki@intel.com> </div>