<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26853">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Add missing entries to pmc_to_gpio_route for GLK<br><br>This change adds missing entries in PMC to GPIO route mapping for GLK.<br><br>BUG=b:77224247<br><br>Change-Id: I66cadaa23b8bd4518a199733c8fba81168e60323<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/soc/intel/apollolake/gpio_glk.c<br>M src/soc/intel/apollolake/include/soc/pm.h<br>2 files changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/26853/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/gpio_glk.c b/src/soc/intel/apollolake/gpio_glk.c</span><br><span>index a998118..037273c 100644</span><br><span>--- a/src/soc/intel/apollolake/gpio_glk.c</span><br><span>+++ b/src/soc/intel/apollolake/gpio_glk.c</span><br><span>@@ -131,11 +131,19 @@</span><br><span> const struct pmc_to_gpio_route *soc_pmc_gpio_routes(size_t *num)</span><br><span> {</span><br><span> static const struct pmc_to_gpio_route routes[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ { PMC_GPE_SCC_31_0, GPIO_GPE_SCC_31_0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ { PMC_GPE_SCC_63_32, GPIO_GPE_SCC_63_32 },</span><br><span> { PMC_GPE_NW_31_0, GPIO_GPE_NW_31_0 },</span><br><span> { PMC_GPE_NW_63_32, GPIO_GPE_NW_63_32 },</span><br><span style="color: hsl(120, 100%, 40%);">+ { PMC_GPE_NW_95_64, GPIO_GPE_NW_95_64 },</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * PMC_GPE_NW_127_96 maps to GPIO group 3, which is reserved and</span><br><span style="color: hsl(120, 100%, 40%);">+ * cannot be set in GPE0_DWx. Hence, it is skipped here.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> { PMC_GPE_N_31_0, GPIO_GPE_N_31_0 },</span><br><span> { PMC_GPE_N_63_32, GPIO_GPE_N_63_32 },</span><br><span> { PMC_GPE_N_95_64, GPIO_GPE_N_95_64 },</span><br><span style="color: hsl(120, 100%, 40%);">+ { PMC_GPE_AUDIO_31_0, GPIO_GPE_AUDIO_31_0 },</span><br><span> };</span><br><span> *num = ARRAY_SIZE(routes);</span><br><span> return routes;</span><br><span>diff --git a/src/soc/intel/apollolake/include/soc/pm.h b/src/soc/intel/apollolake/include/soc/pm.h</span><br><span>index e8ec645..6de39a0 100644</span><br><span>--- a/src/soc/intel/apollolake/include/soc/pm.h</span><br><span>+++ b/src/soc/intel/apollolake/include/soc/pm.h</span><br><span>@@ -196,6 +196,7 @@</span><br><span> #define GPE0_DW_SHIFT(x) (4 + 4*(x))</span><br><span> </span><br><span> #if IS_ENABLED(CONFIG_SOC_INTEL_GLK)</span><br><span style="color: hsl(120, 100%, 40%);">+#define PMC_GPE_AUDIO_31_0 9</span><br><span> #define PMC_GPE_N_95_64 8</span><br><span> #define PMC_GPE_N_63_32 7</span><br><span> #define PMC_GPE_N_31_0 6</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26853">change 26853</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26853"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I66cadaa23b8bd4518a199733c8fba81168e60323 </div>
<div style="display:none"> Gerrit-Change-Number: 26853 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>