<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26734">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">northbridge/intel: Remove unneeded includes<br><br>Change-Id: Id299295784d6fcb04234b085566995bbd8a03d01<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/northbridge/intel/fsp_rangeley/northbridge.c<br>M src/northbridge/intel/fsp_sandybridge/northbridge.c<br>M src/northbridge/intel/gm45/gma.c<br>M src/northbridge/intel/haswell/northbridge.c<br>M src/northbridge/intel/i945/raminit.c<br>M src/northbridge/intel/nehalem/gma.c<br>M src/northbridge/intel/nehalem/northbridge.c<br>M src/northbridge/intel/nehalem/raminit.c<br>M src/northbridge/intel/pineview/gma.c<br>M src/northbridge/intel/pineview/raminit.c<br>M src/northbridge/intel/sandybridge/gma.c<br>M src/northbridge/intel/sandybridge/northbridge.c<br>M src/northbridge/intel/sandybridge/raminit_common.c<br>M src/northbridge/intel/sandybridge/raminit_ivy.c<br>M src/northbridge/intel/sandybridge/raminit_sandy.c<br>M src/northbridge/intel/x4x/gma.c<br>16 files changed, 0 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/26734/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.c b/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>index af652ee..27153f8 100644</span><br><span>--- a/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>+++ b/src/northbridge/intel/fsp_rangeley/northbridge.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <delay.h></span><br><span> #include <cpu/intel/fsp_model_406dx/model_406dx.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span>diff --git a/src/northbridge/intel/fsp_sandybridge/northbridge.c b/src/northbridge/intel/fsp_sandybridge/northbridge.c</span><br><span>index 1016c8b..24969d4 100644</span><br><span>--- a/src/northbridge/intel/fsp_sandybridge/northbridge.c</span><br><span>+++ b/src/northbridge/intel/fsp_sandybridge/northbridge.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <delay.h></span><br><span> #include <cpu/intel/fsp_model_206ax/model_206ax.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span>diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c</span><br><span>index 237071c..f0171e6 100644</span><br><span>--- a/src/northbridge/intel/gm45/gma.c</span><br><span>+++ b/src/northbridge/intel/gm45/gma.c</span><br><span>@@ -22,8 +22,6 @@</span><br><span> #include <device/pci_ids.h></span><br><span> #include <string.h></span><br><span> #include <device/pci_ops.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <commonlib/helpers.h></span><br><span> #include <cbmem.h></span><br><span> #include <southbridge/intel/i82801ix/nvs.h></span><br><span>diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c</span><br><span>index 613e982..f61a478 100644</span><br><span>--- a/src/northbridge/intel/haswell/northbridge.c</span><br><span>+++ b/src/northbridge/intel/haswell/northbridge.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> #include <stdint.h></span><br><span> #include <delay.h></span><br><span> #include <cpu/intel/haswell/haswell.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span>diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c</span><br><span>index 483d5d3..6719961 100644</span><br><span>--- a/src/northbridge/intel/i945/raminit.c</span><br><span>+++ b/src/northbridge/intel/i945/raminit.c</span><br><span>@@ -15,7 +15,6 @@</span><br><span>  */</span><br><span> </span><br><span> #include <console/console.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <cpu/x86/cache.h></span><br><span> #include <device/pci_def.h></span><br><span> #include <device/device.h></span><br><span>diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c</span><br><span>index 6b8b98e..aeff69a 100644</span><br><span>--- a/src/northbridge/intel/nehalem/gma.c</span><br><span>+++ b/src/northbridge/intel/nehalem/gma.c</span><br><span>@@ -22,8 +22,6 @@</span><br><span> #include <device/pci_ids.h></span><br><span> #include <string.h></span><br><span> #include <device/pci_ops.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <drivers/intel/gma/edid.h></span><br><span> #include <drivers/intel/gma/i915.h></span><br><span> #include <drivers/intel/gma/intel_bios.h></span><br><span>diff --git a/src/northbridge/intel/nehalem/northbridge.c b/src/northbridge/intel/nehalem/northbridge.c</span><br><span>index 0303e92..6fc61c3 100644</span><br><span>--- a/src/northbridge/intel/nehalem/northbridge.c</span><br><span>+++ b/src/northbridge/intel/nehalem/northbridge.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <delay.h></span><br><span> #include <cpu/intel/model_2065x/model_2065x.h></span><br><span> #include <cpu/x86/msr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span>diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c</span><br><span>index 6a27b57..ca7fddb 100644</span><br><span>--- a/src/northbridge/intel/nehalem/raminit.c</span><br><span>+++ b/src/northbridge/intel/nehalem/raminit.c</span><br><span>@@ -40,7 +40,6 @@</span><br><span> #include "raminit.h"</span><br><span> #include "chip.h"</span><br><span> #include <timestamp.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <cpu/intel/speedstep.h></span><br><span> #include <cpu/intel/turbo.h></span><br><span> #include <mrc_cache.h></span><br><span>diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c</span><br><span>index ec332e6..8cf4d22 100644</span><br><span>--- a/src/northbridge/intel/pineview/gma.c</span><br><span>+++ b/src/northbridge/intel/pineview/gma.c</span><br><span>@@ -23,8 +23,6 @@</span><br><span> #include <device/pci_ids.h></span><br><span> #include <string.h></span><br><span> #include <device/pci_ops.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> </span><br><span> #include <drivers/intel/gma/i915_reg.h></span><br><span> #include "chip.h"</span><br><span>diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c</span><br><span>index 1f03820..356c730 100644</span><br><span>--- a/src/northbridge/intel/pineview/raminit.c</span><br><span>+++ b/src/northbridge/intel/pineview/raminit.c</span><br><span>@@ -17,7 +17,6 @@</span><br><span> #include <arch/io.h></span><br><span> #include <console/console.h></span><br><span> #include <cpu/x86/cache.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <delay.h></span><br><span> #include <halt.h></span><br><span> #include <lib.h></span><br><span>diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c</span><br><span>index 201498a..73546ce 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/gma.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/gma.c</span><br><span>@@ -22,8 +22,6 @@</span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span> #include <device/pci_ops.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <drivers/intel/gma/libgfxinit.h></span><br><span> #include <southbridge/intel/bd82x6x/nvs.h></span><br><span> #include <drivers/intel/gma/opregion.h></span><br><span>diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>index eb8ce26..8c2aaf3 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/northbridge.c</span><br><span>@@ -21,7 +21,6 @@</span><br><span> #include <delay.h></span><br><span> #include <cpu/intel/model_206ax/model_206ax.h></span><br><span> #include <cpu/x86/msr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <device/device.h></span><br><span> #include <device/pci.h></span><br><span> #include <device/pci_ids.h></span><br><span>diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>index 5f6753f..b82075e 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit_common.c</span><br><span>@@ -26,7 +26,6 @@</span><br><span> #include <device/pci_def.h></span><br><span> #include <delay.h></span><br><span> #include <arch/cpu.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span> #include "raminit_native.h"</span><br><span> #include "raminit_common.h"</span><br><span> #include "sandybridge.h"</span><br><span>diff --git a/src/northbridge/intel/sandybridge/raminit_ivy.c b/src/northbridge/intel/sandybridge/raminit_ivy.c</span><br><span>index 19dea2f..88d8bd6 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit_ivy.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit_ivy.c</span><br><span>@@ -17,7 +17,6 @@</span><br><span> </span><br><span> #include <console/console.h></span><br><span> #include <console/usb.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span> #include <delay.h></span><br><span> #include <arch/io.h></span><br><span> #include <device/pci_ops.h></span><br><span>diff --git a/src/northbridge/intel/sandybridge/raminit_sandy.c b/src/northbridge/intel/sandybridge/raminit_sandy.c</span><br><span>index 99c107e..9fa6c7b 100644</span><br><span>--- a/src/northbridge/intel/sandybridge/raminit_sandy.c</span><br><span>+++ b/src/northbridge/intel/sandybridge/raminit_sandy.c</span><br><span>@@ -17,7 +17,6 @@</span><br><span> </span><br><span> #include <console/console.h></span><br><span> #include <console/usb.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span> #include <delay.h></span><br><span> #include "raminit_native.h"</span><br><span> #include "raminit_common.h"</span><br><span>diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c</span><br><span>index 8ce1a5d..6c6f3a2 100644</span><br><span>--- a/src/northbridge/intel/x4x/gma.c</span><br><span>+++ b/src/northbridge/intel/x4x/gma.c</span><br><span>@@ -23,8 +23,6 @@</span><br><span> #include <device/pci_ids.h></span><br><span> #include <string.h></span><br><span> #include <device/pci_ops.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/msr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <cpu/x86/mtrr.h></span><br><span> #include <commonlib/helpers.h></span><br><span> #include <cbmem.h></span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26734">change 26734</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26734"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id299295784d6fcb04234b085566995bbd8a03d01 </div>
<div style="display:none"> Gerrit-Change-Number: 26734 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>