<p><a href="https://review.coreboot.org/26610">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/f2a85-m/buildOpts.c">File src/mainboard/asus/f2a85-m/buildOpts.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/f2a85-m/buildOpts.c@173">Patch Set #3, Line 173:</a> <code style="font-family:monospace,monospace">//#define BLDCFG_UMA_ALLOCATION_SIZE           0x1000//0x1800//0x1000 /* (1000 << 16) = 256M*/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/f2a85-m/buildOpts.c@173">Patch Set #3, Line 173:</a> <code style="font-family:monospace,monospace">//#define BLDCFG_UMA_ALLOCATION_SIZE           0x1000//0x1800//0x1000 /* (1000 << 16) = 256M*/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/f2a85-m/buildOpts.c@174">Patch Set #3, Line 174:</a> <code style="font-family:monospace,monospace">#define BLDCFG_UMA_ALLOCATION_SIZE                0x2000//512M</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please, no space before tabs</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/kcma-d8/resourcemap.c">File src/mainboard/asus/kcma-d8/resourcemap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/kcma-d8/resourcemap.c@229">Patch Set #3, Line 229:</a> <code style="font-family:monospace,monospace">//            PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xC0), 0xFE000FCC, 0x00001013,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/kcma-d8/resourcemap.c@484">Patch Set #3, Line 484:</a> <code style="font-family:monospace,monospace">//              PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xC0), 0xFE000FCC, 0x00001013,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/kgpe-d16/resourcemap.c">File src/mainboard/asus/kgpe-d16/resourcemap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/kgpe-d16/resourcemap.c@229">Patch Set #3, Line 229:</a> <code style="font-family:monospace,monospace">//          PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xC0), 0xFE000FCC, 0x00001013,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26610/3/src/mainboard/asus/kgpe-d16/resourcemap.c@484">Patch Set #3, Line 484:</a> <code style="font-family:monospace,monospace">//             PCI_ADDR(CONFIG_CBB, CONFIG_CDB, 1, 0xC0), 0xFE000FCC, 0x00001013,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26610">change 26610</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26610"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id572144827b515e9e84c51aa3e4f8a20baf1c212 </div>
<div style="display:none"> Gerrit-Change-Number: 26610 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 30 May 2018 07:28:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>