<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/26696">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Rename Pos_Type --> Position_Type<br><br>Yet after few months, it's already too confusing to me. Let's reserve<br>`Pos` for `Positive` and spell out `Position`.<br><br>Change-Id: I3445d20665ae6a993cb0e46d08e8f3148abef40e<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M common/hw-gfx.ads<br>M gfxtest/hw-gfx-gma-gfx_test.adb<br>2 files changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/96/26696/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/hw-gfx.ads b/common/hw-gfx.ads</span><br><span>index 1ab2518..7403a86 100644</span><br><span>--- a/common/hw-gfx.ads</span><br><span>+++ b/common/hw-gfx.ads</span><br><span>@@ -25,9 +25,9 @@</span><br><span> subtype Pos_Pixel_Type is Pixel_Type range 1 .. Pixel_Type'Last;</span><br><span> </span><br><span> -- Allow same range for width and height (for rotated framebuffers)</span><br><span style="color: hsl(0, 100%, 40%);">- subtype Width_Type is Pos32 range 1 .. 8192;</span><br><span style="color: hsl(0, 100%, 40%);">- subtype Height_Type is Pos32 range 1 .. 8192;</span><br><span style="color: hsl(0, 100%, 40%);">- subtype Pos_Type is Int32 range 0 .. 4095;</span><br><span style="color: hsl(120, 100%, 40%);">+ subtype Width_Type is Pos32 range 1 .. 8192;</span><br><span style="color: hsl(120, 100%, 40%);">+ subtype Height_Type is Pos32 range 1 .. 8192;</span><br><span style="color: hsl(120, 100%, 40%);">+ subtype Position_Type is Int32 range 0 .. 4095;</span><br><span> </span><br><span> Auto_BPC : constant := 5;</span><br><span> subtype BPC_Type is Int64 range Auto_BPC .. 16;</span><br><span>@@ -41,8 +41,8 @@</span><br><span> record</span><br><span> Width : Width_Type;</span><br><span> Height : Height_Type;</span><br><span style="color: hsl(0, 100%, 40%);">- Start_X : Pos_Type;</span><br><span style="color: hsl(0, 100%, 40%);">- Start_Y : Pos_Type;</span><br><span style="color: hsl(120, 100%, 40%);">+ Start_X : Position_Type;</span><br><span style="color: hsl(120, 100%, 40%);">+ Start_Y : Position_Type;</span><br><span> BPC : BPC_Type;</span><br><span> Stride : Width_Type;</span><br><span> V_Stride : Height_Type;</span><br><span>diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>index 94ee312..bf6e917 100644</span><br><span>--- a/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>+++ b/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>@@ -19,9 +19,9 @@</span><br><span> Secondary_Delay_MS : constant := 4_000;</span><br><span> Seed : constant := 12345;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- package Rand_P is new Ada.Numerics.Discrete_Random (Pos_Type);</span><br><span style="color: hsl(120, 100%, 40%);">+ package Rand_P is new Ada.Numerics.Discrete_Random (Position_Type);</span><br><span> Gen : Rand_P.Generator;</span><br><span style="color: hsl(0, 100%, 40%);">- function Rand return Pos_Type is (Rand_P.Random (Gen));</span><br><span style="color: hsl(120, 100%, 40%);">+ function Rand return Position_Type is (Rand_P.Random (Gen));</span><br><span> </span><br><span> Start_X : constant := 0;</span><br><span> Start_Y : constant := 0;</span><br><span>@@ -384,7 +384,7 @@</span><br><span> declare</span><br><span> New_Pipes : GMA.Pipe_Configs := Pipes;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- function Rand_Div (Num : Pos_Type) return Pos_Type is</span><br><span style="color: hsl(120, 100%, 40%);">+ function Rand_Div (Num : Position_Type) return Position_Type is</span><br><span> (case Rand mod 4 is</span><br><span> when 3 => Rand mod Num / 3,</span><br><span> when 2 => Rand mod Num / 2,</span><br><span>@@ -404,9 +404,9 @@</span><br><span> Height : constant Height_Type :=</span><br><span> Pipes (Pipe).Framebuffer.Height;</span><br><span> begin</span><br><span style="color: hsl(0, 100%, 40%);">- New_FB.Start_X := Pos_Type'Min</span><br><span style="color: hsl(120, 100%, 40%);">+ New_FB.Start_X := Position_Type'Min</span><br><span> (Width - 320, Rand_Div (Width));</span><br><span style="color: hsl(0, 100%, 40%);">- New_FB.Start_Y := Pos_Type'Min</span><br><span style="color: hsl(120, 100%, 40%);">+ New_FB.Start_Y := Position_Type'Min</span><br><span> (Height - 320, Rand_Div (Height));</span><br><span> New_FB.Width := Width_Type'Max</span><br><span> (320, Width - New_FB.Start_X - Rand_Div (Width));</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/26696">change 26696</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26696"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3445d20665ae6a993cb0e46d08e8f3148abef40e </div>
<div style="display:none"> Gerrit-Change-Number: 26696 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>