<p><a href="https://review.coreboot.org/26353">View Change</a></p><p>46 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c">File src/device/oprom/x86emu/prim_ops.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@195">Patch Set #12, Line 195:</a> <code style="font-family:monospace,monospace"> if (set_carry) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@207">Patch Set #12, Line 207:</a> <code style="font-family:monospace,monospace"> if (set_carry) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@297">Patch Set #12, Line 297:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@316">Patch Set #12, Line 316:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@765">Patch Set #12, Line 765:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 9) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@812">Patch Set #12, Line 812:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 17) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@817">Patch Set #12, Line 817:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@836">Patch Set #12, Line 836:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 33) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@883">Patch Set #12, Line 883:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 9) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@888">Patch Set #12, Line 888:</a> <code style="font-family:monospace,monospace"> /* note hackery here. Access_flag(..) evaluates to either</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@947">Patch Set #12, Line 947:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 17) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@956">Patch Set #12, Line 956:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@979">Patch Set #12, Line 979:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 33) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@988">Patch Set #12, Line 988:</a> <code style="font-family:monospace,monospace"> if (cnt != 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1028">Patch Set #12, Line 1028:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 8) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1061">Patch Set #12, Line 1061:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 16) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1086">Patch Set #12, Line 1086:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 32) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1126">Patch Set #12, Line 1126:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1157">Patch Set #12, Line 1157:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 16) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1180">Patch Set #12, Line 1180:</a> <code style="font-family:monospace,monospace"> if ((cnt = s % 32) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1290">Patch Set #12, Line 1290:</a> <code style="font-family:monospace,monospace"> CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1325">Patch Set #12, Line 1325:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1360">Patch Set #12, Line 1360:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1394">Patch Set #12, Line 1394:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1426">Patch Set #12, Line 1426:</a> <code style="font-family:monospace,monospace"> if (sf) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1464">Patch Set #12, Line 1464:</a> <code style="font-family:monospace,monospace"> if (sf) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1502">Patch Set #12, Line 1502:</a> <code style="font-family:monospace,monospace"> if (sf) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1578">Patch Set #12, Line 1578:</a> <code style="font-family:monospace,monospace"> CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1613">Patch Set #12, Line 1613:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1647">Patch Set #12, Line 1647:</a> <code style="font-family:monospace,monospace"> if (cnt == 1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1672">Patch Set #12, Line 1672:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1696">Patch Set #12, Line 1696:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1720">Patch Set #12, Line 1720:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_CF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for any arm of this statement</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1938">Patch Set #12, Line 1938:</a> <code style="font-family:monospace,monospace"> if ((d_sign = d & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1938">Patch Set #12, Line 1938:</a> <code style="font-family:monospace,monospace"> if ((d_sign = d & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1943">Patch Set #12, Line 1943:</a> <code style="font-family:monospace,monospace"> if ((s_sign = s & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">do not use assignment in if condition</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@1943">Patch Set #12, Line 1943:</a> <code style="font-family:monospace,monospace"> if ((s_sign = s & 0x80000000) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2321">Patch Set #12, Line 2321:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_DF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2366">Patch Set #12, Line 2366:</a> <code style="font-family:monospace,monospace"> if (ACCESS_FLAG(F_DF)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2379">Patch Set #12, Line 2379:</a> <code style="font-family:monospace,monospace"> if (M.x86.mode & SYSMODE_32BIT_REP) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2475">Patch Set #12, Line 2475:</a> <code style="font-family:monospace,monospace"> /* Regardless if we have real data from the hardware, the emulator</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2476">Patch Set #12, Line 2476:</a> <code style="font-family:monospace,monospace"> * will only support upto feature 1, which we set in register EAX.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2486">Patch Set #12, Line 2486:</a> <code style="font-family:monospace,monospace"> /* If we don't have x86 compatible hardware, we return values from an</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2487">Patch Set #12, Line 2487:</a> <code style="font-family:monospace,monospace"> * Intel 486dx4; which was one of the first processors to have CPUID.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2493">Patch Set #12, Line 2493:</a> <code style="font-family:monospace,monospace"> /* In the case that we have hardware CPUID instruction, we make sure</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26353/12/src/device/oprom/x86emu/prim_ops.c@2500">Patch Set #12, Line 2500:</a> <code style="font-family:monospace,monospace"> * return all zeros when queried for invalid or unsupported feature</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26353">change 26353</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26353"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I010f3e02813d38293a7ab7fc84f60b8c2ec098a7 </div>
<div style="display:none"> Gerrit-Change-Number: 26353 </div>
<div style="display:none"> Gerrit-PatchSet: 12 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 30 May 2018 12:23:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>