<p><a href="https://review.coreboot.org/26604">View Change</a></p><p>10 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb800/late.c">File src/southbridge/amd/cimx/sb800/late.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb800/late.c@355">Patch Set #4, Line 355:</a> <code style="font-family:monospace,monospace">                       sb_config->SATAMODE.SataMode.SataController = CIMX_OPTION_ENABLED;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb800/late.c@361">Patch Set #4, Line 361:</a> <code style="font-family:monospace,monospace">                        sb_config->SATAMODE.SataMode.SataController = CIMX_OPTION_DISABLED;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb800/late.c@390">Patch Set #4, Line 390:</a> <code style="font-family:monospace,monospace">                       if (AZALIA_DISABLE == sb_config->AzaliaController) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comparisons should place the constant on the right side of the test</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb800/late.c@390">Patch Set #4, Line 390:</a> <code style="font-family:monospace,monospace">                  if (AZALIA_DISABLE == sb_config->AzaliaController) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb900/late.c">File src/southbridge/amd/cimx/sb900/late.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb900/late.c@383">Patch Set #4, Line 383:</a> <code style="font-family:monospace,monospace">                   sb_config->SATAMODE.SataMode.SataIdeCombinedMode = DISABLED;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb900/late.c@390">Patch Set #4, Line 390:</a> <code style="font-family:monospace,monospace">                      if (AZALIA_DISABLE == sb_config->AzaliaController) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comparisons should place the constant on the right side of the test</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/cimx/sb900/late.c@390">Patch Set #4, Line 390:</a> <code style="font-family:monospace,monospace">                  if (AZALIA_DISABLE == sb_config->AzaliaController) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/rs780/gfx.c">File src/southbridge/amd/rs780/gfx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/rs780/gfx.c@455">Patch Set #4, Line 455:</a> <code style="font-family:monospace,monospace">     vgainfo.ulBootUpEngineClock = 500 * 100;                // setup option on reference BIOS, 500 is default</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/rs780/rs780.c">File src/southbridge/amd/rs780/rs780.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/rs780/rs780.c@96">Patch Set #4, Line 96:</a> <code style="font-family:monospace,monospace">       /* CLKCFG:0xE8 Bit[17] = 0x1     Powerdown clock to IOC GFX block in no external graphics mode */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/sr5650/cmn.h">File src/southbridge/amd/sr5650/cmn.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/26604/4/src/southbridge/amd/sr5650/cmn.h@23">Patch Set #4, Line 23:</a> <code style="font-family:monospace,monospace">#define NBHTIU_INDEX      0x94 /* Note: It is different with RS690, whose HTIU index is 0xA8 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/26604">change 26604</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/26604"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9a2eada93f05b6a4adac3406c33b6e109b733324 </div>
<div style="display:none"> Gerrit-Change-Number: 26604 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 30 May 2018 08:05:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>